http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6674e3ab/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.Status.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.Status.html b/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.Status.html index 5844c3b..80259dd 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.Status.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.Status.html @@ -159,7 +159,7 @@ <span class="sourceLineNo">151</span> }<a name="line.151"></a> <span class="sourceLineNo">152</span> Task task = findOrCreateOrphanTask(path);<a name="line.152"></a> <span class="sourceLineNo">153</span> if (task.isOrphan() && (task.incarnation.get() == 0)) {<a name="line.153"></a> -<span class="sourceLineNo">154</span> LOG.info("resubmitting unassigned orphan task " + path);<a name="line.154"></a> +<span class="sourceLineNo">154</span> LOG.info("Resubmitting unassigned orphan task " + path);<a name="line.154"></a> <span class="sourceLineNo">155</span> // ignore failure to resubmit. The timeout-monitor will handle it later<a name="line.155"></a> <span class="sourceLineNo">156</span> // albeit in a more crude fashion<a name="line.156"></a> <span class="sourceLineNo">157</span> resubmitTask(path, task, FORCE);<a name="line.157"></a> @@ -210,7 +210,7 @@ <span class="sourceLineNo">202</span> SplitLogCounters.tot_mgr_resubmit_force.increment();<a name="line.202"></a> <span class="sourceLineNo">203</span> version = -1;<a name="line.203"></a> <span class="sourceLineNo">204</span> }<a name="line.204"></a> -<span class="sourceLineNo">205</span> LOG.info("resubmitting task " + path);<a name="line.205"></a> +<span class="sourceLineNo">205</span> LOG.info("Resubmitting task " + path);<a name="line.205"></a> <span class="sourceLineNo">206</span> task.incarnation.incrementAndGet();<a name="line.206"></a> <span class="sourceLineNo">207</span> boolean result = resubmit(path, version);<a name="line.207"></a> <span class="sourceLineNo">208</span> if (!result) {<a name="line.208"></a> @@ -288,7 +288,7 @@ <span class="sourceLineNo">280</span> SplitLogCounters.tot_mgr_rescan_deleted.increment();<a name="line.280"></a> <span class="sourceLineNo">281</span> }<a name="line.281"></a> <span class="sourceLineNo">282</span> SplitLogCounters.tot_mgr_missing_state_in_delete.increment();<a name="line.282"></a> -<span class="sourceLineNo">283</span> LOG.debug("deleted task without in memory state " + path);<a name="line.283"></a> +<span class="sourceLineNo">283</span> LOG.debug("Deleted task without in memory state " + path);<a name="line.283"></a> <span class="sourceLineNo">284</span> return;<a name="line.284"></a> <span class="sourceLineNo">285</span> }<a name="line.285"></a> <span class="sourceLineNo">286</span> synchronized (task) {<a name="line.286"></a> @@ -336,13 +336,13 @@ <span class="sourceLineNo">328</span> }<a name="line.328"></a> <span class="sourceLineNo">329</span><a name="line.329"></a> <span class="sourceLineNo">330</span> private void createNodeSuccess(String path) {<a name="line.330"></a> -<span class="sourceLineNo">331</span> LOG.debug("put up splitlog task at znode " + path);<a name="line.331"></a> +<span class="sourceLineNo">331</span> LOG.debug("Put up splitlog task at znode " + path);<a name="line.331"></a> <span class="sourceLineNo">332</span> getDataSetWatch(path, zkretries);<a name="line.332"></a> <span class="sourceLineNo">333</span> }<a name="line.333"></a> <span class="sourceLineNo">334</span><a name="line.334"></a> <span class="sourceLineNo">335</span> private void createNodeFailure(String path) {<a name="line.335"></a> <span class="sourceLineNo">336</span> // TODO the Manager should split the log locally instead of giving up<a name="line.336"></a> -<span class="sourceLineNo">337</span> LOG.warn("failed to create task node" + path);<a name="line.337"></a> +<span class="sourceLineNo">337</span> LOG.warn("Failed to create task node " + path);<a name="line.337"></a> <span class="sourceLineNo">338</span> setDone(path, FAILURE);<a name="line.338"></a> <span class="sourceLineNo">339</span> }<a name="line.339"></a> <span class="sourceLineNo">340</span><a name="line.340"></a> @@ -368,15 +368,15 @@ <span class="sourceLineNo">360</span> data = ZKMetadata.removeMetaData(data);<a name="line.360"></a> <span class="sourceLineNo">361</span> SplitLogTask slt = SplitLogTask.parseFrom(data);<a name="line.361"></a> <span class="sourceLineNo">362</span> if (slt.isUnassigned()) {<a name="line.362"></a> -<span class="sourceLineNo">363</span> LOG.debug("task not yet acquired " + path + " ver = " + version);<a name="line.363"></a> +<span class="sourceLineNo">363</span> LOG.debug("Task not yet acquired " + path + ", ver=" + version);<a name="line.363"></a> <span class="sourceLineNo">364</span> handleUnassignedTask(path);<a name="line.364"></a> <span class="sourceLineNo">365</span> } else if (slt.isOwned()) {<a name="line.365"></a> <span class="sourceLineNo">366</span> heartbeat(path, version, slt.getServerName());<a name="line.366"></a> <span class="sourceLineNo">367</span> } else if (slt.isResigned()) {<a name="line.367"></a> -<span class="sourceLineNo">368</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.368"></a> +<span class="sourceLineNo">368</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.368"></a> <span class="sourceLineNo">369</span> resubmitOrFail(path, FORCE);<a name="line.369"></a> <span class="sourceLineNo">370</span> } else if (slt.isDone()) {<a name="line.370"></a> -<span class="sourceLineNo">371</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.371"></a> +<span class="sourceLineNo">371</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.371"></a> <span class="sourceLineNo">372</span> if (taskFinisher != null && !ZKSplitLog.isRescanNode(watcher, path)) {<a name="line.372"></a> <span class="sourceLineNo">373</span> if (taskFinisher.finish(slt.getServerName(), ZKSplitLog.getFileName(path)) == Status.DONE) {<a name="line.373"></a> <span class="sourceLineNo">374</span> setDone(path, SUCCESS);<a name="line.374"></a> @@ -387,7 +387,7 @@ <span class="sourceLineNo">379</span> setDone(path, SUCCESS);<a name="line.379"></a> <span class="sourceLineNo">380</span> }<a name="line.380"></a> <span class="sourceLineNo">381</span> } else if (slt.isErr()) {<a name="line.381"></a> -<span class="sourceLineNo">382</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.382"></a> +<span class="sourceLineNo">382</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.382"></a> <span class="sourceLineNo">383</span> resubmitOrFail(path, CHECK);<a name="line.383"></a> <span class="sourceLineNo">384</span> } else {<a name="line.384"></a> <span class="sourceLineNo">385</span> LOG.error(HBaseMarkers.FATAL, "logic error - unexpected zk state for path = "<a name="line.385"></a> @@ -403,7 +403,7 @@ <span class="sourceLineNo">395</span> }<a name="line.395"></a> <span class="sourceLineNo">396</span><a name="line.396"></a> <span class="sourceLineNo">397</span> private void getDataSetWatchFailure(String path) {<a name="line.397"></a> -<span class="sourceLineNo">398</span> LOG.warn("failed to set data watch " + path);<a name="line.398"></a> +<span class="sourceLineNo">398</span> LOG.warn("Failed to set data watch " + path);<a name="line.398"></a> <span class="sourceLineNo">399</span> setDone(path, FAILURE);<a name="line.399"></a> <span class="sourceLineNo">400</span> }<a name="line.400"></a> <span class="sourceLineNo">401</span><a name="line.401"></a> @@ -412,7 +412,7 @@ <span class="sourceLineNo">404</span> if (task == null) {<a name="line.404"></a> <span class="sourceLineNo">405</span> if (!ZKSplitLog.isRescanNode(watcher, path)) {<a name="line.405"></a> <span class="sourceLineNo">406</span> SplitLogCounters.tot_mgr_unacquired_orphan_done.increment();<a name="line.406"></a> -<span class="sourceLineNo">407</span> LOG.debug("unacquired orphan task is done " + path);<a name="line.407"></a> +<span class="sourceLineNo">407</span> LOG.debug("Unacquired orphan task is done " + path);<a name="line.407"></a> <span class="sourceLineNo">408</span> }<a name="line.408"></a> <span class="sourceLineNo">409</span> } else {<a name="line.409"></a> <span class="sourceLineNo">410</span> synchronized (task) {<a name="line.410"></a> @@ -449,7 +449,7 @@ <span class="sourceLineNo">441</span><a name="line.441"></a> <span class="sourceLineNo">442</span> private Task findOrCreateOrphanTask(String path) {<a name="line.442"></a> <span class="sourceLineNo">443</span> return computeIfAbsent(details.getTasks(), path, Task::new, () -> {<a name="line.443"></a> -<span class="sourceLineNo">444</span> LOG.info("creating orphan task " + path);<a name="line.444"></a> +<span class="sourceLineNo">444</span> LOG.info("Creating orphan task " + path);<a name="line.444"></a> <span class="sourceLineNo">445</span> SplitLogCounters.tot_mgr_orphan_task_acquired.increment();<a name="line.445"></a> <span class="sourceLineNo">446</span> });<a name="line.446"></a> <span class="sourceLineNo">447</span> }<a name="line.447"></a> @@ -458,7 +458,7 @@ <span class="sourceLineNo">450</span> Task task = findOrCreateOrphanTask(path);<a name="line.450"></a> <span class="sourceLineNo">451</span> if (new_version != task.last_version) {<a name="line.451"></a> <span class="sourceLineNo">452</span> if (task.isUnassigned()) {<a name="line.452"></a> -<span class="sourceLineNo">453</span> LOG.info("task " + path + " acquired by " + workerName);<a name="line.453"></a> +<span class="sourceLineNo">453</span> LOG.info("Task " + path + " acquired by " + workerName);<a name="line.453"></a> <span class="sourceLineNo">454</span> }<a name="line.454"></a> <span class="sourceLineNo">455</span> task.heartbeat(EnvironmentEdgeManager.currentTime(), new_version, workerName);<a name="line.455"></a> <span class="sourceLineNo">456</span> SplitLogCounters.tot_mgr_heartbeat.increment();<a name="line.456"></a> @@ -476,11 +476,11 @@ <span class="sourceLineNo">468</span> try {<a name="line.468"></a> <span class="sourceLineNo">469</span> orphans = ZKUtil.listChildrenNoWatch(this.watcher, this.watcher.znodePaths.splitLogZNode);<a name="line.469"></a> <span class="sourceLineNo">470</span> if (orphans == null) {<a name="line.470"></a> -<span class="sourceLineNo">471</span> LOG.warn("could not get children of " + this.watcher.znodePaths.splitLogZNode);<a name="line.471"></a> +<span class="sourceLineNo">471</span> LOG.warn("Could not get children of " + this.watcher.znodePaths.splitLogZNode);<a name="line.471"></a> <span class="sourceLineNo">472</span> return;<a name="line.472"></a> <span class="sourceLineNo">473</span> }<a name="line.473"></a> <span class="sourceLineNo">474</span> } catch (KeeperException e) {<a name="line.474"></a> -<span class="sourceLineNo">475</span> LOG.warn("could not get children of " + this.watcher.znodePaths.splitLogZNode + " "<a name="line.475"></a> +<span class="sourceLineNo">475</span> LOG.warn("Could not get children of " + this.watcher.znodePaths.splitLogZNode + " "<a name="line.475"></a> <span class="sourceLineNo">476</span> + StringUtils.stringifyException(e));<a name="line.476"></a> <span class="sourceLineNo">477</span> return;<a name="line.477"></a> <span class="sourceLineNo">478</span> }<a name="line.478"></a> @@ -491,9 +491,9 @@ <span class="sourceLineNo">483</span> String nodepath = ZNodePaths.joinZNode(watcher.znodePaths.splitLogZNode, path);<a name="line.483"></a> <span class="sourceLineNo">484</span> if (ZKSplitLog.isRescanNode(watcher, nodepath)) {<a name="line.484"></a> <span class="sourceLineNo">485</span> rescan_nodes++;<a name="line.485"></a> -<span class="sourceLineNo">486</span> LOG.debug("found orphan rescan node " + path);<a name="line.486"></a> +<span class="sourceLineNo">486</span> LOG.debug("Found orphan rescan node " + path);<a name="line.486"></a> <span class="sourceLineNo">487</span> } else {<a name="line.487"></a> -<span class="sourceLineNo">488</span> LOG.info("found orphan task " + path);<a name="line.488"></a> +<span class="sourceLineNo">488</span> LOG.info("Found orphan task " + path);<a name="line.488"></a> <span class="sourceLineNo">489</span> }<a name="line.489"></a> <span class="sourceLineNo">490</span> getDataSetWatch(nodepath, zkretries);<a name="line.490"></a> <span class="sourceLineNo">491</span> }<a name="line.491"></a> @@ -519,11 +519,11 @@ <span class="sourceLineNo">511</span> SplitLogTask slt =<a name="line.511"></a> <span class="sourceLineNo">512</span> new SplitLogTask.Unassigned(this.details.getServerName());<a name="line.512"></a> <span class="sourceLineNo">513</span> if (ZKUtil.setData(this.watcher, path, slt.toByteArray(), version) == false) {<a name="line.513"></a> -<span class="sourceLineNo">514</span> LOG.debug("failed to resubmit task " + path + " version changed");<a name="line.514"></a> +<span class="sourceLineNo">514</span> LOG.debug("Failed to resubmit task " + path + " version changed");<a name="line.514"></a> <span class="sourceLineNo">515</span> return false;<a name="line.515"></a> <span class="sourceLineNo">516</span> }<a name="line.516"></a> <span class="sourceLineNo">517</span> } catch (NoNodeException e) {<a name="line.517"></a> -<span class="sourceLineNo">518</span> LOG.warn("failed to resubmit because znode doesn't exist " + path<a name="line.518"></a> +<span class="sourceLineNo">518</span> LOG.warn("Failed to resubmit because znode doesn't exist " + path<a name="line.518"></a> <span class="sourceLineNo">519</span> + " task done (or forced done by removing the znode)");<a name="line.519"></a> <span class="sourceLineNo">520</span> try {<a name="line.520"></a> <span class="sourceLineNo">521</span> getDataSetWatchSuccess(path, null, Integer.MIN_VALUE);<a name="line.521"></a> @@ -533,11 +533,11 @@ <span class="sourceLineNo">525</span> }<a name="line.525"></a> <span class="sourceLineNo">526</span> return false;<a name="line.526"></a> <span class="sourceLineNo">527</span> } catch (KeeperException.BadVersionException e) {<a name="line.527"></a> -<span class="sourceLineNo">528</span> LOG.debug("failed to resubmit task " + path + " version changed");<a name="line.528"></a> +<span class="sourceLineNo">528</span> LOG.debug("Failed to resubmit task " + path + " version changed");<a name="line.528"></a> <span class="sourceLineNo">529</span> return false;<a name="line.529"></a> <span class="sourceLineNo">530</span> } catch (KeeperException e) {<a name="line.530"></a> <span class="sourceLineNo">531</span> SplitLogCounters.tot_mgr_resubmit_failed.increment();<a name="line.531"></a> -<span class="sourceLineNo">532</span> LOG.warn("failed to resubmit " + path, e);<a name="line.532"></a> +<span class="sourceLineNo">532</span> LOG.warn("Failed to resubmit " + path, e);<a name="line.532"></a> <span class="sourceLineNo">533</span> return false;<a name="line.533"></a> <span class="sourceLineNo">534</span> }<a name="line.534"></a> <span class="sourceLineNo">535</span> return true;<a name="line.535"></a> @@ -598,11 +598,11 @@ <span class="sourceLineNo">590</span> // this manager are get-znode-data, task-finisher and delete-znode.<a name="line.590"></a> <span class="sourceLineNo">591</span> // And all code pieces correctly handle the case of suddenly<a name="line.591"></a> <span class="sourceLineNo">592</span> // disappearing task-znode.<a name="line.592"></a> -<span class="sourceLineNo">593</span> LOG.debug("found pre-existing znode " + path);<a name="line.593"></a> +<span class="sourceLineNo">593</span> LOG.debug("Found pre-existing znode " + path);<a name="line.593"></a> <span class="sourceLineNo">594</span> SplitLogCounters.tot_mgr_node_already_exists.increment();<a name="line.594"></a> <span class="sourceLineNo">595</span> } else {<a name="line.595"></a> <span class="sourceLineNo">596</span> Long retry_count = (Long) ctx;<a name="line.596"></a> -<span class="sourceLineNo">597</span> LOG.warn("create rc =" + KeeperException.Code.get(rc) + " for " + path<a name="line.597"></a> +<span class="sourceLineNo">597</span> LOG.warn("Create rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.597"></a> <span class="sourceLineNo">598</span> + " remaining retries=" + retry_count);<a name="line.598"></a> <span class="sourceLineNo">599</span> if (retry_count == 0) {<a name="line.599"></a> <span class="sourceLineNo">600</span> SplitLogCounters.tot_mgr_node_create_err.increment();<a name="line.600"></a> @@ -633,7 +633,7 @@ <span class="sourceLineNo">625</span> }<a name="line.625"></a> <span class="sourceLineNo">626</span> if (rc == KeeperException.Code.NONODE.intValue()) {<a name="line.626"></a> <span class="sourceLineNo">627</span> SplitLogCounters.tot_mgr_get_data_nonode.increment();<a name="line.627"></a> -<span class="sourceLineNo">628</span> LOG.warn("task znode " + path + " vanished or not created yet.");<a name="line.628"></a> +<span class="sourceLineNo">628</span> LOG.warn("Task znode " + path + " vanished or not created yet.");<a name="line.628"></a> <span class="sourceLineNo">629</span> // ignore since we should not end up in a case where there is in-memory task,<a name="line.629"></a> <span class="sourceLineNo">630</span> // but no znode. The only case is between the time task is created in-memory<a name="line.630"></a> <span class="sourceLineNo">631</span> // and the znode is created. See HBASE-11217.<a name="line.631"></a> @@ -642,11 +642,11 @@ <span class="sourceLineNo">634</span> Long retry_count = (Long) ctx;<a name="line.634"></a> <span class="sourceLineNo">635</span><a name="line.635"></a> <span class="sourceLineNo">636</span> if (retry_count < 0) {<a name="line.636"></a> -<span class="sourceLineNo">637</span> LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " + path<a name="line.637"></a> +<span class="sourceLineNo">637</span> LOG.warn("Getdata rc=" + KeeperException.Code.get(rc) + " " + path<a name="line.637"></a> <span class="sourceLineNo">638</span> + ". Ignoring error. No error handling. No retrying.");<a name="line.638"></a> <span class="sourceLineNo">639</span> return;<a name="line.639"></a> <span class="sourceLineNo">640</span> }<a name="line.640"></a> -<span class="sourceLineNo">641</span> LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " + path<a name="line.641"></a> +<span class="sourceLineNo">641</span> LOG.warn("Getdata rc=" + KeeperException.Code.get(rc) + " " + path<a name="line.641"></a> <span class="sourceLineNo">642</span> + " remaining retries=" + retry_count);<a name="line.642"></a> <span class="sourceLineNo">643</span> if (retry_count == 0) {<a name="line.643"></a> <span class="sourceLineNo">644</span> SplitLogCounters.tot_mgr_get_data_err.increment();<a name="line.644"></a> @@ -683,10 +683,10 @@ <span class="sourceLineNo">675</span> if (rc != KeeperException.Code.NONODE.intValue()) {<a name="line.675"></a> <span class="sourceLineNo">676</span> SplitLogCounters.tot_mgr_node_delete_err.increment();<a name="line.676"></a> <span class="sourceLineNo">677</span> Long retry_count = (Long) ctx;<a name="line.677"></a> -<span class="sourceLineNo">678</span> LOG.warn("delete rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.678"></a> +<span class="sourceLineNo">678</span> LOG.warn("Delete rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.678"></a> <span class="sourceLineNo">679</span> + " remaining retries=" + retry_count);<a name="line.679"></a> <span class="sourceLineNo">680</span> if (retry_count == 0) {<a name="line.680"></a> -<span class="sourceLineNo">681</span> LOG.warn("delete failed " + path);<a name="line.681"></a> +<span class="sourceLineNo">681</span> LOG.warn("Delete failed " + path);<a name="line.681"></a> <span class="sourceLineNo">682</span> details.getFailedDeletions().add(path);<a name="line.682"></a> <span class="sourceLineNo">683</span> deleteNodeFailure(path);<a name="line.683"></a> <span class="sourceLineNo">684</span> } else {<a name="line.684"></a> @@ -699,7 +699,7 @@ <span class="sourceLineNo">691</span> + " in earlier retry rounds. zkretries = " + ctx);<a name="line.691"></a> <span class="sourceLineNo">692</span> }<a name="line.692"></a> <span class="sourceLineNo">693</span> } else {<a name="line.693"></a> -<span class="sourceLineNo">694</span> LOG.debug("deleted " + path);<a name="line.694"></a> +<span class="sourceLineNo">694</span> LOG.debug("Deleted " + path);<a name="line.694"></a> <span class="sourceLineNo">695</span> }<a name="line.695"></a> <span class="sourceLineNo">696</span> deleteNodeSuccess(path);<a name="line.696"></a> <span class="sourceLineNo">697</span> }<a name="line.697"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6674e3ab/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.html b/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.html index 5844c3b..80259dd 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.TaskFinisher.html @@ -159,7 +159,7 @@ <span class="sourceLineNo">151</span> }<a name="line.151"></a> <span class="sourceLineNo">152</span> Task task = findOrCreateOrphanTask(path);<a name="line.152"></a> <span class="sourceLineNo">153</span> if (task.isOrphan() && (task.incarnation.get() == 0)) {<a name="line.153"></a> -<span class="sourceLineNo">154</span> LOG.info("resubmitting unassigned orphan task " + path);<a name="line.154"></a> +<span class="sourceLineNo">154</span> LOG.info("Resubmitting unassigned orphan task " + path);<a name="line.154"></a> <span class="sourceLineNo">155</span> // ignore failure to resubmit. The timeout-monitor will handle it later<a name="line.155"></a> <span class="sourceLineNo">156</span> // albeit in a more crude fashion<a name="line.156"></a> <span class="sourceLineNo">157</span> resubmitTask(path, task, FORCE);<a name="line.157"></a> @@ -210,7 +210,7 @@ <span class="sourceLineNo">202</span> SplitLogCounters.tot_mgr_resubmit_force.increment();<a name="line.202"></a> <span class="sourceLineNo">203</span> version = -1;<a name="line.203"></a> <span class="sourceLineNo">204</span> }<a name="line.204"></a> -<span class="sourceLineNo">205</span> LOG.info("resubmitting task " + path);<a name="line.205"></a> +<span class="sourceLineNo">205</span> LOG.info("Resubmitting task " + path);<a name="line.205"></a> <span class="sourceLineNo">206</span> task.incarnation.incrementAndGet();<a name="line.206"></a> <span class="sourceLineNo">207</span> boolean result = resubmit(path, version);<a name="line.207"></a> <span class="sourceLineNo">208</span> if (!result) {<a name="line.208"></a> @@ -288,7 +288,7 @@ <span class="sourceLineNo">280</span> SplitLogCounters.tot_mgr_rescan_deleted.increment();<a name="line.280"></a> <span class="sourceLineNo">281</span> }<a name="line.281"></a> <span class="sourceLineNo">282</span> SplitLogCounters.tot_mgr_missing_state_in_delete.increment();<a name="line.282"></a> -<span class="sourceLineNo">283</span> LOG.debug("deleted task without in memory state " + path);<a name="line.283"></a> +<span class="sourceLineNo">283</span> LOG.debug("Deleted task without in memory state " + path);<a name="line.283"></a> <span class="sourceLineNo">284</span> return;<a name="line.284"></a> <span class="sourceLineNo">285</span> }<a name="line.285"></a> <span class="sourceLineNo">286</span> synchronized (task) {<a name="line.286"></a> @@ -336,13 +336,13 @@ <span class="sourceLineNo">328</span> }<a name="line.328"></a> <span class="sourceLineNo">329</span><a name="line.329"></a> <span class="sourceLineNo">330</span> private void createNodeSuccess(String path) {<a name="line.330"></a> -<span class="sourceLineNo">331</span> LOG.debug("put up splitlog task at znode " + path);<a name="line.331"></a> +<span class="sourceLineNo">331</span> LOG.debug("Put up splitlog task at znode " + path);<a name="line.331"></a> <span class="sourceLineNo">332</span> getDataSetWatch(path, zkretries);<a name="line.332"></a> <span class="sourceLineNo">333</span> }<a name="line.333"></a> <span class="sourceLineNo">334</span><a name="line.334"></a> <span class="sourceLineNo">335</span> private void createNodeFailure(String path) {<a name="line.335"></a> <span class="sourceLineNo">336</span> // TODO the Manager should split the log locally instead of giving up<a name="line.336"></a> -<span class="sourceLineNo">337</span> LOG.warn("failed to create task node" + path);<a name="line.337"></a> +<span class="sourceLineNo">337</span> LOG.warn("Failed to create task node " + path);<a name="line.337"></a> <span class="sourceLineNo">338</span> setDone(path, FAILURE);<a name="line.338"></a> <span class="sourceLineNo">339</span> }<a name="line.339"></a> <span class="sourceLineNo">340</span><a name="line.340"></a> @@ -368,15 +368,15 @@ <span class="sourceLineNo">360</span> data = ZKMetadata.removeMetaData(data);<a name="line.360"></a> <span class="sourceLineNo">361</span> SplitLogTask slt = SplitLogTask.parseFrom(data);<a name="line.361"></a> <span class="sourceLineNo">362</span> if (slt.isUnassigned()) {<a name="line.362"></a> -<span class="sourceLineNo">363</span> LOG.debug("task not yet acquired " + path + " ver = " + version);<a name="line.363"></a> +<span class="sourceLineNo">363</span> LOG.debug("Task not yet acquired " + path + ", ver=" + version);<a name="line.363"></a> <span class="sourceLineNo">364</span> handleUnassignedTask(path);<a name="line.364"></a> <span class="sourceLineNo">365</span> } else if (slt.isOwned()) {<a name="line.365"></a> <span class="sourceLineNo">366</span> heartbeat(path, version, slt.getServerName());<a name="line.366"></a> <span class="sourceLineNo">367</span> } else if (slt.isResigned()) {<a name="line.367"></a> -<span class="sourceLineNo">368</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.368"></a> +<span class="sourceLineNo">368</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.368"></a> <span class="sourceLineNo">369</span> resubmitOrFail(path, FORCE);<a name="line.369"></a> <span class="sourceLineNo">370</span> } else if (slt.isDone()) {<a name="line.370"></a> -<span class="sourceLineNo">371</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.371"></a> +<span class="sourceLineNo">371</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.371"></a> <span class="sourceLineNo">372</span> if (taskFinisher != null && !ZKSplitLog.isRescanNode(watcher, path)) {<a name="line.372"></a> <span class="sourceLineNo">373</span> if (taskFinisher.finish(slt.getServerName(), ZKSplitLog.getFileName(path)) == Status.DONE) {<a name="line.373"></a> <span class="sourceLineNo">374</span> setDone(path, SUCCESS);<a name="line.374"></a> @@ -387,7 +387,7 @@ <span class="sourceLineNo">379</span> setDone(path, SUCCESS);<a name="line.379"></a> <span class="sourceLineNo">380</span> }<a name="line.380"></a> <span class="sourceLineNo">381</span> } else if (slt.isErr()) {<a name="line.381"></a> -<span class="sourceLineNo">382</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.382"></a> +<span class="sourceLineNo">382</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.382"></a> <span class="sourceLineNo">383</span> resubmitOrFail(path, CHECK);<a name="line.383"></a> <span class="sourceLineNo">384</span> } else {<a name="line.384"></a> <span class="sourceLineNo">385</span> LOG.error(HBaseMarkers.FATAL, "logic error - unexpected zk state for path = "<a name="line.385"></a> @@ -403,7 +403,7 @@ <span class="sourceLineNo">395</span> }<a name="line.395"></a> <span class="sourceLineNo">396</span><a name="line.396"></a> <span class="sourceLineNo">397</span> private void getDataSetWatchFailure(String path) {<a name="line.397"></a> -<span class="sourceLineNo">398</span> LOG.warn("failed to set data watch " + path);<a name="line.398"></a> +<span class="sourceLineNo">398</span> LOG.warn("Failed to set data watch " + path);<a name="line.398"></a> <span class="sourceLineNo">399</span> setDone(path, FAILURE);<a name="line.399"></a> <span class="sourceLineNo">400</span> }<a name="line.400"></a> <span class="sourceLineNo">401</span><a name="line.401"></a> @@ -412,7 +412,7 @@ <span class="sourceLineNo">404</span> if (task == null) {<a name="line.404"></a> <span class="sourceLineNo">405</span> if (!ZKSplitLog.isRescanNode(watcher, path)) {<a name="line.405"></a> <span class="sourceLineNo">406</span> SplitLogCounters.tot_mgr_unacquired_orphan_done.increment();<a name="line.406"></a> -<span class="sourceLineNo">407</span> LOG.debug("unacquired orphan task is done " + path);<a name="line.407"></a> +<span class="sourceLineNo">407</span> LOG.debug("Unacquired orphan task is done " + path);<a name="line.407"></a> <span class="sourceLineNo">408</span> }<a name="line.408"></a> <span class="sourceLineNo">409</span> } else {<a name="line.409"></a> <span class="sourceLineNo">410</span> synchronized (task) {<a name="line.410"></a> @@ -449,7 +449,7 @@ <span class="sourceLineNo">441</span><a name="line.441"></a> <span class="sourceLineNo">442</span> private Task findOrCreateOrphanTask(String path) {<a name="line.442"></a> <span class="sourceLineNo">443</span> return computeIfAbsent(details.getTasks(), path, Task::new, () -> {<a name="line.443"></a> -<span class="sourceLineNo">444</span> LOG.info("creating orphan task " + path);<a name="line.444"></a> +<span class="sourceLineNo">444</span> LOG.info("Creating orphan task " + path);<a name="line.444"></a> <span class="sourceLineNo">445</span> SplitLogCounters.tot_mgr_orphan_task_acquired.increment();<a name="line.445"></a> <span class="sourceLineNo">446</span> });<a name="line.446"></a> <span class="sourceLineNo">447</span> }<a name="line.447"></a> @@ -458,7 +458,7 @@ <span class="sourceLineNo">450</span> Task task = findOrCreateOrphanTask(path);<a name="line.450"></a> <span class="sourceLineNo">451</span> if (new_version != task.last_version) {<a name="line.451"></a> <span class="sourceLineNo">452</span> if (task.isUnassigned()) {<a name="line.452"></a> -<span class="sourceLineNo">453</span> LOG.info("task " + path + " acquired by " + workerName);<a name="line.453"></a> +<span class="sourceLineNo">453</span> LOG.info("Task " + path + " acquired by " + workerName);<a name="line.453"></a> <span class="sourceLineNo">454</span> }<a name="line.454"></a> <span class="sourceLineNo">455</span> task.heartbeat(EnvironmentEdgeManager.currentTime(), new_version, workerName);<a name="line.455"></a> <span class="sourceLineNo">456</span> SplitLogCounters.tot_mgr_heartbeat.increment();<a name="line.456"></a> @@ -476,11 +476,11 @@ <span class="sourceLineNo">468</span> try {<a name="line.468"></a> <span class="sourceLineNo">469</span> orphans = ZKUtil.listChildrenNoWatch(this.watcher, this.watcher.znodePaths.splitLogZNode);<a name="line.469"></a> <span class="sourceLineNo">470</span> if (orphans == null) {<a name="line.470"></a> -<span class="sourceLineNo">471</span> LOG.warn("could not get children of " + this.watcher.znodePaths.splitLogZNode);<a name="line.471"></a> +<span class="sourceLineNo">471</span> LOG.warn("Could not get children of " + this.watcher.znodePaths.splitLogZNode);<a name="line.471"></a> <span class="sourceLineNo">472</span> return;<a name="line.472"></a> <span class="sourceLineNo">473</span> }<a name="line.473"></a> <span class="sourceLineNo">474</span> } catch (KeeperException e) {<a name="line.474"></a> -<span class="sourceLineNo">475</span> LOG.warn("could not get children of " + this.watcher.znodePaths.splitLogZNode + " "<a name="line.475"></a> +<span class="sourceLineNo">475</span> LOG.warn("Could not get children of " + this.watcher.znodePaths.splitLogZNode + " "<a name="line.475"></a> <span class="sourceLineNo">476</span> + StringUtils.stringifyException(e));<a name="line.476"></a> <span class="sourceLineNo">477</span> return;<a name="line.477"></a> <span class="sourceLineNo">478</span> }<a name="line.478"></a> @@ -491,9 +491,9 @@ <span class="sourceLineNo">483</span> String nodepath = ZNodePaths.joinZNode(watcher.znodePaths.splitLogZNode, path);<a name="line.483"></a> <span class="sourceLineNo">484</span> if (ZKSplitLog.isRescanNode(watcher, nodepath)) {<a name="line.484"></a> <span class="sourceLineNo">485</span> rescan_nodes++;<a name="line.485"></a> -<span class="sourceLineNo">486</span> LOG.debug("found orphan rescan node " + path);<a name="line.486"></a> +<span class="sourceLineNo">486</span> LOG.debug("Found orphan rescan node " + path);<a name="line.486"></a> <span class="sourceLineNo">487</span> } else {<a name="line.487"></a> -<span class="sourceLineNo">488</span> LOG.info("found orphan task " + path);<a name="line.488"></a> +<span class="sourceLineNo">488</span> LOG.info("Found orphan task " + path);<a name="line.488"></a> <span class="sourceLineNo">489</span> }<a name="line.489"></a> <span class="sourceLineNo">490</span> getDataSetWatch(nodepath, zkretries);<a name="line.490"></a> <span class="sourceLineNo">491</span> }<a name="line.491"></a> @@ -519,11 +519,11 @@ <span class="sourceLineNo">511</span> SplitLogTask slt =<a name="line.511"></a> <span class="sourceLineNo">512</span> new SplitLogTask.Unassigned(this.details.getServerName());<a name="line.512"></a> <span class="sourceLineNo">513</span> if (ZKUtil.setData(this.watcher, path, slt.toByteArray(), version) == false) {<a name="line.513"></a> -<span class="sourceLineNo">514</span> LOG.debug("failed to resubmit task " + path + " version changed");<a name="line.514"></a> +<span class="sourceLineNo">514</span> LOG.debug("Failed to resubmit task " + path + " version changed");<a name="line.514"></a> <span class="sourceLineNo">515</span> return false;<a name="line.515"></a> <span class="sourceLineNo">516</span> }<a name="line.516"></a> <span class="sourceLineNo">517</span> } catch (NoNodeException e) {<a name="line.517"></a> -<span class="sourceLineNo">518</span> LOG.warn("failed to resubmit because znode doesn't exist " + path<a name="line.518"></a> +<span class="sourceLineNo">518</span> LOG.warn("Failed to resubmit because znode doesn't exist " + path<a name="line.518"></a> <span class="sourceLineNo">519</span> + " task done (or forced done by removing the znode)");<a name="line.519"></a> <span class="sourceLineNo">520</span> try {<a name="line.520"></a> <span class="sourceLineNo">521</span> getDataSetWatchSuccess(path, null, Integer.MIN_VALUE);<a name="line.521"></a> @@ -533,11 +533,11 @@ <span class="sourceLineNo">525</span> }<a name="line.525"></a> <span class="sourceLineNo">526</span> return false;<a name="line.526"></a> <span class="sourceLineNo">527</span> } catch (KeeperException.BadVersionException e) {<a name="line.527"></a> -<span class="sourceLineNo">528</span> LOG.debug("failed to resubmit task " + path + " version changed");<a name="line.528"></a> +<span class="sourceLineNo">528</span> LOG.debug("Failed to resubmit task " + path + " version changed");<a name="line.528"></a> <span class="sourceLineNo">529</span> return false;<a name="line.529"></a> <span class="sourceLineNo">530</span> } catch (KeeperException e) {<a name="line.530"></a> <span class="sourceLineNo">531</span> SplitLogCounters.tot_mgr_resubmit_failed.increment();<a name="line.531"></a> -<span class="sourceLineNo">532</span> LOG.warn("failed to resubmit " + path, e);<a name="line.532"></a> +<span class="sourceLineNo">532</span> LOG.warn("Failed to resubmit " + path, e);<a name="line.532"></a> <span class="sourceLineNo">533</span> return false;<a name="line.533"></a> <span class="sourceLineNo">534</span> }<a name="line.534"></a> <span class="sourceLineNo">535</span> return true;<a name="line.535"></a> @@ -598,11 +598,11 @@ <span class="sourceLineNo">590</span> // this manager are get-znode-data, task-finisher and delete-znode.<a name="line.590"></a> <span class="sourceLineNo">591</span> // And all code pieces correctly handle the case of suddenly<a name="line.591"></a> <span class="sourceLineNo">592</span> // disappearing task-znode.<a name="line.592"></a> -<span class="sourceLineNo">593</span> LOG.debug("found pre-existing znode " + path);<a name="line.593"></a> +<span class="sourceLineNo">593</span> LOG.debug("Found pre-existing znode " + path);<a name="line.593"></a> <span class="sourceLineNo">594</span> SplitLogCounters.tot_mgr_node_already_exists.increment();<a name="line.594"></a> <span class="sourceLineNo">595</span> } else {<a name="line.595"></a> <span class="sourceLineNo">596</span> Long retry_count = (Long) ctx;<a name="line.596"></a> -<span class="sourceLineNo">597</span> LOG.warn("create rc =" + KeeperException.Code.get(rc) + " for " + path<a name="line.597"></a> +<span class="sourceLineNo">597</span> LOG.warn("Create rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.597"></a> <span class="sourceLineNo">598</span> + " remaining retries=" + retry_count);<a name="line.598"></a> <span class="sourceLineNo">599</span> if (retry_count == 0) {<a name="line.599"></a> <span class="sourceLineNo">600</span> SplitLogCounters.tot_mgr_node_create_err.increment();<a name="line.600"></a> @@ -633,7 +633,7 @@ <span class="sourceLineNo">625</span> }<a name="line.625"></a> <span class="sourceLineNo">626</span> if (rc == KeeperException.Code.NONODE.intValue()) {<a name="line.626"></a> <span class="sourceLineNo">627</span> SplitLogCounters.tot_mgr_get_data_nonode.increment();<a name="line.627"></a> -<span class="sourceLineNo">628</span> LOG.warn("task znode " + path + " vanished or not created yet.");<a name="line.628"></a> +<span class="sourceLineNo">628</span> LOG.warn("Task znode " + path + " vanished or not created yet.");<a name="line.628"></a> <span class="sourceLineNo">629</span> // ignore since we should not end up in a case where there is in-memory task,<a name="line.629"></a> <span class="sourceLineNo">630</span> // but no znode. The only case is between the time task is created in-memory<a name="line.630"></a> <span class="sourceLineNo">631</span> // and the znode is created. See HBASE-11217.<a name="line.631"></a> @@ -642,11 +642,11 @@ <span class="sourceLineNo">634</span> Long retry_count = (Long) ctx;<a name="line.634"></a> <span class="sourceLineNo">635</span><a name="line.635"></a> <span class="sourceLineNo">636</span> if (retry_count < 0) {<a name="line.636"></a> -<span class="sourceLineNo">637</span> LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " + path<a name="line.637"></a> +<span class="sourceLineNo">637</span> LOG.warn("Getdata rc=" + KeeperException.Code.get(rc) + " " + path<a name="line.637"></a> <span class="sourceLineNo">638</span> + ". Ignoring error. No error handling. No retrying.");<a name="line.638"></a> <span class="sourceLineNo">639</span> return;<a name="line.639"></a> <span class="sourceLineNo">640</span> }<a name="line.640"></a> -<span class="sourceLineNo">641</span> LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " + path<a name="line.641"></a> +<span class="sourceLineNo">641</span> LOG.warn("Getdata rc=" + KeeperException.Code.get(rc) + " " + path<a name="line.641"></a> <span class="sourceLineNo">642</span> + " remaining retries=" + retry_count);<a name="line.642"></a> <span class="sourceLineNo">643</span> if (retry_count == 0) {<a name="line.643"></a> <span class="sourceLineNo">644</span> SplitLogCounters.tot_mgr_get_data_err.increment();<a name="line.644"></a> @@ -683,10 +683,10 @@ <span class="sourceLineNo">675</span> if (rc != KeeperException.Code.NONODE.intValue()) {<a name="line.675"></a> <span class="sourceLineNo">676</span> SplitLogCounters.tot_mgr_node_delete_err.increment();<a name="line.676"></a> <span class="sourceLineNo">677</span> Long retry_count = (Long) ctx;<a name="line.677"></a> -<span class="sourceLineNo">678</span> LOG.warn("delete rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.678"></a> +<span class="sourceLineNo">678</span> LOG.warn("Delete rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.678"></a> <span class="sourceLineNo">679</span> + " remaining retries=" + retry_count);<a name="line.679"></a> <span class="sourceLineNo">680</span> if (retry_count == 0) {<a name="line.680"></a> -<span class="sourceLineNo">681</span> LOG.warn("delete failed " + path);<a name="line.681"></a> +<span class="sourceLineNo">681</span> LOG.warn("Delete failed " + path);<a name="line.681"></a> <span class="sourceLineNo">682</span> details.getFailedDeletions().add(path);<a name="line.682"></a> <span class="sourceLineNo">683</span> deleteNodeFailure(path);<a name="line.683"></a> <span class="sourceLineNo">684</span> } else {<a name="line.684"></a> @@ -699,7 +699,7 @@ <span class="sourceLineNo">691</span> + " in earlier retry rounds. zkretries = " + ctx);<a name="line.691"></a> <span class="sourceLineNo">692</span> }<a name="line.692"></a> <span class="sourceLineNo">693</span> } else {<a name="line.693"></a> -<span class="sourceLineNo">694</span> LOG.debug("deleted " + path);<a name="line.694"></a> +<span class="sourceLineNo">694</span> LOG.debug("Deleted " + path);<a name="line.694"></a> <span class="sourceLineNo">695</span> }<a name="line.695"></a> <span class="sourceLineNo">696</span> deleteNodeSuccess(path);<a name="line.696"></a> <span class="sourceLineNo">697</span> }<a name="line.697"></a> http://git-wip-us.apache.org/repos/asf/hbase-site/blob/6674e3ab/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.html b/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.html index 5844c3b..80259dd 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.html @@ -159,7 +159,7 @@ <span class="sourceLineNo">151</span> }<a name="line.151"></a> <span class="sourceLineNo">152</span> Task task = findOrCreateOrphanTask(path);<a name="line.152"></a> <span class="sourceLineNo">153</span> if (task.isOrphan() && (task.incarnation.get() == 0)) {<a name="line.153"></a> -<span class="sourceLineNo">154</span> LOG.info("resubmitting unassigned orphan task " + path);<a name="line.154"></a> +<span class="sourceLineNo">154</span> LOG.info("Resubmitting unassigned orphan task " + path);<a name="line.154"></a> <span class="sourceLineNo">155</span> // ignore failure to resubmit. The timeout-monitor will handle it later<a name="line.155"></a> <span class="sourceLineNo">156</span> // albeit in a more crude fashion<a name="line.156"></a> <span class="sourceLineNo">157</span> resubmitTask(path, task, FORCE);<a name="line.157"></a> @@ -210,7 +210,7 @@ <span class="sourceLineNo">202</span> SplitLogCounters.tot_mgr_resubmit_force.increment();<a name="line.202"></a> <span class="sourceLineNo">203</span> version = -1;<a name="line.203"></a> <span class="sourceLineNo">204</span> }<a name="line.204"></a> -<span class="sourceLineNo">205</span> LOG.info("resubmitting task " + path);<a name="line.205"></a> +<span class="sourceLineNo">205</span> LOG.info("Resubmitting task " + path);<a name="line.205"></a> <span class="sourceLineNo">206</span> task.incarnation.incrementAndGet();<a name="line.206"></a> <span class="sourceLineNo">207</span> boolean result = resubmit(path, version);<a name="line.207"></a> <span class="sourceLineNo">208</span> if (!result) {<a name="line.208"></a> @@ -288,7 +288,7 @@ <span class="sourceLineNo">280</span> SplitLogCounters.tot_mgr_rescan_deleted.increment();<a name="line.280"></a> <span class="sourceLineNo">281</span> }<a name="line.281"></a> <span class="sourceLineNo">282</span> SplitLogCounters.tot_mgr_missing_state_in_delete.increment();<a name="line.282"></a> -<span class="sourceLineNo">283</span> LOG.debug("deleted task without in memory state " + path);<a name="line.283"></a> +<span class="sourceLineNo">283</span> LOG.debug("Deleted task without in memory state " + path);<a name="line.283"></a> <span class="sourceLineNo">284</span> return;<a name="line.284"></a> <span class="sourceLineNo">285</span> }<a name="line.285"></a> <span class="sourceLineNo">286</span> synchronized (task) {<a name="line.286"></a> @@ -336,13 +336,13 @@ <span class="sourceLineNo">328</span> }<a name="line.328"></a> <span class="sourceLineNo">329</span><a name="line.329"></a> <span class="sourceLineNo">330</span> private void createNodeSuccess(String path) {<a name="line.330"></a> -<span class="sourceLineNo">331</span> LOG.debug("put up splitlog task at znode " + path);<a name="line.331"></a> +<span class="sourceLineNo">331</span> LOG.debug("Put up splitlog task at znode " + path);<a name="line.331"></a> <span class="sourceLineNo">332</span> getDataSetWatch(path, zkretries);<a name="line.332"></a> <span class="sourceLineNo">333</span> }<a name="line.333"></a> <span class="sourceLineNo">334</span><a name="line.334"></a> <span class="sourceLineNo">335</span> private void createNodeFailure(String path) {<a name="line.335"></a> <span class="sourceLineNo">336</span> // TODO the Manager should split the log locally instead of giving up<a name="line.336"></a> -<span class="sourceLineNo">337</span> LOG.warn("failed to create task node" + path);<a name="line.337"></a> +<span class="sourceLineNo">337</span> LOG.warn("Failed to create task node " + path);<a name="line.337"></a> <span class="sourceLineNo">338</span> setDone(path, FAILURE);<a name="line.338"></a> <span class="sourceLineNo">339</span> }<a name="line.339"></a> <span class="sourceLineNo">340</span><a name="line.340"></a> @@ -368,15 +368,15 @@ <span class="sourceLineNo">360</span> data = ZKMetadata.removeMetaData(data);<a name="line.360"></a> <span class="sourceLineNo">361</span> SplitLogTask slt = SplitLogTask.parseFrom(data);<a name="line.361"></a> <span class="sourceLineNo">362</span> if (slt.isUnassigned()) {<a name="line.362"></a> -<span class="sourceLineNo">363</span> LOG.debug("task not yet acquired " + path + " ver = " + version);<a name="line.363"></a> +<span class="sourceLineNo">363</span> LOG.debug("Task not yet acquired " + path + ", ver=" + version);<a name="line.363"></a> <span class="sourceLineNo">364</span> handleUnassignedTask(path);<a name="line.364"></a> <span class="sourceLineNo">365</span> } else if (slt.isOwned()) {<a name="line.365"></a> <span class="sourceLineNo">366</span> heartbeat(path, version, slt.getServerName());<a name="line.366"></a> <span class="sourceLineNo">367</span> } else if (slt.isResigned()) {<a name="line.367"></a> -<span class="sourceLineNo">368</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.368"></a> +<span class="sourceLineNo">368</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.368"></a> <span class="sourceLineNo">369</span> resubmitOrFail(path, FORCE);<a name="line.369"></a> <span class="sourceLineNo">370</span> } else if (slt.isDone()) {<a name="line.370"></a> -<span class="sourceLineNo">371</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.371"></a> +<span class="sourceLineNo">371</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.371"></a> <span class="sourceLineNo">372</span> if (taskFinisher != null && !ZKSplitLog.isRescanNode(watcher, path)) {<a name="line.372"></a> <span class="sourceLineNo">373</span> if (taskFinisher.finish(slt.getServerName(), ZKSplitLog.getFileName(path)) == Status.DONE) {<a name="line.373"></a> <span class="sourceLineNo">374</span> setDone(path, SUCCESS);<a name="line.374"></a> @@ -387,7 +387,7 @@ <span class="sourceLineNo">379</span> setDone(path, SUCCESS);<a name="line.379"></a> <span class="sourceLineNo">380</span> }<a name="line.380"></a> <span class="sourceLineNo">381</span> } else if (slt.isErr()) {<a name="line.381"></a> -<span class="sourceLineNo">382</span> LOG.info("task " + path + " entered state: " + slt.toString());<a name="line.382"></a> +<span class="sourceLineNo">382</span> LOG.info("Task " + path + " entered state=" + slt.toString());<a name="line.382"></a> <span class="sourceLineNo">383</span> resubmitOrFail(path, CHECK);<a name="line.383"></a> <span class="sourceLineNo">384</span> } else {<a name="line.384"></a> <span class="sourceLineNo">385</span> LOG.error(HBaseMarkers.FATAL, "logic error - unexpected zk state for path = "<a name="line.385"></a> @@ -403,7 +403,7 @@ <span class="sourceLineNo">395</span> }<a name="line.395"></a> <span class="sourceLineNo">396</span><a name="line.396"></a> <span class="sourceLineNo">397</span> private void getDataSetWatchFailure(String path) {<a name="line.397"></a> -<span class="sourceLineNo">398</span> LOG.warn("failed to set data watch " + path);<a name="line.398"></a> +<span class="sourceLineNo">398</span> LOG.warn("Failed to set data watch " + path);<a name="line.398"></a> <span class="sourceLineNo">399</span> setDone(path, FAILURE);<a name="line.399"></a> <span class="sourceLineNo">400</span> }<a name="line.400"></a> <span class="sourceLineNo">401</span><a name="line.401"></a> @@ -412,7 +412,7 @@ <span class="sourceLineNo">404</span> if (task == null) {<a name="line.404"></a> <span class="sourceLineNo">405</span> if (!ZKSplitLog.isRescanNode(watcher, path)) {<a name="line.405"></a> <span class="sourceLineNo">406</span> SplitLogCounters.tot_mgr_unacquired_orphan_done.increment();<a name="line.406"></a> -<span class="sourceLineNo">407</span> LOG.debug("unacquired orphan task is done " + path);<a name="line.407"></a> +<span class="sourceLineNo">407</span> LOG.debug("Unacquired orphan task is done " + path);<a name="line.407"></a> <span class="sourceLineNo">408</span> }<a name="line.408"></a> <span class="sourceLineNo">409</span> } else {<a name="line.409"></a> <span class="sourceLineNo">410</span> synchronized (task) {<a name="line.410"></a> @@ -449,7 +449,7 @@ <span class="sourceLineNo">441</span><a name="line.441"></a> <span class="sourceLineNo">442</span> private Task findOrCreateOrphanTask(String path) {<a name="line.442"></a> <span class="sourceLineNo">443</span> return computeIfAbsent(details.getTasks(), path, Task::new, () -> {<a name="line.443"></a> -<span class="sourceLineNo">444</span> LOG.info("creating orphan task " + path);<a name="line.444"></a> +<span class="sourceLineNo">444</span> LOG.info("Creating orphan task " + path);<a name="line.444"></a> <span class="sourceLineNo">445</span> SplitLogCounters.tot_mgr_orphan_task_acquired.increment();<a name="line.445"></a> <span class="sourceLineNo">446</span> });<a name="line.446"></a> <span class="sourceLineNo">447</span> }<a name="line.447"></a> @@ -458,7 +458,7 @@ <span class="sourceLineNo">450</span> Task task = findOrCreateOrphanTask(path);<a name="line.450"></a> <span class="sourceLineNo">451</span> if (new_version != task.last_version) {<a name="line.451"></a> <span class="sourceLineNo">452</span> if (task.isUnassigned()) {<a name="line.452"></a> -<span class="sourceLineNo">453</span> LOG.info("task " + path + " acquired by " + workerName);<a name="line.453"></a> +<span class="sourceLineNo">453</span> LOG.info("Task " + path + " acquired by " + workerName);<a name="line.453"></a> <span class="sourceLineNo">454</span> }<a name="line.454"></a> <span class="sourceLineNo">455</span> task.heartbeat(EnvironmentEdgeManager.currentTime(), new_version, workerName);<a name="line.455"></a> <span class="sourceLineNo">456</span> SplitLogCounters.tot_mgr_heartbeat.increment();<a name="line.456"></a> @@ -476,11 +476,11 @@ <span class="sourceLineNo">468</span> try {<a name="line.468"></a> <span class="sourceLineNo">469</span> orphans = ZKUtil.listChildrenNoWatch(this.watcher, this.watcher.znodePaths.splitLogZNode);<a name="line.469"></a> <span class="sourceLineNo">470</span> if (orphans == null) {<a name="line.470"></a> -<span class="sourceLineNo">471</span> LOG.warn("could not get children of " + this.watcher.znodePaths.splitLogZNode);<a name="line.471"></a> +<span class="sourceLineNo">471</span> LOG.warn("Could not get children of " + this.watcher.znodePaths.splitLogZNode);<a name="line.471"></a> <span class="sourceLineNo">472</span> return;<a name="line.472"></a> <span class="sourceLineNo">473</span> }<a name="line.473"></a> <span class="sourceLineNo">474</span> } catch (KeeperException e) {<a name="line.474"></a> -<span class="sourceLineNo">475</span> LOG.warn("could not get children of " + this.watcher.znodePaths.splitLogZNode + " "<a name="line.475"></a> +<span class="sourceLineNo">475</span> LOG.warn("Could not get children of " + this.watcher.znodePaths.splitLogZNode + " "<a name="line.475"></a> <span class="sourceLineNo">476</span> + StringUtils.stringifyException(e));<a name="line.476"></a> <span class="sourceLineNo">477</span> return;<a name="line.477"></a> <span class="sourceLineNo">478</span> }<a name="line.478"></a> @@ -491,9 +491,9 @@ <span class="sourceLineNo">483</span> String nodepath = ZNodePaths.joinZNode(watcher.znodePaths.splitLogZNode, path);<a name="line.483"></a> <span class="sourceLineNo">484</span> if (ZKSplitLog.isRescanNode(watcher, nodepath)) {<a name="line.484"></a> <span class="sourceLineNo">485</span> rescan_nodes++;<a name="line.485"></a> -<span class="sourceLineNo">486</span> LOG.debug("found orphan rescan node " + path);<a name="line.486"></a> +<span class="sourceLineNo">486</span> LOG.debug("Found orphan rescan node " + path);<a name="line.486"></a> <span class="sourceLineNo">487</span> } else {<a name="line.487"></a> -<span class="sourceLineNo">488</span> LOG.info("found orphan task " + path);<a name="line.488"></a> +<span class="sourceLineNo">488</span> LOG.info("Found orphan task " + path);<a name="line.488"></a> <span class="sourceLineNo">489</span> }<a name="line.489"></a> <span class="sourceLineNo">490</span> getDataSetWatch(nodepath, zkretries);<a name="line.490"></a> <span class="sourceLineNo">491</span> }<a name="line.491"></a> @@ -519,11 +519,11 @@ <span class="sourceLineNo">511</span> SplitLogTask slt =<a name="line.511"></a> <span class="sourceLineNo">512</span> new SplitLogTask.Unassigned(this.details.getServerName());<a name="line.512"></a> <span class="sourceLineNo">513</span> if (ZKUtil.setData(this.watcher, path, slt.toByteArray(), version) == false) {<a name="line.513"></a> -<span class="sourceLineNo">514</span> LOG.debug("failed to resubmit task " + path + " version changed");<a name="line.514"></a> +<span class="sourceLineNo">514</span> LOG.debug("Failed to resubmit task " + path + " version changed");<a name="line.514"></a> <span class="sourceLineNo">515</span> return false;<a name="line.515"></a> <span class="sourceLineNo">516</span> }<a name="line.516"></a> <span class="sourceLineNo">517</span> } catch (NoNodeException e) {<a name="line.517"></a> -<span class="sourceLineNo">518</span> LOG.warn("failed to resubmit because znode doesn't exist " + path<a name="line.518"></a> +<span class="sourceLineNo">518</span> LOG.warn("Failed to resubmit because znode doesn't exist " + path<a name="line.518"></a> <span class="sourceLineNo">519</span> + " task done (or forced done by removing the znode)");<a name="line.519"></a> <span class="sourceLineNo">520</span> try {<a name="line.520"></a> <span class="sourceLineNo">521</span> getDataSetWatchSuccess(path, null, Integer.MIN_VALUE);<a name="line.521"></a> @@ -533,11 +533,11 @@ <span class="sourceLineNo">525</span> }<a name="line.525"></a> <span class="sourceLineNo">526</span> return false;<a name="line.526"></a> <span class="sourceLineNo">527</span> } catch (KeeperException.BadVersionException e) {<a name="line.527"></a> -<span class="sourceLineNo">528</span> LOG.debug("failed to resubmit task " + path + " version changed");<a name="line.528"></a> +<span class="sourceLineNo">528</span> LOG.debug("Failed to resubmit task " + path + " version changed");<a name="line.528"></a> <span class="sourceLineNo">529</span> return false;<a name="line.529"></a> <span class="sourceLineNo">530</span> } catch (KeeperException e) {<a name="line.530"></a> <span class="sourceLineNo">531</span> SplitLogCounters.tot_mgr_resubmit_failed.increment();<a name="line.531"></a> -<span class="sourceLineNo">532</span> LOG.warn("failed to resubmit " + path, e);<a name="line.532"></a> +<span class="sourceLineNo">532</span> LOG.warn("Failed to resubmit " + path, e);<a name="line.532"></a> <span class="sourceLineNo">533</span> return false;<a name="line.533"></a> <span class="sourceLineNo">534</span> }<a name="line.534"></a> <span class="sourceLineNo">535</span> return true;<a name="line.535"></a> @@ -598,11 +598,11 @@ <span class="sourceLineNo">590</span> // this manager are get-znode-data, task-finisher and delete-znode.<a name="line.590"></a> <span class="sourceLineNo">591</span> // And all code pieces correctly handle the case of suddenly<a name="line.591"></a> <span class="sourceLineNo">592</span> // disappearing task-znode.<a name="line.592"></a> -<span class="sourceLineNo">593</span> LOG.debug("found pre-existing znode " + path);<a name="line.593"></a> +<span class="sourceLineNo">593</span> LOG.debug("Found pre-existing znode " + path);<a name="line.593"></a> <span class="sourceLineNo">594</span> SplitLogCounters.tot_mgr_node_already_exists.increment();<a name="line.594"></a> <span class="sourceLineNo">595</span> } else {<a name="line.595"></a> <span class="sourceLineNo">596</span> Long retry_count = (Long) ctx;<a name="line.596"></a> -<span class="sourceLineNo">597</span> LOG.warn("create rc =" + KeeperException.Code.get(rc) + " for " + path<a name="line.597"></a> +<span class="sourceLineNo">597</span> LOG.warn("Create rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.597"></a> <span class="sourceLineNo">598</span> + " remaining retries=" + retry_count);<a name="line.598"></a> <span class="sourceLineNo">599</span> if (retry_count == 0) {<a name="line.599"></a> <span class="sourceLineNo">600</span> SplitLogCounters.tot_mgr_node_create_err.increment();<a name="line.600"></a> @@ -633,7 +633,7 @@ <span class="sourceLineNo">625</span> }<a name="line.625"></a> <span class="sourceLineNo">626</span> if (rc == KeeperException.Code.NONODE.intValue()) {<a name="line.626"></a> <span class="sourceLineNo">627</span> SplitLogCounters.tot_mgr_get_data_nonode.increment();<a name="line.627"></a> -<span class="sourceLineNo">628</span> LOG.warn("task znode " + path + " vanished or not created yet.");<a name="line.628"></a> +<span class="sourceLineNo">628</span> LOG.warn("Task znode " + path + " vanished or not created yet.");<a name="line.628"></a> <span class="sourceLineNo">629</span> // ignore since we should not end up in a case where there is in-memory task,<a name="line.629"></a> <span class="sourceLineNo">630</span> // but no znode. The only case is between the time task is created in-memory<a name="line.630"></a> <span class="sourceLineNo">631</span> // and the znode is created. See HBASE-11217.<a name="line.631"></a> @@ -642,11 +642,11 @@ <span class="sourceLineNo">634</span> Long retry_count = (Long) ctx;<a name="line.634"></a> <span class="sourceLineNo">635</span><a name="line.635"></a> <span class="sourceLineNo">636</span> if (retry_count < 0) {<a name="line.636"></a> -<span class="sourceLineNo">637</span> LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " + path<a name="line.637"></a> +<span class="sourceLineNo">637</span> LOG.warn("Getdata rc=" + KeeperException.Code.get(rc) + " " + path<a name="line.637"></a> <span class="sourceLineNo">638</span> + ". Ignoring error. No error handling. No retrying.");<a name="line.638"></a> <span class="sourceLineNo">639</span> return;<a name="line.639"></a> <span class="sourceLineNo">640</span> }<a name="line.640"></a> -<span class="sourceLineNo">641</span> LOG.warn("getdata rc = " + KeeperException.Code.get(rc) + " " + path<a name="line.641"></a> +<span class="sourceLineNo">641</span> LOG.warn("Getdata rc=" + KeeperException.Code.get(rc) + " " + path<a name="line.641"></a> <span class="sourceLineNo">642</span> + " remaining retries=" + retry_count);<a name="line.642"></a> <span class="sourceLineNo">643</span> if (retry_count == 0) {<a name="line.643"></a> <span class="sourceLineNo">644</span> SplitLogCounters.tot_mgr_get_data_err.increment();<a name="line.644"></a> @@ -683,10 +683,10 @@ <span class="sourceLineNo">675</span> if (rc != KeeperException.Code.NONODE.intValue()) {<a name="line.675"></a> <span class="sourceLineNo">676</span> SplitLogCounters.tot_mgr_node_delete_err.increment();<a name="line.676"></a> <span class="sourceLineNo">677</span> Long retry_count = (Long) ctx;<a name="line.677"></a> -<span class="sourceLineNo">678</span> LOG.warn("delete rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.678"></a> +<span class="sourceLineNo">678</span> LOG.warn("Delete rc=" + KeeperException.Code.get(rc) + " for " + path<a name="line.678"></a> <span class="sourceLineNo">679</span> + " remaining retries=" + retry_count);<a name="line.679"></a> <span class="sourceLineNo">680</span> if (retry_count == 0) {<a name="line.680"></a> -<span class="sourceLineNo">681</span> LOG.warn("delete failed " + path);<a name="line.681"></a> +<span class="sourceLineNo">681</span> LOG.warn("Delete failed " + path);<a name="line.681"></a> <span class="sourceLineNo">682</span> details.getFailedDeletions().add(path);<a name="line.682"></a> <span class="sourceLineNo">683</span> deleteNodeFailure(path);<a name="line.683"></a> <span class="sourceLineNo">684</span> } else {<a name="line.684"></a> @@ -699,7 +699,7 @@ <span class="sourceLineNo">691</span> + " in earlier retry rounds. zkretries = " + ctx);<a name="line.691"></a> <span class="sourceLineNo">692</span> }<a name="line.692"></a> <span class="sourceLineNo">693</span> } else {<a name="line.693"></a> -<span class="sourceLineNo">694</span> LOG.debug("deleted " + path);<a name="line.694"></a> +<span class="sourceLineNo">694</span> LOG.debug("Deleted " + path);<a name="line.694"></a> <span class="sourceLineNo">695</span> }<a name="line.695"></a> <span class="sourceLineNo">696</span> deleteNodeSuccess(path);<a name="line.696"></a> <span class="sourceLineNo">697</span> }<a name="line.697"></a>
