HBASE-20061 HStore synchronized member variable filesCompacting should be private
Signed-off-by: Chia-Ping Tsai <chia7...@gmail.com> Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/62b8da92 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/62b8da92 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/62b8da92 Branch: refs/heads/HBASE-19397-branch-2 Commit: 62b8da927e71af5489165b114481d0a62e58fba6 Parents: a66fa85 Author: Sean Busbey <bus...@apache.org> Authored: Fri Feb 23 14:38:03 2018 -0600 Committer: Sean Busbey <bus...@apache.org> Committed: Sat Feb 24 10:58:14 2018 -0600 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/hbase/regionserver/HStore.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/62b8da92/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java index f20972e..220881d 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java @@ -180,8 +180,9 @@ public class HStore implements Store, HeapSize, StoreConfigInformation, Propagat private ScanInfo scanInfo; + // All access must be synchronized. // TODO: ideally, this should be part of storeFileManager, as we keep passing this to it. - final List<HStoreFile> filesCompacting = Lists.newArrayList(); + private final List<HStoreFile> filesCompacting = Lists.newArrayList(); // All access must be synchronized. private final Set<ChangedReadersObserver> changedReaderObservers =
