http://git-wip-us.apache.org/repos/asf/hbase-site/blob/63aade82/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html ---------------------------------------------------------------------- diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html b/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html index 4819408..78aac51 100644 --- a/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html +++ b/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html @@ -64,651 +64,656 @@ <span class="sourceLineNo">056</span>@InterfaceAudience.Private<a name="line.56"></a> <span class="sourceLineNo">057</span>public class RSGroupAdminServer implements RSGroupAdmin {<a name="line.57"></a> <span class="sourceLineNo">058</span> private static final Logger LOG = LoggerFactory.getLogger(RSGroupAdminServer.class);<a name="line.58"></a> -<span class="sourceLineNo">059</span><a name="line.59"></a> -<span class="sourceLineNo">060</span> private MasterServices master;<a name="line.60"></a> -<span class="sourceLineNo">061</span> private final RSGroupInfoManager rsGroupInfoManager;<a name="line.61"></a> -<span class="sourceLineNo">062</span><a name="line.62"></a> -<span class="sourceLineNo">063</span> public RSGroupAdminServer(MasterServices master, RSGroupInfoManager rsGroupInfoManager)<a name="line.63"></a> -<span class="sourceLineNo">064</span> throws IOException {<a name="line.64"></a> -<span class="sourceLineNo">065</span> this.master = master;<a name="line.65"></a> -<span class="sourceLineNo">066</span> this.rsGroupInfoManager = rsGroupInfoManager;<a name="line.66"></a> -<span class="sourceLineNo">067</span> }<a name="line.67"></a> -<span class="sourceLineNo">068</span><a name="line.68"></a> -<span class="sourceLineNo">069</span> @Override<a name="line.69"></a> -<span class="sourceLineNo">070</span> public RSGroupInfo getRSGroupInfo(String groupName) throws IOException {<a name="line.70"></a> -<span class="sourceLineNo">071</span> return rsGroupInfoManager.getRSGroup(groupName);<a name="line.71"></a> -<span class="sourceLineNo">072</span> }<a name="line.72"></a> -<span class="sourceLineNo">073</span><a name="line.73"></a> -<span class="sourceLineNo">074</span> @Override<a name="line.74"></a> -<span class="sourceLineNo">075</span> public RSGroupInfo getRSGroupInfoOfTable(TableName tableName) throws IOException {<a name="line.75"></a> -<span class="sourceLineNo">076</span> // We are reading across two Maps in the below with out synchronizing across<a name="line.76"></a> -<span class="sourceLineNo">077</span> // them; should be safe most of the time.<a name="line.77"></a> -<span class="sourceLineNo">078</span> String groupName = rsGroupInfoManager.getRSGroupOfTable(tableName);<a name="line.78"></a> -<span class="sourceLineNo">079</span> return groupName == null? null: rsGroupInfoManager.getRSGroup(groupName);<a name="line.79"></a> -<span class="sourceLineNo">080</span> }<a name="line.80"></a> -<span class="sourceLineNo">081</span><a name="line.81"></a> -<span class="sourceLineNo">082</span> private void checkOnlineServersOnly(Set<Address> servers) throws ConstraintException {<a name="line.82"></a> -<span class="sourceLineNo">083</span> // This uglyness is because we only have Address, not ServerName.<a name="line.83"></a> -<span class="sourceLineNo">084</span> // Online servers are keyed by ServerName.<a name="line.84"></a> -<span class="sourceLineNo">085</span> Set<Address> onlineServers = new HashSet<>();<a name="line.85"></a> -<span class="sourceLineNo">086</span> for(ServerName server: master.getServerManager().getOnlineServers().keySet()) {<a name="line.86"></a> -<span class="sourceLineNo">087</span> onlineServers.add(server.getAddress());<a name="line.87"></a> -<span class="sourceLineNo">088</span> }<a name="line.88"></a> -<span class="sourceLineNo">089</span> for (Address address: servers) {<a name="line.89"></a> -<span class="sourceLineNo">090</span> if (!onlineServers.contains(address)) {<a name="line.90"></a> -<span class="sourceLineNo">091</span> throw new ConstraintException(<a name="line.91"></a> -<span class="sourceLineNo">092</span> "Server " + address + " is not an online server in 'default' RSGroup.");<a name="line.92"></a> -<span class="sourceLineNo">093</span> }<a name="line.93"></a> -<span class="sourceLineNo">094</span> }<a name="line.94"></a> -<span class="sourceLineNo">095</span> }<a name="line.95"></a> -<span class="sourceLineNo">096</span><a name="line.96"></a> -<span class="sourceLineNo">097</span> /**<a name="line.97"></a> -<span class="sourceLineNo">098</span> * Check passed name. Fail if nulls or if corresponding RSGroupInfo not found.<a name="line.98"></a> -<span class="sourceLineNo">099</span> * @return The RSGroupInfo named <code>name</code><a name="line.99"></a> -<span class="sourceLineNo">100</span> */<a name="line.100"></a> -<span class="sourceLineNo">101</span> private RSGroupInfo getAndCheckRSGroupInfo(String name)<a name="line.101"></a> -<span class="sourceLineNo">102</span> throws IOException {<a name="line.102"></a> -<span class="sourceLineNo">103</span> if (StringUtils.isEmpty(name)) {<a name="line.103"></a> -<span class="sourceLineNo">104</span> throw new ConstraintException("RSGroup cannot be null.");<a name="line.104"></a> -<span class="sourceLineNo">105</span> }<a name="line.105"></a> -<span class="sourceLineNo">106</span> RSGroupInfo rsGroupInfo = getRSGroupInfo(name);<a name="line.106"></a> -<span class="sourceLineNo">107</span> if (rsGroupInfo == null) {<a name="line.107"></a> -<span class="sourceLineNo">108</span> throw new ConstraintException("RSGroup does not exist: " + name);<a name="line.108"></a> -<span class="sourceLineNo">109</span> }<a name="line.109"></a> -<span class="sourceLineNo">110</span> return rsGroupInfo;<a name="line.110"></a> -<span class="sourceLineNo">111</span> }<a name="line.111"></a> -<span class="sourceLineNo">112</span><a name="line.112"></a> -<span class="sourceLineNo">113</span> /**<a name="line.113"></a> -<span class="sourceLineNo">114</span> * @return List of Regions associated with this <code>server</code>.<a name="line.114"></a> -<span class="sourceLineNo">115</span> */<a name="line.115"></a> -<span class="sourceLineNo">116</span> private List<RegionInfo> getRegions(final Address server) {<a name="line.116"></a> -<span class="sourceLineNo">117</span> LinkedList<RegionInfo> regions = new LinkedList<>();<a name="line.117"></a> -<span class="sourceLineNo">118</span> for (Map.Entry<RegionInfo, ServerName> el :<a name="line.118"></a> -<span class="sourceLineNo">119</span> master.getAssignmentManager().getRegionStates().getRegionAssignments().entrySet()) {<a name="line.119"></a> -<span class="sourceLineNo">120</span> if (el.getValue() == null) {<a name="line.120"></a> -<span class="sourceLineNo">121</span> continue;<a name="line.121"></a> -<span class="sourceLineNo">122</span> }<a name="line.122"></a> -<span class="sourceLineNo">123</span><a name="line.123"></a> -<span class="sourceLineNo">124</span> if (el.getValue().getAddress().equals(server)) {<a name="line.124"></a> -<span class="sourceLineNo">125</span> addRegion(regions, el.getKey());<a name="line.125"></a> -<span class="sourceLineNo">126</span> }<a name="line.126"></a> -<span class="sourceLineNo">127</span> }<a name="line.127"></a> -<span class="sourceLineNo">128</span> for (RegionStateNode state : master.getAssignmentManager().getRegionsInTransition()) {<a name="line.128"></a> -<span class="sourceLineNo">129</span> if (state.getRegionLocation().getAddress().equals(server)) {<a name="line.129"></a> -<span class="sourceLineNo">130</span> addRegion(regions, state.getRegionInfo());<a name="line.130"></a> -<span class="sourceLineNo">131</span> }<a name="line.131"></a> -<span class="sourceLineNo">132</span> }<a name="line.132"></a> -<span class="sourceLineNo">133</span> return regions;<a name="line.133"></a> -<span class="sourceLineNo">134</span> }<a name="line.134"></a> -<span class="sourceLineNo">135</span><a name="line.135"></a> -<span class="sourceLineNo">136</span> private void addRegion(final LinkedList<RegionInfo> regions, RegionInfo hri) {<a name="line.136"></a> -<span class="sourceLineNo">137</span> // If meta, move it last otherwise other unassigns fail because meta is not<a name="line.137"></a> -<span class="sourceLineNo">138</span> // online for them to update state in. This is dodgy. Needs to be made more<a name="line.138"></a> -<span class="sourceLineNo">139</span> // robust. See TODO below.<a name="line.139"></a> -<span class="sourceLineNo">140</span> if (hri.isMetaRegion()) {<a name="line.140"></a> -<span class="sourceLineNo">141</span> regions.addLast(hri);<a name="line.141"></a> -<span class="sourceLineNo">142</span> } else {<a name="line.142"></a> -<span class="sourceLineNo">143</span> regions.addFirst(hri);<a name="line.143"></a> -<span class="sourceLineNo">144</span> }<a name="line.144"></a> -<span class="sourceLineNo">145</span> }<a name="line.145"></a> -<span class="sourceLineNo">146</span><a name="line.146"></a> -<span class="sourceLineNo">147</span> /**<a name="line.147"></a> -<span class="sourceLineNo">148</span> * Check servers and tables.<a name="line.148"></a> -<span class="sourceLineNo">149</span> *<a name="line.149"></a> -<span class="sourceLineNo">150</span> * @param servers servers to move<a name="line.150"></a> -<span class="sourceLineNo">151</span> * @param tables tables to move<a name="line.151"></a> -<span class="sourceLineNo">152</span> * @param targetGroupName target group name<a name="line.152"></a> -<span class="sourceLineNo">153</span> * @throws IOException if nulls or if servers and tables not belong to the same group<a name="line.153"></a> -<span class="sourceLineNo">154</span> */<a name="line.154"></a> -<span class="sourceLineNo">155</span> private void checkServersAndTables(Set<Address> servers, Set<TableName> tables,<a name="line.155"></a> -<span class="sourceLineNo">156</span> String targetGroupName) throws IOException {<a name="line.156"></a> -<span class="sourceLineNo">157</span> // Presume first server's source group. Later ensure all servers are from this group.<a name="line.157"></a> -<span class="sourceLineNo">158</span> Address firstServer = servers.iterator().next();<a name="line.158"></a> -<span class="sourceLineNo">159</span> RSGroupInfo tmpSrcGrp = rsGroupInfoManager.getRSGroupOfServer(firstServer);<a name="line.159"></a> -<span class="sourceLineNo">160</span> if (tmpSrcGrp == null) {<a name="line.160"></a> -<span class="sourceLineNo">161</span> // Be careful. This exception message is tested for in TestRSGroupsBase...<a name="line.161"></a> -<span class="sourceLineNo">162</span> throw new ConstraintException("Source RSGroup for server " + firstServer<a name="line.162"></a> -<span class="sourceLineNo">163</span> + " does not exist.");<a name="line.163"></a> -<span class="sourceLineNo">164</span> }<a name="line.164"></a> -<span class="sourceLineNo">165</span> RSGroupInfo srcGrp = new RSGroupInfo(tmpSrcGrp);<a name="line.165"></a> -<span class="sourceLineNo">166</span> if (srcGrp.getName().equals(targetGroupName)) {<a name="line.166"></a> -<span class="sourceLineNo">167</span> throw new ConstraintException("Target RSGroup " + targetGroupName +<a name="line.167"></a> -<span class="sourceLineNo">168</span> " is same as source " + srcGrp.getName() + " RSGroup.");<a name="line.168"></a> -<span class="sourceLineNo">169</span> }<a name="line.169"></a> -<span class="sourceLineNo">170</span> // Only move online servers<a name="line.170"></a> -<span class="sourceLineNo">171</span> checkOnlineServersOnly(servers);<a name="line.171"></a> -<span class="sourceLineNo">172</span><a name="line.172"></a> -<span class="sourceLineNo">173</span> // Ensure all servers are of same rsgroup.<a name="line.173"></a> -<span class="sourceLineNo">174</span> for (Address server: servers) {<a name="line.174"></a> -<span class="sourceLineNo">175</span> String tmpGroup = rsGroupInfoManager.getRSGroupOfServer(server).getName();<a name="line.175"></a> -<span class="sourceLineNo">176</span> if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.176"></a> -<span class="sourceLineNo">177</span> throw new ConstraintException("Move server request should only come from one source " +<a name="line.177"></a> -<span class="sourceLineNo">178</span> "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.178"></a> -<span class="sourceLineNo">179</span> }<a name="line.179"></a> -<span class="sourceLineNo">180</span> }<a name="line.180"></a> -<span class="sourceLineNo">181</span><a name="line.181"></a> -<span class="sourceLineNo">182</span> // Ensure all tables and servers are of same rsgroup.<a name="line.182"></a> -<span class="sourceLineNo">183</span> for (TableName table : tables) {<a name="line.183"></a> -<span class="sourceLineNo">184</span> String tmpGroup = rsGroupInfoManager.getRSGroupOfTable(table);<a name="line.184"></a> -<span class="sourceLineNo">185</span> if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.185"></a> -<span class="sourceLineNo">186</span> throw new ConstraintException("Move table request should only come from one source " +<a name="line.186"></a> -<span class="sourceLineNo">187</span> "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.187"></a> -<span class="sourceLineNo">188</span> }<a name="line.188"></a> -<span class="sourceLineNo">189</span> }<a name="line.189"></a> -<span class="sourceLineNo">190</span><a name="line.190"></a> -<span class="sourceLineNo">191</span> if (srcGrp.getServers().size() <= servers.size() && srcGrp.getTables().size() > tables.size()) {<a name="line.191"></a> -<span class="sourceLineNo">192</span> throw new ConstraintException("Cannot leave a RSGroup " + srcGrp.getName() +<a name="line.192"></a> -<span class="sourceLineNo">193</span> " that contains tables without servers to host them.");<a name="line.193"></a> -<span class="sourceLineNo">194</span> }<a name="line.194"></a> -<span class="sourceLineNo">195</span> }<a name="line.195"></a> -<span class="sourceLineNo">196</span><a name="line.196"></a> -<span class="sourceLineNo">197</span> /**<a name="line.197"></a> -<span class="sourceLineNo">198</span> * Moves every region from servers which are currently located on these servers,<a name="line.198"></a> -<span class="sourceLineNo">199</span> * but should not be located there.<a name="line.199"></a> -<span class="sourceLineNo">200</span> * @param servers the servers that will move to new group<a name="line.200"></a> -<span class="sourceLineNo">201</span> * @param tables these tables will be kept on the servers, others will be moved<a name="line.201"></a> -<span class="sourceLineNo">202</span> * @param targetGroupName the target group name<a name="line.202"></a> -<span class="sourceLineNo">203</span> * @throws IOException if moving the server and tables fail<a name="line.203"></a> -<span class="sourceLineNo">204</span> */<a name="line.204"></a> -<span class="sourceLineNo">205</span> private void moveRegionsFromServers(Set<Address> servers, Set<TableName> tables,<a name="line.205"></a> -<span class="sourceLineNo">206</span> String targetGroupName) throws IOException {<a name="line.206"></a> -<span class="sourceLineNo">207</span> boolean foundRegionsToMove;<a name="line.207"></a> -<span class="sourceLineNo">208</span> RSGroupInfo targetGrp = getRSGroupInfo(targetGroupName);<a name="line.208"></a> -<span class="sourceLineNo">209</span> Set<Address> allSevers = new HashSet<>(servers);<a name="line.209"></a> -<span class="sourceLineNo">210</span> do {<a name="line.210"></a> -<span class="sourceLineNo">211</span> foundRegionsToMove = false;<a name="line.211"></a> -<span class="sourceLineNo">212</span> for (Iterator<Address> iter = allSevers.iterator(); iter.hasNext();) {<a name="line.212"></a> -<span class="sourceLineNo">213</span> Address rs = iter.next();<a name="line.213"></a> -<span class="sourceLineNo">214</span> // Get regions that are associated with this server and filter regions by tables.<a name="line.214"></a> -<span class="sourceLineNo">215</span> List<RegionInfo> regions = new ArrayList<>();<a name="line.215"></a> -<span class="sourceLineNo">216</span> for (RegionInfo region : getRegions(rs)) {<a name="line.216"></a> -<span class="sourceLineNo">217</span> if (!tables.contains(region.getTable())) {<a name="line.217"></a> -<span class="sourceLineNo">218</span> regions.add(region);<a name="line.218"></a> -<span class="sourceLineNo">219</span> }<a name="line.219"></a> -<span class="sourceLineNo">220</span> }<a name="line.220"></a> -<span class="sourceLineNo">221</span><a name="line.221"></a> -<span class="sourceLineNo">222</span> LOG.info("Moving " + regions.size() + " region(s) from " + rs +<a name="line.222"></a> -<span class="sourceLineNo">223</span> " for server move to " + targetGroupName);<a name="line.223"></a> -<span class="sourceLineNo">224</span> if (!regions.isEmpty()) {<a name="line.224"></a> -<span class="sourceLineNo">225</span> for (RegionInfo region: regions) {<a name="line.225"></a> -<span class="sourceLineNo">226</span> // Regions might get assigned from tables of target group so we need to filter<a name="line.226"></a> -<span class="sourceLineNo">227</span> if (!targetGrp.containsTable(region.getTable())) {<a name="line.227"></a> -<span class="sourceLineNo">228</span> this.master.getAssignmentManager().move(region);<a name="line.228"></a> -<span class="sourceLineNo">229</span> if (master.getAssignmentManager().getRegionStates().<a name="line.229"></a> -<span class="sourceLineNo">230</span> getRegionState(region).isFailedOpen()) {<a name="line.230"></a> -<span class="sourceLineNo">231</span> continue;<a name="line.231"></a> -<span class="sourceLineNo">232</span> }<a name="line.232"></a> -<span class="sourceLineNo">233</span> foundRegionsToMove = true;<a name="line.233"></a> -<span class="sourceLineNo">234</span> }<a name="line.234"></a> -<span class="sourceLineNo">235</span> }<a name="line.235"></a> -<span class="sourceLineNo">236</span> }<a name="line.236"></a> -<span class="sourceLineNo">237</span> if (!foundRegionsToMove) {<a name="line.237"></a> -<span class="sourceLineNo">238</span> iter.remove();<a name="line.238"></a> -<span class="sourceLineNo">239</span> }<a name="line.239"></a> -<span class="sourceLineNo">240</span> }<a name="line.240"></a> -<span class="sourceLineNo">241</span> try {<a name="line.241"></a> -<span class="sourceLineNo">242</span> rsGroupInfoManager.wait(1000);<a name="line.242"></a> -<span class="sourceLineNo">243</span> } catch (InterruptedException e) {<a name="line.243"></a> -<span class="sourceLineNo">244</span> LOG.warn("Sleep interrupted", e);<a name="line.244"></a> -<span class="sourceLineNo">245</span> Thread.currentThread().interrupt();<a name="line.245"></a> -<span class="sourceLineNo">246</span> }<a name="line.246"></a> -<span class="sourceLineNo">247</span> } while (foundRegionsToMove);<a name="line.247"></a> -<span class="sourceLineNo">248</span> }<a name="line.248"></a> -<span class="sourceLineNo">249</span><a name="line.249"></a> -<span class="sourceLineNo">250</span> /**<a name="line.250"></a> -<span class="sourceLineNo">251</span> * Moves every region of tables which should be kept on the servers,<a name="line.251"></a> -<span class="sourceLineNo">252</span> * but currently they are located on other servers.<a name="line.252"></a> -<span class="sourceLineNo">253</span> * @param servers the regions of these servers will be kept on the servers, others will be moved<a name="line.253"></a> -<span class="sourceLineNo">254</span> * @param tables the tables that will move to new group<a name="line.254"></a> -<span class="sourceLineNo">255</span> * @param targetGroupName the target group name<a name="line.255"></a> -<span class="sourceLineNo">256</span> * @throws IOException if moving the region fails<a name="line.256"></a> -<span class="sourceLineNo">257</span> */<a name="line.257"></a> -<span class="sourceLineNo">258</span> private void moveRegionsToServers(Set<Address> servers, Set<TableName> tables,<a name="line.258"></a> -<span class="sourceLineNo">259</span> String targetGroupName) throws IOException {<a name="line.259"></a> -<span class="sourceLineNo">260</span> for (TableName table: tables) {<a name="line.260"></a> -<span class="sourceLineNo">261</span> LOG.info("Moving region(s) from " + table + " for table move to " + targetGroupName);<a name="line.261"></a> -<span class="sourceLineNo">262</span> for (RegionInfo region : master.getAssignmentManager().getRegionStates()<a name="line.262"></a> -<span class="sourceLineNo">263</span> .getRegionsOfTable(table)) {<a name="line.263"></a> -<span class="sourceLineNo">264</span> ServerName sn = master.getAssignmentManager().getRegionStates()<a name="line.264"></a> -<span class="sourceLineNo">265</span> .getRegionServerOfRegion(region);<a name="line.265"></a> -<span class="sourceLineNo">266</span> if (!servers.contains(sn.getAddress())) {<a name="line.266"></a> -<span class="sourceLineNo">267</span> master.getAssignmentManager().move(region);<a name="line.267"></a> -<span class="sourceLineNo">268</span> }<a name="line.268"></a> -<span class="sourceLineNo">269</span> }<a name="line.269"></a> -<span class="sourceLineNo">270</span> }<a name="line.270"></a> -<span class="sourceLineNo">271</span> }<a name="line.271"></a> -<span class="sourceLineNo">272</span><a name="line.272"></a> -<span class="sourceLineNo">273</span> @edu.umd.cs.findbugs.annotations.SuppressWarnings(<a name="line.273"></a> -<span class="sourceLineNo">274</span> value="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE",<a name="line.274"></a> -<span class="sourceLineNo">275</span> justification="Ignoring complaint because don't know what it is complaining about")<a name="line.275"></a> -<span class="sourceLineNo">276</span> @Override<a name="line.276"></a> -<span class="sourceLineNo">277</span> public void moveServers(Set<Address> servers, String targetGroupName)<a name="line.277"></a> -<span class="sourceLineNo">278</span> throws IOException {<a name="line.278"></a> -<span class="sourceLineNo">279</span> if (servers == null) {<a name="line.279"></a> -<span class="sourceLineNo">280</span> throw new ConstraintException("The list of servers to move cannot be null.");<a name="line.280"></a> -<span class="sourceLineNo">281</span> }<a name="line.281"></a> -<span class="sourceLineNo">282</span> if (servers.isEmpty()) {<a name="line.282"></a> -<span class="sourceLineNo">283</span> // For some reason this difference between null servers and isEmpty is important distinction.<a name="line.283"></a> -<span class="sourceLineNo">284</span> // TODO. Why? Stuff breaks if I equate them.<a name="line.284"></a> -<span class="sourceLineNo">285</span> return;<a name="line.285"></a> -<span class="sourceLineNo">286</span> }<a name="line.286"></a> -<span class="sourceLineNo">287</span> RSGroupInfo targetGrp = getAndCheckRSGroupInfo(targetGroupName);<a name="line.287"></a> -<span class="sourceLineNo">288</span><a name="line.288"></a> -<span class="sourceLineNo">289</span> // Hold a lock on the manager instance while moving servers to prevent<a name="line.289"></a> -<span class="sourceLineNo">290</span> // another writer changing our state while we are working.<a name="line.290"></a> -<span class="sourceLineNo">291</span> synchronized (rsGroupInfoManager) {<a name="line.291"></a> -<span class="sourceLineNo">292</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.292"></a> -<span class="sourceLineNo">293</span> master.getMasterCoprocessorHost().preMoveServers(servers, targetGroupName);<a name="line.293"></a> -<span class="sourceLineNo">294</span> }<a name="line.294"></a> -<span class="sourceLineNo">295</span> // Presume first server's source group. Later ensure all servers are from this group.<a name="line.295"></a> -<span class="sourceLineNo">296</span> Address firstServer = servers.iterator().next();<a name="line.296"></a> -<span class="sourceLineNo">297</span> RSGroupInfo srcGrp = rsGroupInfoManager.getRSGroupOfServer(firstServer);<a name="line.297"></a> -<span class="sourceLineNo">298</span> if (srcGrp == null) {<a name="line.298"></a> -<span class="sourceLineNo">299</span> // Be careful. This exception message is tested for in TestRSGroupsBase...<a name="line.299"></a> -<span class="sourceLineNo">300</span> throw new ConstraintException("Source RSGroup for server " + firstServer<a name="line.300"></a> -<span class="sourceLineNo">301</span> + " does not exist.");<a name="line.301"></a> -<span class="sourceLineNo">302</span> }<a name="line.302"></a> -<span class="sourceLineNo">303</span> if (srcGrp.getName().equals(targetGroupName)) {<a name="line.303"></a> -<span class="sourceLineNo">304</span> throw new ConstraintException("Target RSGroup " + targetGroupName +<a name="line.304"></a> -<span class="sourceLineNo">305</span> " is same as source " + srcGrp + " RSGroup.");<a name="line.305"></a> -<span class="sourceLineNo">306</span> }<a name="line.306"></a> -<span class="sourceLineNo">307</span> // Only move online servers (when moving from 'default') or servers from other<a name="line.307"></a> -<span class="sourceLineNo">308</span> // groups. This prevents bogus servers from entering groups<a name="line.308"></a> -<span class="sourceLineNo">309</span> if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName())) {<a name="line.309"></a> -<span class="sourceLineNo">310</span> checkOnlineServersOnly(servers);<a name="line.310"></a> -<span class="sourceLineNo">311</span> }<a name="line.311"></a> -<span class="sourceLineNo">312</span> // Ensure all servers are of same rsgroup.<a name="line.312"></a> -<span class="sourceLineNo">313</span> for (Address server: servers) {<a name="line.313"></a> -<span class="sourceLineNo">314</span> String tmpGroup = rsGroupInfoManager.getRSGroupOfServer(server).getName();<a name="line.314"></a> -<span class="sourceLineNo">315</span> if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.315"></a> -<span class="sourceLineNo">316</span> throw new ConstraintException("Move server request should only come from one source " +<a name="line.316"></a> -<span class="sourceLineNo">317</span> "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.317"></a> -<span class="sourceLineNo">318</span> }<a name="line.318"></a> -<span class="sourceLineNo">319</span> }<a name="line.319"></a> -<span class="sourceLineNo">320</span> if (srcGrp.getServers().size() <= servers.size() && srcGrp.getTables().size() > 0) {<a name="line.320"></a> -<span class="sourceLineNo">321</span> throw new ConstraintException("Cannot leave a RSGroup " + srcGrp.getName() +<a name="line.321"></a> -<span class="sourceLineNo">322</span> " that contains tables without servers to host them.");<a name="line.322"></a> -<span class="sourceLineNo">323</span> }<a name="line.323"></a> -<span class="sourceLineNo">324</span><a name="line.324"></a> -<span class="sourceLineNo">325</span> // MovedServers may be < passed in 'servers'.<a name="line.325"></a> -<span class="sourceLineNo">326</span> Set<Address> movedServers = rsGroupInfoManager.moveServers(servers, srcGrp.getName(),<a name="line.326"></a> -<span class="sourceLineNo">327</span> targetGroupName);<a name="line.327"></a> -<span class="sourceLineNo">328</span> List<Address> editableMovedServers = Lists.newArrayList(movedServers);<a name="line.328"></a> -<span class="sourceLineNo">329</span> boolean foundRegionsToMove;<a name="line.329"></a> -<span class="sourceLineNo">330</span> do {<a name="line.330"></a> -<span class="sourceLineNo">331</span> foundRegionsToMove = false;<a name="line.331"></a> -<span class="sourceLineNo">332</span> for (Iterator<Address> iter = editableMovedServers.iterator(); iter.hasNext();) {<a name="line.332"></a> -<span class="sourceLineNo">333</span> Address rs = iter.next();<a name="line.333"></a> -<span class="sourceLineNo">334</span> // Get regions that are associated with this server.<a name="line.334"></a> -<span class="sourceLineNo">335</span> List<RegionInfo> regions = getRegions(rs);<a name="line.335"></a> -<span class="sourceLineNo">336</span><a name="line.336"></a> -<span class="sourceLineNo">337</span> LOG.info("Moving " + regions.size() + " region(s) from " + rs +<a name="line.337"></a> -<span class="sourceLineNo">338</span> " for server move to " + targetGroupName);<a name="line.338"></a> -<span class="sourceLineNo">339</span><a name="line.339"></a> -<span class="sourceLineNo">340</span> for (RegionInfo region: regions) {<a name="line.340"></a> -<span class="sourceLineNo">341</span> // Regions might get assigned from tables of target group so we need to filter<a name="line.341"></a> -<span class="sourceLineNo">342</span> if (targetGrp.containsTable(region.getTable())) {<a name="line.342"></a> -<span class="sourceLineNo">343</span> continue;<a name="line.343"></a> -<span class="sourceLineNo">344</span> }<a name="line.344"></a> -<span class="sourceLineNo">345</span> LOG.info("Moving region " + region.getShortNameToLog());<a name="line.345"></a> -<span class="sourceLineNo">346</span> this.master.getAssignmentManager().move(region);<a name="line.346"></a> -<span class="sourceLineNo">347</span> if (master.getAssignmentManager().getRegionStates().<a name="line.347"></a> -<span class="sourceLineNo">348</span> getRegionState(region).isFailedOpen()) {<a name="line.348"></a> -<span class="sourceLineNo">349</span> // If region is in FAILED_OPEN state, it won't recover, not without<a name="line.349"></a> -<span class="sourceLineNo">350</span> // operator intervention... in hbase-2.0.0 at least. Continue rather<a name="line.350"></a> -<span class="sourceLineNo">351</span> // than mark region as 'foundRegionsToMove'.<a name="line.351"></a> -<span class="sourceLineNo">352</span> continue;<a name="line.352"></a> -<span class="sourceLineNo">353</span> }<a name="line.353"></a> -<span class="sourceLineNo">354</span> foundRegionsToMove = true;<a name="line.354"></a> -<span class="sourceLineNo">355</span> }<a name="line.355"></a> -<span class="sourceLineNo">356</span> if (!foundRegionsToMove) {<a name="line.356"></a> -<span class="sourceLineNo">357</span> iter.remove();<a name="line.357"></a> -<span class="sourceLineNo">358</span> }<a name="line.358"></a> -<span class="sourceLineNo">359</span> }<a name="line.359"></a> -<span class="sourceLineNo">360</span> try {<a name="line.360"></a> -<span class="sourceLineNo">361</span> rsGroupInfoManager.wait(1000);<a name="line.361"></a> -<span class="sourceLineNo">362</span> } catch (InterruptedException e) {<a name="line.362"></a> -<span class="sourceLineNo">363</span> LOG.warn("Sleep interrupted", e);<a name="line.363"></a> -<span class="sourceLineNo">364</span> Thread.currentThread().interrupt();<a name="line.364"></a> -<span class="sourceLineNo">365</span> }<a name="line.365"></a> -<span class="sourceLineNo">366</span> } while (foundRegionsToMove);<a name="line.366"></a> -<span class="sourceLineNo">367</span><a name="line.367"></a> -<span class="sourceLineNo">368</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.368"></a> -<span class="sourceLineNo">369</span> master.getMasterCoprocessorHost().postMoveServers(servers, targetGroupName);<a name="line.369"></a> -<span class="sourceLineNo">370</span> }<a name="line.370"></a> -<span class="sourceLineNo">371</span> LOG.info("Move server done: " + srcGrp.getName() + "=>" + targetGroupName);<a name="line.371"></a> -<span class="sourceLineNo">372</span> }<a name="line.372"></a> -<span class="sourceLineNo">373</span> }<a name="line.373"></a> -<span class="sourceLineNo">374</span><a name="line.374"></a> -<span class="sourceLineNo">375</span> @Override<a name="line.375"></a> -<span class="sourceLineNo">376</span> public void moveTables(Set<TableName> tables, String targetGroup) throws IOException {<a name="line.376"></a> -<span class="sourceLineNo">377</span> if (tables == null) {<a name="line.377"></a> -<span class="sourceLineNo">378</span> throw new ConstraintException("The list of servers cannot be null.");<a name="line.378"></a> -<span class="sourceLineNo">379</span> }<a name="line.379"></a> -<span class="sourceLineNo">380</span> if (tables.size() < 1) {<a name="line.380"></a> -<span class="sourceLineNo">381</span> LOG.debug("moveTables() passed an empty set. Ignoring.");<a name="line.381"></a> -<span class="sourceLineNo">382</span> return;<a name="line.382"></a> -<span class="sourceLineNo">383</span> }<a name="line.383"></a> -<span class="sourceLineNo">384</span><a name="line.384"></a> -<span class="sourceLineNo">385</span> // Hold a lock on the manager instance while moving servers to prevent<a name="line.385"></a> -<span class="sourceLineNo">386</span> // another writer changing our state while we are working.<a name="line.386"></a> -<span class="sourceLineNo">387</span> synchronized (rsGroupInfoManager) {<a name="line.387"></a> -<span class="sourceLineNo">388</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.388"></a> -<span class="sourceLineNo">389</span> master.getMasterCoprocessorHost().preMoveTables(tables, targetGroup);<a name="line.389"></a> -<span class="sourceLineNo">390</span> }<a name="line.390"></a> -<span class="sourceLineNo">391</span> if(targetGroup != null) {<a name="line.391"></a> -<span class="sourceLineNo">392</span> RSGroupInfo destGroup = rsGroupInfoManager.getRSGroup(targetGroup);<a name="line.392"></a> -<span class="sourceLineNo">393</span> if(destGroup == null) {<a name="line.393"></a> -<span class="sourceLineNo">394</span> throw new ConstraintException("Target " + targetGroup + " RSGroup does not exist.");<a name="line.394"></a> -<span class="sourceLineNo">395</span> }<a name="line.395"></a> -<span class="sourceLineNo">396</span> if(destGroup.getServers().size() < 1) {<a name="line.396"></a> -<span class="sourceLineNo">397</span> throw new ConstraintException("Target RSGroup must have at least one server.");<a name="line.397"></a> -<span class="sourceLineNo">398</span> }<a name="line.398"></a> -<span class="sourceLineNo">399</span> }<a name="line.399"></a> -<span class="sourceLineNo">400</span><a name="line.400"></a> -<span class="sourceLineNo">401</span> for (TableName table : tables) {<a name="line.401"></a> -<span class="sourceLineNo">402</span> String srcGroup = rsGroupInfoManager.getRSGroupOfTable(table);<a name="line.402"></a> -<span class="sourceLineNo">403</span> if(srcGroup != null && srcGroup.equals(targetGroup)) {<a name="line.403"></a> -<span class="sourceLineNo">404</span> throw new ConstraintException(<a name="line.404"></a> -<span class="sourceLineNo">405</span> "Source RSGroup " + srcGroup + " is same as target " + targetGroup +<a name="line.405"></a> -<span class="sourceLineNo">406</span> " RSGroup for table " + table);<a name="line.406"></a> -<span class="sourceLineNo">407</span> }<a name="line.407"></a> -<span class="sourceLineNo">408</span> LOG.info("Moving table " + table.getNameAsString() + " to RSGroup " + targetGroup);<a name="line.408"></a> -<span class="sourceLineNo">409</span> }<a name="line.409"></a> -<span class="sourceLineNo">410</span> rsGroupInfoManager.moveTables(tables, targetGroup);<a name="line.410"></a> -<span class="sourceLineNo">411</span><a name="line.411"></a> -<span class="sourceLineNo">412</span> // targetGroup is null when a table is being deleted. In this case no further<a name="line.412"></a> -<span class="sourceLineNo">413</span> // action is required.<a name="line.413"></a> -<span class="sourceLineNo">414</span> if (targetGroup != null) {<a name="line.414"></a> -<span class="sourceLineNo">415</span> for (TableName table: tables) {<a name="line.415"></a> -<span class="sourceLineNo">416</span> if (master.getAssignmentManager().isTableDisabled(table)) {<a name="line.416"></a> -<span class="sourceLineNo">417</span> LOG.debug("Skipping move regions because the table" + table + " is disabled.");<a name="line.417"></a> -<span class="sourceLineNo">418</span> continue;<a name="line.418"></a> -<span class="sourceLineNo">419</span> }<a name="line.419"></a> -<span class="sourceLineNo">420</span> for (RegionInfo region :<a name="line.420"></a> -<span class="sourceLineNo">421</span> master.getAssignmentManager().getRegionStates().getRegionsOfTable(table)) {<a name="line.421"></a> -<span class="sourceLineNo">422</span> LOG.info("Moving region " + region.getShortNameToLog() +<a name="line.422"></a> -<span class="sourceLineNo">423</span> " to RSGroup " + targetGroup);<a name="line.423"></a> -<span class="sourceLineNo">424</span> master.getAssignmentManager().move(region);<a name="line.424"></a> -<span class="sourceLineNo">425</span> }<a name="line.425"></a> -<span class="sourceLineNo">426</span> }<a name="line.426"></a> -<span class="sourceLineNo">427</span> }<a name="line.427"></a> -<span class="sourceLineNo">428</span><a name="line.428"></a> -<span class="sourceLineNo">429</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.429"></a> -<span class="sourceLineNo">430</span> master.getMasterCoprocessorHost().postMoveTables(tables, targetGroup);<a name="line.430"></a> -<span class="sourceLineNo">431</span> }<a name="line.431"></a> -<span class="sourceLineNo">432</span> }<a name="line.432"></a> -<span class="sourceLineNo">433</span> }<a name="line.433"></a> -<span class="sourceLineNo">434</span><a name="line.434"></a> -<span class="sourceLineNo">435</span> @Override<a name="line.435"></a> -<span class="sourceLineNo">436</span> public void addRSGroup(String name) throws IOException {<a name="line.436"></a> -<span class="sourceLineNo">437</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.437"></a> -<span class="sourceLineNo">438</span> master.getMasterCoprocessorHost().preAddRSGroup(name);<a name="line.438"></a> -<span class="sourceLineNo">439</span> }<a name="line.439"></a> -<span class="sourceLineNo">440</span> rsGroupInfoManager.addRSGroup(new RSGroupInfo(name));<a name="line.440"></a> -<span class="sourceLineNo">441</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.441"></a> -<span class="sourceLineNo">442</span> master.getMasterCoprocessorHost().postAddRSGroup(name);<a name="line.442"></a> -<span class="sourceLineNo">443</span> }<a name="line.443"></a> -<span class="sourceLineNo">444</span> }<a name="line.444"></a> -<span class="sourceLineNo">445</span><a name="line.445"></a> -<span class="sourceLineNo">446</span> @Override<a name="line.446"></a> -<span class="sourceLineNo">447</span> public void removeRSGroup(String name) throws IOException {<a name="line.447"></a> -<span class="sourceLineNo">448</span> // Hold a lock on the manager instance while moving servers to prevent<a name="line.448"></a> -<span class="sourceLineNo">449</span> // another writer changing our state while we are working.<a name="line.449"></a> -<span class="sourceLineNo">450</span> synchronized (rsGroupInfoManager) {<a name="line.450"></a> -<span class="sourceLineNo">451</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.451"></a> -<span class="sourceLineNo">452</span> master.getMasterCoprocessorHost().preRemoveRSGroup(name);<a name="line.452"></a> -<span class="sourceLineNo">453</span> }<a name="line.453"></a> -<span class="sourceLineNo">454</span> RSGroupInfo rsGroupInfo = rsGroupInfoManager.getRSGroup(name);<a name="line.454"></a> -<span class="sourceLineNo">455</span> if (rsGroupInfo == null) {<a name="line.455"></a> -<span class="sourceLineNo">456</span> throw new ConstraintException("RSGroup " + name + " does not exist");<a name="line.456"></a> -<span class="sourceLineNo">457</span> }<a name="line.457"></a> -<span class="sourceLineNo">458</span> int tableCount = rsGroupInfo.getTables().size();<a name="line.458"></a> -<span class="sourceLineNo">459</span> if (tableCount > 0) {<a name="line.459"></a> -<span class="sourceLineNo">460</span> throw new ConstraintException("RSGroup " + name + " has " + tableCount +<a name="line.460"></a> -<span class="sourceLineNo">461</span> " tables; you must remove these tables from the rsgroup before " +<a name="line.461"></a> -<span class="sourceLineNo">462</span> "the rsgroup can be removed.");<a name="line.462"></a> -<span class="sourceLineNo">463</span> }<a name="line.463"></a> -<span class="sourceLineNo">464</span> int serverCount = rsGroupInfo.getServers().size();<a name="line.464"></a> -<span class="sourceLineNo">465</span> if (serverCount > 0) {<a name="line.465"></a> -<span class="sourceLineNo">466</span> throw new ConstraintException("RSGroup " + name + " has " + serverCount +<a name="line.466"></a> -<span class="sourceLineNo">467</span> " servers; you must remove these servers from the RSGroup before" +<a name="line.467"></a> -<span class="sourceLineNo">468</span> "the RSGroup can be removed.");<a name="line.468"></a> -<span class="sourceLineNo">469</span> }<a name="line.469"></a> -<span class="sourceLineNo">470</span> for (NamespaceDescriptor ns: master.getClusterSchema().getNamespaces()) {<a name="line.470"></a> -<span class="sourceLineNo">471</span> String nsGroup = ns.getConfigurationValue(rsGroupInfo.NAMESPACE_DESC_PROP_GROUP);<a name="line.471"></a> -<span class="sourceLineNo">472</span> if (nsGroup != null && nsGroup.equals(name)) {<a name="line.472"></a> -<span class="sourceLineNo">473</span> throw new ConstraintException("RSGroup " + name + " is referenced by namespace: " +<a name="line.473"></a> -<span class="sourceLineNo">474</span> ns.getName());<a name="line.474"></a> -<span class="sourceLineNo">475</span> }<a name="line.475"></a> -<span class="sourceLineNo">476</span> }<a name="line.476"></a> -<span class="sourceLineNo">477</span> rsGroupInfoManager.removeRSGroup(name);<a name="line.477"></a> -<span class="sourceLineNo">478</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.478"></a> -<span class="sourceLineNo">479</span> master.getMasterCoprocessorHost().postRemoveRSGroup(name);<a name="line.479"></a> -<span class="sourceLineNo">480</span> }<a name="line.480"></a> -<span class="sourceLineNo">481</span> }<a name="line.481"></a> -<span class="sourceLineNo">482</span> }<a name="line.482"></a> -<span class="sourceLineNo">483</span><a name="line.483"></a> -<span class="sourceLineNo">484</span> @Override<a name="line.484"></a> -<span class="sourceLineNo">485</span> public boolean balanceRSGroup(String groupName) throws IOException {<a name="line.485"></a> -<span class="sourceLineNo">486</span> ServerManager serverManager = master.getServerManager();<a name="line.486"></a> -<span class="sourceLineNo">487</span> AssignmentManager assignmentManager = master.getAssignmentManager();<a name="line.487"></a> -<span class="sourceLineNo">488</span> LoadBalancer balancer = master.getLoadBalancer();<a name="line.488"></a> -<span class="sourceLineNo">489</span><a name="line.489"></a> -<span class="sourceLineNo">490</span> synchronized (balancer) {<a name="line.490"></a> -<span class="sourceLineNo">491</span> // If balance not true, don't run balancer.<a name="line.491"></a> -<span class="sourceLineNo">492</span> if (!((HMaster) master).isBalancerOn()) {<a name="line.492"></a> -<span class="sourceLineNo">493</span> return false;<a name="line.493"></a> -<span class="sourceLineNo">494</span> }<a name="line.494"></a> -<span class="sourceLineNo">495</span><a name="line.495"></a> -<span class="sourceLineNo">496</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.496"></a> -<span class="sourceLineNo">497</span> master.getMasterCoprocessorHost().preBalanceRSGroup(groupName);<a name="line.497"></a> -<span class="sourceLineNo">498</span> }<a name="line.498"></a> -<span class="sourceLineNo">499</span> if (getRSGroupInfo(groupName) == null) {<a name="line.499"></a> -<span class="sourceLineNo">500</span> throw new ConstraintException("RSGroup does not exist: "+groupName);<a name="line.500"></a> -<span class="sourceLineNo">501</span> }<a name="line.501"></a> -<span class="sourceLineNo">502</span> // Only allow one balance run at at time.<a name="line.502"></a> -<span class="sourceLineNo">503</span> Map<String, RegionState> groupRIT = rsGroupGetRegionsInTransition(groupName);<a name="line.503"></a> -<span class="sourceLineNo">504</span> if (groupRIT.size() > 0) {<a name="line.504"></a> -<span class="sourceLineNo">505</span> LOG.debug("Not running balancer because " + groupRIT.size() + " region(s) in transition: " +<a name="line.505"></a> -<span class="sourceLineNo">506</span> StringUtils.abbreviate(<a name="line.506"></a> -<span class="sourceLineNo">507</span> master.getAssignmentManager().getRegionStates().getRegionsInTransition().toString(),<a name="line.507"></a> -<span class="sourceLineNo">508</span> 256));<a name="line.508"></a> -<span class="sourceLineNo">509</span> return false;<a name="line.509"></a> -<span class="sourceLineNo">510</span> }<a name="line.510"></a> -<span class="sourceLineNo">511</span> if (serverManager.areDeadServersInProgress()) {<a name="line.511"></a> -<span class="sourceLineNo">512</span> LOG.debug("Not running balancer because processing dead regionserver(s): " +<a name="line.512"></a> -<span class="sourceLineNo">513</span> serverManager.getDeadServers());<a name="line.513"></a> +<span class="sourceLineNo">059</span> public static final String KEEP_ONE_SERVER_IN_DEFAULT_ERROR_MESSAGE = "should keep at least " +<a name="line.59"></a> +<span class="sourceLineNo">060</span> "one server in 'default' RSGroup.";<a name="line.60"></a> +<span class="sourceLineNo">061</span><a name="line.61"></a> +<span class="sourceLineNo">062</span> private MasterServices master;<a name="line.62"></a> +<span class="sourceLineNo">063</span> private final RSGroupInfoManager rsGroupInfoManager;<a name="line.63"></a> +<span class="sourceLineNo">064</span><a name="line.64"></a> +<span class="sourceLineNo">065</span> public RSGroupAdminServer(MasterServices master, RSGroupInfoManager rsGroupInfoManager)<a name="line.65"></a> +<span class="sourceLineNo">066</span> throws IOException {<a name="line.66"></a> +<span class="sourceLineNo">067</span> this.master = master;<a name="line.67"></a> +<span class="sourceLineNo">068</span> this.rsGroupInfoManager = rsGroupInfoManager;<a name="line.68"></a> +<span class="sourceLineNo">069</span> }<a name="line.69"></a> +<span class="sourceLineNo">070</span><a name="line.70"></a> +<span class="sourceLineNo">071</span> @Override<a name="line.71"></a> +<span class="sourceLineNo">072</span> public RSGroupInfo getRSGroupInfo(String groupName) throws IOException {<a name="line.72"></a> +<span class="sourceLineNo">073</span> return rsGroupInfoManager.getRSGroup(groupName);<a name="line.73"></a> +<span class="sourceLineNo">074</span> }<a name="line.74"></a> +<span class="sourceLineNo">075</span><a name="line.75"></a> +<span class="sourceLineNo">076</span> @Override<a name="line.76"></a> +<span class="sourceLineNo">077</span> public RSGroupInfo getRSGroupInfoOfTable(TableName tableName) throws IOException {<a name="line.77"></a> +<span class="sourceLineNo">078</span> // We are reading across two Maps in the below with out synchronizing across<a name="line.78"></a> +<span class="sourceLineNo">079</span> // them; should be safe most of the time.<a name="line.79"></a> +<span class="sourceLineNo">080</span> String groupName = rsGroupInfoManager.getRSGroupOfTable(tableName);<a name="line.80"></a> +<span class="sourceLineNo">081</span> return groupName == null? null: rsGroupInfoManager.getRSGroup(groupName);<a name="line.81"></a> +<span class="sourceLineNo">082</span> }<a name="line.82"></a> +<span class="sourceLineNo">083</span><a name="line.83"></a> +<span class="sourceLineNo">084</span> private void checkOnlineServersOnly(Set<Address> servers) throws ConstraintException {<a name="line.84"></a> +<span class="sourceLineNo">085</span> // This uglyness is because we only have Address, not ServerName.<a name="line.85"></a> +<span class="sourceLineNo">086</span> // Online servers are keyed by ServerName.<a name="line.86"></a> +<span class="sourceLineNo">087</span> Set<Address> onlineServers = new HashSet<>();<a name="line.87"></a> +<span class="sourceLineNo">088</span> for(ServerName server: master.getServerManager().getOnlineServers().keySet()) {<a name="line.88"></a> +<span class="sourceLineNo">089</span> onlineServers.add(server.getAddress());<a name="line.89"></a> +<span class="sourceLineNo">090</span> }<a name="line.90"></a> +<span class="sourceLineNo">091</span> for (Address address: servers) {<a name="line.91"></a> +<span class="sourceLineNo">092</span> if (!onlineServers.contains(address)) {<a name="line.92"></a> +<span class="sourceLineNo">093</span> throw new ConstraintException(<a name="line.93"></a> +<span class="sourceLineNo">094</span> "Server " + address + " is not an online server in 'default' RSGroup.");<a name="line.94"></a> +<span class="sourceLineNo">095</span> }<a name="line.95"></a> +<span class="sourceLineNo">096</span> }<a name="line.96"></a> +<span class="sourceLineNo">097</span> }<a name="line.97"></a> +<span class="sourceLineNo">098</span><a name="line.98"></a> +<span class="sourceLineNo">099</span> /**<a name="line.99"></a> +<span class="sourceLineNo">100</span> * Check passed name. Fail if nulls or if corresponding RSGroupInfo not found.<a name="line.100"></a> +<span class="sourceLineNo">101</span> * @return The RSGroupInfo named <code>name</code><a name="line.101"></a> +<span class="sourceLineNo">102</span> */<a name="line.102"></a> +<span class="sourceLineNo">103</span> private RSGroupInfo getAndCheckRSGroupInfo(String name)<a name="line.103"></a> +<span class="sourceLineNo">104</span> throws IOException {<a name="line.104"></a> +<span class="sourceLineNo">105</span> if (StringUtils.isEmpty(name)) {<a name="line.105"></a> +<span class="sourceLineNo">106</span> throw new ConstraintException("RSGroup cannot be null.");<a name="line.106"></a> +<span class="sourceLineNo">107</span> }<a name="line.107"></a> +<span class="sourceLineNo">108</span> RSGroupInfo rsGroupInfo = getRSGroupInfo(name);<a name="line.108"></a> +<span class="sourceLineNo">109</span> if (rsGroupInfo == null) {<a name="line.109"></a> +<span class="sourceLineNo">110</span> throw new ConstraintException("RSGroup does not exist: " + name);<a name="line.110"></a> +<span class="sourceLineNo">111</span> }<a name="line.111"></a> +<span class="sourceLineNo">112</span> return rsGroupInfo;<a name="line.112"></a> +<span class="sourceLineNo">113</span> }<a name="line.113"></a> +<span class="sourceLineNo">114</span><a name="line.114"></a> +<span class="sourceLineNo">115</span> /**<a name="line.115"></a> +<span class="sourceLineNo">116</span> * @return List of Regions associated with this <code>server</code>.<a name="line.116"></a> +<span class="sourceLineNo">117</span> */<a name="line.117"></a> +<span class="sourceLineNo">118</span> private List<RegionInfo> getRegions(final Address server) {<a name="line.118"></a> +<span class="sourceLineNo">119</span> LinkedList<RegionInfo> regions = new LinkedList<>();<a name="line.119"></a> +<span class="sourceLineNo">120</span> for (Map.Entry<RegionInfo, ServerName> el :<a name="line.120"></a> +<span class="sourceLineNo">121</span> master.getAssignmentManager().getRegionStates().getRegionAssignments().entrySet()) {<a name="line.121"></a> +<span class="sourceLineNo">122</span> if (el.getValue() == null) {<a name="line.122"></a> +<span class="sourceLineNo">123</span> continue;<a name="line.123"></a> +<span class="sourceLineNo">124</span> }<a name="line.124"></a> +<span class="sourceLineNo">125</span><a name="line.125"></a> +<span class="sourceLineNo">126</span> if (el.getValue().getAddress().equals(server)) {<a name="line.126"></a> +<span class="sourceLineNo">127</span> addRegion(regions, el.getKey());<a name="line.127"></a> +<span class="sourceLineNo">128</span> }<a name="line.128"></a> +<span class="sourceLineNo">129</span> }<a name="line.129"></a> +<span class="sourceLineNo">130</span> for (RegionStateNode state : master.getAssignmentManager().getRegionsInTransition()) {<a name="line.130"></a> +<span class="sourceLineNo">131</span> if (state.getRegionLocation().getAddress().equals(server)) {<a name="line.131"></a> +<span class="sourceLineNo">132</span> addRegion(regions, state.getRegionInfo());<a name="line.132"></a> +<span class="sourceLineNo">133</span> }<a name="line.133"></a> +<span class="sourceLineNo">134</span> }<a name="line.134"></a> +<span class="sourceLineNo">135</span> return regions;<a name="line.135"></a> +<span class="sourceLineNo">136</span> }<a name="line.136"></a> +<span class="sourceLineNo">137</span><a name="line.137"></a> +<span class="sourceLineNo">138</span> private void addRegion(final LinkedList<RegionInfo> regions, RegionInfo hri) {<a name="line.138"></a> +<span class="sourceLineNo">139</span> // If meta, move it last otherwise other unassigns fail because meta is not<a name="line.139"></a> +<span class="sourceLineNo">140</span> // online for them to update state in. This is dodgy. Needs to be made more<a name="line.140"></a> +<span class="sourceLineNo">141</span> // robust. See TODO below.<a name="line.141"></a> +<span class="sourceLineNo">142</span> if (hri.isMetaRegion()) {<a name="line.142"></a> +<span class="sourceLineNo">143</span> regions.addLast(hri);<a name="line.143"></a> +<span class="sourceLineNo">144</span> } else {<a name="line.144"></a> +<span class="sourceLineNo">145</span> regions.addFirst(hri);<a name="line.145"></a> +<span class="sourceLineNo">146</span> }<a name="line.146"></a> +<span class="sourceLineNo">147</span> }<a name="line.147"></a> +<span class="sourceLineNo">148</span><a name="line.148"></a> +<span class="sourceLineNo">149</span> /**<a name="line.149"></a> +<span class="sourceLineNo">150</span> * Check servers and tables.<a name="line.150"></a> +<span class="sourceLineNo">151</span> *<a name="line.151"></a> +<span class="sourceLineNo">152</span> * @param servers servers to move<a name="line.152"></a> +<span class="sourceLineNo">153</span> * @param tables tables to move<a name="line.153"></a> +<span class="sourceLineNo">154</span> * @param targetGroupName target group name<a name="line.154"></a> +<span class="sourceLineNo">155</span> * @throws IOException if nulls or if servers and tables not belong to the same group<a name="line.155"></a> +<span class="sourceLineNo">156</span> */<a name="line.156"></a> +<span class="sourceLineNo">157</span> private void checkServersAndTables(Set<Address> servers, Set<TableName> tables,<a name="line.157"></a> +<span class="sourceLineNo">158</span> String targetGroupName) throws IOException {<a name="line.158"></a> +<span class="sourceLineNo">159</span> // Presume first server's source group. Later ensure all servers are from this group.<a name="line.159"></a> +<span class="sourceLineNo">160</span> Address firstServer = servers.iterator().next();<a name="line.160"></a> +<span class="sourceLineNo">161</span> RSGroupInfo tmpSrcGrp = rsGroupInfoManager.getRSGroupOfServer(firstServer);<a name="line.161"></a> +<span class="sourceLineNo">162</span> if (tmpSrcGrp == null) {<a name="line.162"></a> +<span class="sourceLineNo">163</span> // Be careful. This exception message is tested for in TestRSGroupsBase...<a name="line.163"></a> +<span class="sourceLineNo">164</span> throw new ConstraintException("Source RSGroup for server " + firstServer<a name="line.164"></a> +<span class="sourceLineNo">165</span> + " does not exist.");<a name="line.165"></a> +<span class="sourceLineNo">166</span> }<a name="line.166"></a> +<span class="sourceLineNo">167</span> RSGroupInfo srcGrp = new RSGroupInfo(tmpSrcGrp);<a name="line.167"></a> +<span class="sourceLineNo">168</span> if (srcGrp.getName().equals(targetGroupName)) {<a name="line.168"></a> +<span class="sourceLineNo">169</span> throw new ConstraintException("Target RSGroup " + targetGroupName +<a name="line.169"></a> +<span class="sourceLineNo">170</span> " is same as source " + srcGrp.getName() + " RSGroup.");<a name="line.170"></a> +<span class="sourceLineNo">171</span> }<a name="line.171"></a> +<span class="sourceLineNo">172</span> // Only move online servers<a name="line.172"></a> +<span class="sourceLineNo">173</span> checkOnlineServersOnly(servers);<a name="line.173"></a> +<span class="sourceLineNo">174</span><a name="line.174"></a> +<span class="sourceLineNo">175</span> // Ensure all servers are of same rsgroup.<a name="line.175"></a> +<span class="sourceLineNo">176</span> for (Address server: servers) {<a name="line.176"></a> +<span class="sourceLineNo">177</span> String tmpGroup = rsGroupInfoManager.getRSGroupOfServer(server).getName();<a name="line.177"></a> +<span class="sourceLineNo">178</span> if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.178"></a> +<span class="sourceLineNo">179</span> throw new ConstraintException("Move server request should only come from one source " +<a name="line.179"></a> +<span class="sourceLineNo">180</span> "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.180"></a> +<span class="sourceLineNo">181</span> }<a name="line.181"></a> +<span class="sourceLineNo">182</span> }<a name="line.182"></a> +<span class="sourceLineNo">183</span><a name="line.183"></a> +<span class="sourceLineNo">184</span> // Ensure all tables and servers are of same rsgroup.<a name="line.184"></a> +<span class="sourceLineNo">185</span> for (TableName table : tables) {<a name="line.185"></a> +<span class="sourceLineNo">186</span> String tmpGroup = rsGroupInfoManager.getRSGroupOfTable(table);<a name="line.186"></a> +<span class="sourceLineNo">187</span> if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.187"></a> +<span class="sourceLineNo">188</span> throw new ConstraintException("Move table request should only come from one source " +<a name="line.188"></a> +<span class="sourceLineNo">189</span> "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.189"></a> +<span class="sourceLineNo">190</span> }<a name="line.190"></a> +<span class="sourceLineNo">191</span> }<a name="line.191"></a> +<span class="sourceLineNo">192</span><a name="line.192"></a> +<span class="sourceLineNo">193</span> if (srcGrp.getServers().size() <= servers.size() && srcGrp.getTables().size() > tables.size()) {<a name="line.193"></a> +<span class="sourceLineNo">194</span> throw new ConstraintException("Cannot leave a RSGroup " + srcGrp.getName() +<a name="line.194"></a> +<span class="sourceLineNo">195</span> " that contains tables without servers to host them.");<a name="line.195"></a> +<span class="sourceLineNo">196</span> }<a name="line.196"></a> +<span class="sourceLineNo">197</span> }<a name="line.197"></a> +<span class="sourceLineNo">198</span><a name="line.198"></a> +<span class="sourceLineNo">199</span> /**<a name="line.199"></a> +<span class="sourceLineNo">200</span> * Moves every region from servers which are currently located on these servers,<a name="line.200"></a> +<span class="sourceLineNo">201</span> * but should not be located there.<a name="line.201"></a> +<span class="sourceLineNo">202</span> * @param servers the servers that will move to new group<a name="line.202"></a> +<span class="sourceLineNo">203</span> * @param tables these tables will be kept on the servers, others will be moved<a name="line.203"></a> +<span class="sourceLineNo">204</span> * @param targetGroupName the target group name<a name="line.204"></a> +<span class="sourceLineNo">205</span> * @throws IOException if moving the server and tables fail<a name="line.205"></a> +<span class="sourceLineNo">206</span> */<a name="line.206"></a> +<span class="sourceLineNo">207</span> private void moveRegionsFromServers(Set<Address> servers, Set<TableName> tables,<a name="line.207"></a> +<span class="sourceLineNo">208</span> String targetGroupName) throws IOException {<a name="line.208"></a> +<span class="sourceLineNo">209</span> boolean foundRegionsToMove;<a name="line.209"></a> +<span class="sourceLineNo">210</span> RSGroupInfo targetGrp = getRSGroupInfo(targetGroupName);<a name="line.210"></a> +<span class="sourceLineNo">211</span> Set<Address> allSevers = new HashSet<>(servers);<a name="line.211"></a> +<span class="sourceLineNo">212</span> do {<a name="line.212"></a> +<span class="sourceLineNo">213</span> foundRegionsToMove = false;<a name="line.213"></a> +<span class="sourceLineNo">214</span> for (Iterator<Address> iter = allSevers.iterator(); iter.hasNext();) {<a name="line.214"></a> +<span class="sourceLineNo">215</span> Address rs = iter.next();<a name="line.215"></a> +<span class="sourceLineNo">216</span> // Get regions that are associated with this server and filter regions by tables.<a name="line.216"></a> +<span class="sourceLineNo">217</span> List<RegionInfo> regions = new ArrayList<>();<a name="line.217"></a> +<span class="sourceLineNo">218</span> for (RegionInfo region : getRegions(rs)) {<a name="line.218"></a> +<span class="sourceLineNo">219</span> if (!tables.contains(region.getTable())) {<a name="line.219"></a> +<span class="sourceLineNo">220</span> regions.add(region);<a name="line.220"></a> +<span class="sourceLineNo">221</span> }<a name="line.221"></a> +<span class="sourceLineNo">222</span> }<a name="line.222"></a> +<span class="sourceLineNo">223</span><a name="line.223"></a> +<span class="sourceLineNo">224</span> LOG.info("Moving " + regions.size() + " region(s) from " + rs +<a name="line.224"></a> +<span class="sourceLineNo">225</span> " for server move to " + targetGroupName);<a name="line.225"></a> +<span class="sourceLineNo">226</span> if (!regions.isEmpty()) {<a name="line.226"></a> +<span class="sourceLineNo">227</span> for (RegionInfo region: regions) {<a name="line.227"></a> +<span class="sourceLineNo">228</span> // Regions might get assigned from tables of target group so we need to filter<a name="line.228"></a> +<span class="sourceLineNo">229</span> if (!targetGrp.containsTable(region.getTable())) {<a name="line.229"></a> +<span class="sourceLineNo">230</span> this.master.getAssignmentManager().move(region);<a name="line.230"></a> +<span class="sourceLineNo">231</span> if (master.getAssignmentManager().getRegionStates().<a name="line.231"></a> +<span class="sourceLineNo">232</span> getRegionState(region).isFailedOpen()) {<a name="line.232"></a> +<span class="sourceLineNo">233</span> continue;<a name="line.233"></a> +<span class="sourceLineNo">234</span> }<a name="line.234"></a> +<span class="sourceLineNo">235</span> foundRegionsToMove = true;<a name="line.235"></a> +<span class="sourceLineNo">236</span> }<a name="line.236"></a> +<span class="sourceLineNo">237</span> }<a name="line.237"></a> +<span class="sourceLineNo">238</span> }<a name="line.238"></a> +<span class="sourceLineNo">239</span> if (!foundRegionsToMove) {<a name="line.239"></a> +<span class="sourceLineNo">240</span> iter.remove();<a name="line.240"></a> +<span class="sourceLineNo">241</span> }<a name="line.241"></a> +<span class="sourceLineNo">242</span> }<a name="line.242"></a> +<span class="sourceLineNo">243</span> try {<a name="line.243"></a> +<span class="sourceLineNo">244</span> rsGroupInfoManager.wait(1000);<a name="line.244"></a> +<span class="sourceLineNo">245</span> } catch (InterruptedException e) {<a name="line.245"></a> +<span class="sourceLineNo">246</span> LOG.warn("Sleep interrupted", e);<a name="line.246"></a> +<span class="sourceLineNo">247</span> Thread.currentThread().interrupt();<a name="line.247"></a> +<span class="sourceLineNo">248</span> }<a name="line.248"></a> +<span class="sourceLineNo">249</span> } while (foundRegionsToMove);<a name="line.249"></a> +<span class="sourceLineNo">250</span> }<a name="line.250"></a> +<span class="sourceLineNo">251</span><a name="line.251"></a> +<span class="sourceLineNo">252</span> /**<a name="line.252"></a> +<span class="sourceLineNo">253</span> * Moves every region of tables which should be kept on the servers,<a name="line.253"></a> +<span class="sourceLineNo">254</span> * but currently they are located on other servers.<a name="line.254"></a> +<span class="sourceLineNo">255</span> * @param servers the regions of these servers will be kept on the servers, others will be moved<a name="line.255"></a> +<span class="sourceLineNo">256</span> * @param tables the tables that will move to new group<a name="line.256"></a> +<span class="sourceLineNo">257</span> * @param targetGroupName the target group name<a name="line.257"></a> +<span class="sourceLineNo">258</span> * @throws IOException if moving the region fails<a name="line.258"></a> +<span class="sourceLineNo">259</span> */<a name="line.259"></a> +<span class="sourceLineNo">260</span> private void moveRegionsToServers(Set<Address> servers, Set<TableName> tables,<a name="line.260"></a> +<span class="sourceLineNo">261</span> String targetGroupName) throws IOException {<a name="line.261"></a> +<span class="sourceLineNo">262</span> for (TableName table: tables) {<a name="line.262"></a> +<span class="sourceLineNo">263</span> LOG.info("Moving region(s) from " + table + " for table move to " + targetGroupName);<a name="line.263"></a> +<span class="sourceLineNo">264</span> for (RegionInfo region : master.getAssignmentManager().getRegionStates()<a name="line.264"></a> +<span class="sourceLineNo">265</span> .getRegionsOfTable(table)) {<a name="line.265"></a> +<span class="sourceLineNo">266</span> ServerName sn = master.getAssignmentManager().getRegionStates()<a name="line.266"></a> +<span class="sourceLineNo">267</span> .getRegionServerOfRegion(region);<a name="line.267"></a> +<span class="sourceLineNo">268</span> if (!servers.contains(sn.getAddress())) {<a name="line.268"></a> +<span class="sourceLineNo">269</span> master.getAssignmentManager().move(region);<a name="line.269"></a> +<span class="sourceLineNo">270</span> }<a name="line.270"></a> +<span class="sourceLineNo">271</span> }<a name="line.271"></a> +<span class="sourceLineNo">272</span> }<a name="line.272"></a> +<span class="sourceLineNo">273</span> }<a name="line.273"></a> +<span class="sourceLineNo">274</span><a name="line.274"></a> +<span class="sourceLineNo">275</span> @edu.umd.cs.findbugs.annotations.SuppressWarnings(<a name="line.275"></a> +<span class="sourceLineNo">276</span> value="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE",<a name="line.276"></a> +<span class="sourceLineNo">277</span> justification="Ignoring complaint because don't know what it is complaining about")<a name="line.277"></a> +<span class="sourceLineNo">278</span> @Override<a name="line.278"></a> +<span class="sourceLineNo">279</span> public void moveServers(Set<Address> servers, String targetGroupName)<a name="line.279"></a> +<span class="sourceLineNo">280</span> throws IOException {<a name="line.280"></a> +<span class="sourceLineNo">281</span> if (servers == null) {<a name="line.281"></a> +<span class="sourceLineNo">282</span> throw new ConstraintException("The list of servers to move cannot be null.");<a name="line.282"></a> +<span class="sourceLineNo">283</span> }<a name="line.283"></a> +<span class="sourceLineNo">284</span> if (servers.isEmpty()) {<a name="line.284"></a> +<span class="sourceLineNo">285</span> // For some reason this difference between null servers and isEmpty is important distinction.<a name="line.285"></a> +<span class="sourceLineNo">286</span> // TODO. Why? Stuff breaks if I equate them.<a name="line.286"></a> +<span class="sourceLineNo">287</span> return;<a name="line.287"></a> +<span class="sourceLineNo">288</span> }<a name="line.288"></a> +<span class="sourceLineNo">289</span> RSGroupInfo targetGrp = getAndCheckRSGroupInfo(targetGroupName);<a name="line.289"></a> +<span class="sourceLineNo">290</span><a name="line.290"></a> +<span class="sourceLineNo">291</span> // Hold a lock on the manager instance while moving servers to prevent<a name="line.291"></a> +<span class="sourceLineNo">292</span> // another writer changing our state while we are working.<a name="line.292"></a> +<span class="sourceLineNo">293</span> synchronized (rsGroupInfoManager) {<a name="line.293"></a> +<span class="sourceLineNo">294</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.294"></a> +<span class="sourceLineNo">295</span> master.getMasterCoprocessorHost().preMoveServers(servers, targetGroupName);<a name="line.295"></a> +<span class="sourceLineNo">296</span> }<a name="line.296"></a> +<span class="sourceLineNo">297</span> // Presume first server's source group. Later ensure all servers are from this group.<a name="line.297"></a> +<span class="sourceLineNo">298</span> Address firstServer = servers.iterator().next();<a name="line.298"></a> +<span class="sourceLineNo">299</span> RSGroupInfo srcGrp = rsGroupInfoManager.getRSGroupOfServer(firstServer);<a name="line.299"></a> +<span class="sourceLineNo">300</span> if (srcGrp == null) {<a name="line.300"></a> +<span class="sourceLineNo">301</span> // Be careful. This exception message is tested for in TestRSGroupsBase...<a name="line.301"></a> +<span class="sourceLineNo">302</span> throw new ConstraintException("Source RSGroup for server " + firstServer<a name="line.302"></a> +<span class="sourceLineNo">303</span> + " does not exist.");<a name="line.303"></a> +<span class="sourceLineNo">304</span> }<a name="line.304"></a> +<span class="sourceLineNo">305</span> if (srcGrp.getName().equals(targetGroupName)) {<a name="line.305"></a> +<span class="sourceLineNo">306</span> throw new ConstraintException("Target RSGroup " + targetGroupName +<a name="line.306"></a> +<span class="sourceLineNo">307</span> " is same as source " + srcGrp + " RSGroup.");<a name="line.307"></a> +<span class="sourceLineNo">308</span> }<a name="line.308"></a> +<span class="sourceLineNo">309</span> // Only move online servers (when moving from 'default') or servers from other<a name="line.309"></a> +<span class="sourceLineNo">310</span> // groups. This prevents bogus servers from entering groups<a name="line.310"></a> +<span class="sourceLineNo">311</span> if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName())) {<a name="line.311"></a> +<span class="sourceLineNo">312</span> if (srcGrp.getServers().size() <= servers.size()) {<a name="line.312"></a> +<span class="sourceLineNo">313</span> throw new ConstraintException(KEEP_ONE_SERVER_IN_DEFAULT_ERROR_MESSAGE);<a name="line.313"></a> +<span class="sourceLineNo">314</span> }<a name="line.314"></a> +<span class="sourceLineNo">315</span> checkOnlineServersOnly(servers);<a name="line.315"></a> +<span class="sourceLineNo">316</span> }<a name="line.316"></a> +<span class="sourceLineNo">317</span> // Ensure all servers are of same rsgroup.<a name="line.317"></a> +<span class="sourceLineNo">318</span> for (Address server: servers) {<a name="line.318"></a> +<span class="sourceLineNo">319</span> String tmpGroup = rsGroupInfoManager.getRSGroupOfServer(server).getName();<a name="line.319"></a> +<span class="sourceLineNo">320</span> if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.320"></a> +<span class="sourceLineNo">321</span> throw new ConstraintException("Move server request should only come from one source " +<a name="line.321"></a> +<span class="sourceLineNo">322</span> "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.322"></a> +<span class="sourceLineNo">323</span> }<a name="line.323"></a> +<span class="sourceLineNo">324</span> }<a name="line.324"></a> +<span class="sourceLineNo">325</span> if (srcGrp.getServers().size() <= servers.size() && srcGrp.getTables().size() > 0) {<a name="line.325"></a> +<span class="sourceLineNo">326</span> throw new ConstraintException("Cannot leave a RSGroup " + srcGrp.getName() +<a name="line.326"></a> +<span class="sourceLineNo">327</span> " that contains tables without servers to host them.");<a name="line.327"></a> +<span class="sourceLineNo">328</span> }<a name="line.328"></a> +<span class="sourceLineNo">329</span><a name="line.329"></a> +<span class="sourceLineNo">330</span> // MovedServers may be < passed in 'servers'.<a name="line.330"></a> +<span class="sourceLineNo">331</span> Set<Address> movedServers = rsGroupInfoManager.moveServers(servers, srcGrp.getName(),<a name="line.331"></a> +<span class="sourceLineNo">332</span> targetGroupName);<a name="line.332"></a> +<span class="sourceLineNo">333</span> List<Address> editableMovedServers = Lists.newArrayList(movedServers);<a name="line.333"></a> +<span class="sourceLineNo">334</span> boolean foundRegionsToMove;<a name="line.334"></a> +<span class="sourceLineNo">335</span> do {<a name="line.335"></a> +<span class="sourceLineNo">336</span> foundRegionsToMove = false;<a name="line.336"></a> +<span class="sourceLineNo">337</span> for (Iterator<Address> iter = editableMovedServers.iterator(); iter.hasNext();) {<a name="line.337"></a> +<span class="sourceLineNo">338</span> Address rs = iter.next();<a name="line.338"></a> +<span class="sourceLineNo">339</span> // Get regions that are associated with this server.<a name="line.339"></a> +<span class="sourceLineNo">340</span> List<RegionInfo> regions = getRegions(rs);<a name="line.340"></a> +<span class="sourceLineNo">341</span><a name="line.341"></a> +<span class="sourceLineNo">342</span> LOG.info("Moving " + regions.size() + " region(s) from " + rs +<a name="line.342"></a> +<span class="sourceLineNo">343</span> " for server move to " + targetGroupName);<a name="line.343"></a> +<span class="sourceLineNo">344</span><a name="line.344"></a> +<span class="sourceLineNo">345</span> for (RegionInfo region: regions) {<a name="line.345"></a> +<span class="sourceLineNo">346</span> // Regions might get assigned from tables of target group so we need to filter<a name="line.346"></a> +<span class="sourceLineNo">347</span> if (targetGrp.containsTable(region.getTable())) {<a name="line.347"></a> +<span class="sourceLineNo">348</span> continue;<a name="line.348"></a> +<span class="sourceLineNo">349</span> }<a name="line.349"></a> +<span class="sourceLineNo">350</span> LOG.info("Moving region " + region.getShortNameToLog());<a name="line.350"></a> +<span class="sourceLineNo">351</span> this.master.getAssignmentManager().move(region);<a name="line.351"></a> +<span class="sourceLineNo">352</span> if (master.getAssignmentManager().getRegionStates().<a name="line.352"></a> +<span class="sourceLineNo">353</span> getRegionState(region).isFailedOpen()) {<a name="line.353"></a> +<span class="sourceLineNo">354</span> // If region is in FAILED_OPEN state, it won't recover, not without<a name="line.354"></a> +<span class="sourceLineNo">355</span> // operator intervention... in hbase-2.0.0 at least. Continue rather<a name="line.355"></a> +<span class="sourceLineNo">356</span> // than mark region as 'foundRegionsToMove'.<a name="line.356"></a> +<span class="sourceLineNo">357</span> continue;<a name="line.357"></a> +<span class="sourceLineNo">358</span> }<a name="line.358"></a> +<span class="sourceLineNo">359</span> foundRegionsToMove = true;<a name="line.359"></a> +<span class="sourceLineNo">360</span> }<a name="line.360"></a> +<span class="sourceLineNo">361</span> if (!foundRegionsToMove) {<a name="line.361"></a> +<span class="sourceLineNo">362</span> iter.remove();<a name="line.362"></a> +<span class="sourceLineNo">363</span> }<a name="line.363"></a> +<span class="sourceLineNo">364</span> }<a name="line.364"></a> +<span class="sourceLineNo">365</span> try {<a name="line.365"></a> +<span class="sourceLineNo">366</span> rsGroupInfoManager.wait(1000);<a name="line.366"></a> +<span class="sourceLineNo">367</span> } catch (InterruptedException e) {<a name="line.367"></a> +<span class="sourceLineNo">368</span> LOG.warn("Sleep interrupted", e);<a name="line.368"></a> +<span class="sourceLineNo">369</span> Thread.currentThread().interrupt();<a name="line.369"></a> +<span class="sourceLineNo">370</span> }<a name="line.370"></a> +<span class="sourceLineNo">371</span> } while (foundRegionsToMove);<a name="line.371"></a> +<span class="sourceLineNo">372</span><a name="line.372"></a> +<span class="sourceLineNo">373</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.373"></a> +<span class="sourceLineNo">374</span> master.getMasterCoprocessorHost().postMoveServers(servers, targetGroupName);<a name="line.374"></a> +<span class="sourceLineNo">375</span> }<a name="line.375"></a> +<span class="sourceLineNo">376</span> LOG.info("Move server done: " + srcGrp.getName() + "=>" + targetGroupName);<a name="line.376"></a> +<span class="sourceLineNo">377</span> }<a name="line.377"></a> +<span class="sourceLineNo">378</span> }<a name="line.378"></a> +<span class="sourceLineNo">379</span><a name="line.379"></a> +<span class="sourceLineNo">380</span> @Override<a name="line.380"></a> +<span class="sourceLineNo">381</span> public void moveTables(Set<TableName> tables, String targetGroup) throws IOException {<a name="line.381"></a> +<span class="sourceLineNo">382</span> if (tables == null) {<a name="line.382"></a> +<span class="sourceLineNo">383</span> throw new ConstraintException("The list of servers cannot be null.");<a name="line.383"></a> +<span class="sourceLineNo">384</span> }<a name="line.384"></a> +<span class="sourceLineNo">385</span> if (tables.size() < 1) {<a name="line.385"></a> +<span class="sourceLineNo">386</span> LOG.debug("moveTables() passed an empty set. Ignoring.");<a name="line.386"></a> +<span class="sourceLineNo">387</span> return;<a name="line.387"></a> +<span class="sourceLineNo">388</span> }<a name="line.388"></a> +<span class="sourceLineNo">389</span><a name="line.389"></a> +<span class="sourceLineNo">390</span> // Hold a lock on the manager instance while moving servers to prevent<a name="line.390"></a> +<span class="sourceLineNo">391</span> // another writer changing our state while we are working.<a name="line.391"></a> +<span class="sourceLineNo">392</span> synchronized (rsGroupInfoManager) {<a name="line.392"></a> +<span class="sourceLineNo">393</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.393"></a> +<span class="sourceLineNo">394</span> master.getMasterCoprocessorHost().preMoveTables(tables, targetGroup);<a name="line.394"></a> +<span class="sourceLineNo">395</span> }<a name="line.395"></a> +<span class="sourceLineNo">396</span> if(targetGroup != null) {<a name="line.396"></a> +<span class="sourceLineNo">397</span> RSGroupInfo destGroup = rsGroupInfoManager.getRSGroup(targetGroup);<a name="line.397"></a> +<span class="sourceLineNo">398</span> if(destGroup == null) {<a name="line.398"></a> +<span class="sourceLineNo">399</span> throw new ConstraintException("Target " + targetGroup + " RSGroup does not exist.");<a name="line.399"></a> +<span class="sourceLineNo">400</span> }<a name="line.400"></a> +<span class="sourceLineNo">401</span> if(destGroup.getServers().size() < 1) {<a name="line.401"></a> +<span class="sourceLineNo">402</span> throw new ConstraintException("Target RSGroup must have at least one server.");<a name="line.402"></a> +<span class="sourceLineNo">403</span> }<a name="line.403"></a> +<span class="sourceLineNo">404</span> }<a name="line.404"></a> +<span class="sourceLineNo">405</span><a name="line.405"></a> +<span class="sourceLineNo">406</span> for (TableName table : tables) {<a name="line.406"></a> +<span class="sourceLineNo">407</span> String srcGroup = rsGroupInfoManager.getRSGroupOfTable(table);<a name="line.407"></a> +<span class="sourceLineNo">408</span> if(srcGroup != null && srcGroup.equals(targetGroup)) {<a name="line.408"></a> +<span class="sourceLineNo">409</span> throw new ConstraintException(<a name="line.409"></a> +<span class="sourceLineNo">410</span> "Source RSGroup " + srcGroup + " is same as target " + targetGroup +<a name="line.410"></a> +<span class="sourceLineNo">411</span> " RSGroup for table " + table);<a name="line.411"></a> +<span class="sourceLineNo">412</span> }<a name="line.412"></a> +<span class="sourceLineNo">413</span> LOG.info("Moving table " + table.getNameAsString() + " to RSGroup " + targetGroup);<a name="line.413"></a> +<span class="sourceLineNo">414</span> }<a name="line.414"></a> +<span class="sourceLineNo">415</span> rsGroupInfoManager.moveTables(tables, targetGroup);<a name="line.415"></a> +<span class="sourceLineNo">416</span><a name="line.416"></a> +<span class="sourceLineNo">417</span> // targetGroup is null when a table is being deleted. In this case no further<a name="line.417"></a> +<span class="sourceLineNo">418</span> // action is required.<a name="line.418"></a> +<span class="sourceLineNo">419</span> if (targetGroup != null) {<a name="line.419"></a> +<span class="sourceLineNo">420</span> for (TableName table: tables) {<a name="line.420"></a> +<span class="sourceLineNo">421</span> if (master.getAssignmentManager().isTableDisabled(table)) {<a name="line.421"></a> +<span class="sourceLineNo">422</span> LOG.debug("Skipping move regions because the table" + table + " is disabled.");<a name="line.422"></a> +<span class="sourceLineNo">423</span> continue;<a name="line.423"></a> +<span class="sourceLineNo">424</span> }<a name="line.424"></a> +<span class="sourceLineNo">425</span> for (RegionInfo region :<a name="line.425"></a> +<span class="sourceLineNo">426</span> master.getAssignmentManager().getRegionStates().getRegionsOfTable(table)) {<a name="line.426"></a> +<span class="sourceLineNo">427</span> LOG.info("Moving region " + region.getShortNameToLog() +<a name="line.427"></a> +<span class="sourceLineNo">428</span> " to RSGroup " + targetGroup);<a name="line.428"></a> +<span class="sourceLineNo">429</span> master.getAssignmentManager().move(region);<a name="line.429"></a> +<span class="sourceLineNo">430</span> }<a name="line.430"></a> +<span class="sourceLineNo">431</span> }<a name="line.431"></a> +<span class="sourceLineNo">432</span> }<a name="line.432"></a> +<span class="sourceLineNo">433</span><a name="line.433"></a> +<span class="sourceLineNo">434</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.434"></a> +<span class="sourceLineNo">435</span> master.getMasterCoprocessorHost().postMoveTables(tables, targetGroup);<a name="line.435"></a> +<span class="sourceLineNo">436</span> }<a name="line.436"></a> +<span class="sourceLineNo">437</span> }<a name="line.437"></a> +<span class="sourceLineNo">438</span> }<a name="line.438"></a> +<span class="sourceLineNo">439</span><a name="line.439"></a> +<span class="sourceLineNo">440</span> @Override<a name="line.440"></a> +<span class="sourceLineNo">441</span> public void addRSGroup(String name) throws IOException {<a name="line.441"></a> +<span class="sourceLineNo">442</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.442"></a> +<span class="sourceLineNo">443</span> master.getMasterCoprocessorHost().preAddRSGroup(name);<a name="line.443"></a> +<span class="sourceLineNo">444</span> }<a name="line.444"></a> +<span class="sourceLineNo">445</span> rsGroupInfoManager.addRSGroup(new RSGroupInfo(name));<a name="line.445"></a> +<span class="sourceLineNo">446</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.446"></a> +<span class="sourceLineNo">447</span> master.getMasterCoprocessorHost().postAddRSGroup(name);<a name="line.447"></a> +<span class="sourceLineNo">448</span> }<a name="line.448"></a> +<span class="sourceLineNo">449</span> }<a name="line.449"></a> +<span class="sourceLineNo">450</span><a name="line.450"></a> +<span class="sourceLineNo">451</span> @Override<a name="line.451"></a> +<span class="sourceLineNo">452</span> public void removeRSGroup(String name) throws IOException {<a name="line.452"></a> +<span class="sourceLineNo">453</span> // Hold a lock on the manager instance while moving servers to prevent<a name="line.453"></a> +<span class="sourceLineNo">454</span> // another writer changing our state while we are working.<a name="line.454"></a> +<span class="sourceLineNo">455</span> synchronized (rsGroupInfoManager) {<a name="line.455"></a> +<span class="sourceLineNo">456</span> if (master.getMasterCoprocessorHost() != null) {<a name="line.456"></a> +<span class="sourceLineNo">457</span> master.getMasterCoprocessorHost().preRemoveRSGroup(name);<a name="line.457"></a> +<span class="sourceLineNo">458</span> }<a name="line.458"></a> +<span class="sourceLineNo">459</span> RSGroupInfo rsGroupInfo = rsGroupInfoManager.getRSGroup(name);<a name="line.459"></a> +<span class="sourceLineNo">460</span> if (rsGroupInfo == null) {<a name="line.460"></a> +<span class="sourceLin
<TRUNCATED>