http://git-wip-us.apache.org/repos/asf/hbase-site/blob/883dde2f/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
----------------------------------------------------------------------
diff --git 
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html 
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
index 7290d52..f71c930 100644
--- 
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
+++ 
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
@@ -128,244 +128,245 @@
 <span class="sourceLineNo">120</span>   */<a name="line.120"></a>
 <span class="sourceLineNo">121</span>  @Override<a name="line.121"></a>
 <span class="sourceLineNo">122</span>  public Cell forceCopyOfBigCellInto(Cell 
cell) {<a name="line.122"></a>
-<span class="sourceLineNo">123</span>    int size = KeyValueUtil.length(cell) 
+ ChunkCreator.SIZEOF_CHUNK_HEADER;<a name="line.123"></a>
-<span class="sourceLineNo">124</span>    Preconditions.checkArgument(size 
&gt;= 0, "negative size");<a name="line.124"></a>
-<span class="sourceLineNo">125</span>    if (size &lt;= dataChunkSize) {<a 
name="line.125"></a>
-<span class="sourceLineNo">126</span>      // Using copyCellInto for cells 
which are bigger than the original maxAlloc<a name="line.126"></a>
-<span class="sourceLineNo">127</span>      Cell newCell = copyCellInto(cell, 
dataChunkSize);<a name="line.127"></a>
-<span class="sourceLineNo">128</span>      return newCell;<a 
name="line.128"></a>
-<span class="sourceLineNo">129</span>    } else {<a name="line.129"></a>
-<span class="sourceLineNo">130</span>      Chunk c = 
getNewExternalChunk(size);<a name="line.130"></a>
-<span class="sourceLineNo">131</span>      int allocOffset = c.alloc(size);<a 
name="line.131"></a>
-<span class="sourceLineNo">132</span>      return copyToChunkCell(cell, 
c.getData(), allocOffset, size);<a name="line.132"></a>
-<span class="sourceLineNo">133</span>    }<a name="line.133"></a>
-<span class="sourceLineNo">134</span>  }<a name="line.134"></a>
-<span class="sourceLineNo">135</span><a name="line.135"></a>
-<span class="sourceLineNo">136</span>  private Cell copyCellInto(Cell cell, 
int maxAlloc) {<a name="line.136"></a>
-<span class="sourceLineNo">137</span>    int size = 
KeyValueUtil.length(cell);<a name="line.137"></a>
-<span class="sourceLineNo">138</span>    Preconditions.checkArgument(size 
&gt;= 0, "negative size");<a name="line.138"></a>
-<span class="sourceLineNo">139</span>    // Callers should satisfy large 
allocations directly from JVM since they<a name="line.139"></a>
-<span class="sourceLineNo">140</span>    // don't cause fragmentation as 
badly.<a name="line.140"></a>
-<span class="sourceLineNo">141</span>    if (size &gt; maxAlloc) {<a 
name="line.141"></a>
-<span class="sourceLineNo">142</span>      return null;<a name="line.142"></a>
-<span class="sourceLineNo">143</span>    }<a name="line.143"></a>
-<span class="sourceLineNo">144</span>    Chunk c = null;<a name="line.144"></a>
-<span class="sourceLineNo">145</span>    int allocOffset = 0;<a 
name="line.145"></a>
-<span class="sourceLineNo">146</span>    while (true) {<a name="line.146"></a>
-<span class="sourceLineNo">147</span>      // Try to get the chunk<a 
name="line.147"></a>
-<span class="sourceLineNo">148</span>      c = getOrMakeChunk();<a 
name="line.148"></a>
-<span class="sourceLineNo">149</span>      // we may get null because the some 
other thread succeeded in getting the lock<a name="line.149"></a>
-<span class="sourceLineNo">150</span>      // and so the current thread has to 
try again to make its chunk or grab the chunk<a name="line.150"></a>
-<span class="sourceLineNo">151</span>      // that the other thread created<a 
name="line.151"></a>
-<span class="sourceLineNo">152</span>      // Try to allocate from this 
chunk<a name="line.152"></a>
-<span class="sourceLineNo">153</span>      if (c != null) {<a 
name="line.153"></a>
-<span class="sourceLineNo">154</span>        allocOffset = c.alloc(size);<a 
name="line.154"></a>
-<span class="sourceLineNo">155</span>        if (allocOffset != -1) {<a 
name="line.155"></a>
-<span class="sourceLineNo">156</span>          // We succeeded - this is the 
common case - small alloc<a name="line.156"></a>
-<span class="sourceLineNo">157</span>          // from a big buffer<a 
name="line.157"></a>
-<span class="sourceLineNo">158</span>          break;<a name="line.158"></a>
-<span class="sourceLineNo">159</span>        }<a name="line.159"></a>
-<span class="sourceLineNo">160</span>        // not enough space!<a 
name="line.160"></a>
-<span class="sourceLineNo">161</span>        // try to retire this chunk<a 
name="line.161"></a>
-<span class="sourceLineNo">162</span>        tryRetireChunk(c);<a 
name="line.162"></a>
-<span class="sourceLineNo">163</span>      }<a name="line.163"></a>
-<span class="sourceLineNo">164</span>    }<a name="line.164"></a>
-<span class="sourceLineNo">165</span>    return copyToChunkCell(cell, 
c.getData(), allocOffset, size);<a name="line.165"></a>
-<span class="sourceLineNo">166</span>  }<a name="line.166"></a>
-<span class="sourceLineNo">167</span><a name="line.167"></a>
-<span class="sourceLineNo">168</span>  /**<a name="line.168"></a>
-<span class="sourceLineNo">169</span>   * Clone the passed cell by copying its 
data into the passed buf and create a cell with a chunkid<a name="line.169"></a>
-<span class="sourceLineNo">170</span>   * out of it<a name="line.170"></a>
-<span class="sourceLineNo">171</span>   */<a name="line.171"></a>
-<span class="sourceLineNo">172</span>  private Cell copyToChunkCell(Cell cell, 
ByteBuffer buf, int offset, int len) {<a name="line.172"></a>
-<span class="sourceLineNo">173</span>    int tagsLen = cell.getTagsLength();<a 
name="line.173"></a>
-<span class="sourceLineNo">174</span>    if (cell instanceof ExtendedCell) {<a 
name="line.174"></a>
-<span class="sourceLineNo">175</span>      ((ExtendedCell) cell).write(buf, 
offset);<a name="line.175"></a>
-<span class="sourceLineNo">176</span>    } else {<a name="line.176"></a>
-<span class="sourceLineNo">177</span>      // Normally all Cell impls within 
Server will be of type ExtendedCell. Just considering the<a name="line.177"></a>
-<span class="sourceLineNo">178</span>      // other case also. The data 
fragments within Cell is copied into buf as in KeyValue<a name="line.178"></a>
-<span class="sourceLineNo">179</span>      // serialization format only.<a 
name="line.179"></a>
-<span class="sourceLineNo">180</span>      KeyValueUtil.appendTo(cell, buf, 
offset, true);<a name="line.180"></a>
-<span class="sourceLineNo">181</span>    }<a name="line.181"></a>
-<span class="sourceLineNo">182</span>    // TODO : write the seqid here. For 
writing seqId we should create a new cell type so<a name="line.182"></a>
-<span class="sourceLineNo">183</span>    // that seqId is not used as the 
state<a name="line.183"></a>
-<span class="sourceLineNo">184</span>    if (tagsLen == 0) {<a 
name="line.184"></a>
-<span class="sourceLineNo">185</span>      // When tagsLen is 0, make a 
NoTagsByteBufferKeyValue version. This is an optimized class<a 
name="line.185"></a>
-<span class="sourceLineNo">186</span>      // which directly return tagsLen as 
0. So we avoid parsing many length components in<a name="line.186"></a>
-<span class="sourceLineNo">187</span>      // reading the tagLength stored in 
the backing buffer. The Memstore addition of every Cell<a name="line.187"></a>
-<span class="sourceLineNo">188</span>      // call getTagsLength().<a 
name="line.188"></a>
-<span class="sourceLineNo">189</span>      return new 
NoTagByteBufferChunkKeyValue(buf, offset, len, cell.getSequenceId());<a 
name="line.189"></a>
-<span class="sourceLineNo">190</span>    } else {<a name="line.190"></a>
-<span class="sourceLineNo">191</span>      return new 
ByteBufferChunkKeyValue(buf, offset, len, cell.getSequenceId());<a 
name="line.191"></a>
-<span class="sourceLineNo">192</span>    }<a name="line.192"></a>
-<span class="sourceLineNo">193</span>  }<a name="line.193"></a>
-<span class="sourceLineNo">194</span><a name="line.194"></a>
-<span class="sourceLineNo">195</span>  /**<a name="line.195"></a>
-<span class="sourceLineNo">196</span>   * Close this instance since it won't 
be used any more, try to put the chunks<a name="line.196"></a>
-<span class="sourceLineNo">197</span>   * back to pool<a name="line.197"></a>
-<span class="sourceLineNo">198</span>   */<a name="line.198"></a>
-<span class="sourceLineNo">199</span>  @Override<a name="line.199"></a>
-<span class="sourceLineNo">200</span>  public void close() {<a 
name="line.200"></a>
-<span class="sourceLineNo">201</span>    this.closed = true;<a 
name="line.201"></a>
-<span class="sourceLineNo">202</span>    // We could put back the chunks to 
pool for reusing only when there is no<a name="line.202"></a>
-<span class="sourceLineNo">203</span>    // opening scanner which will read 
their data<a name="line.203"></a>
-<span class="sourceLineNo">204</span>    int count  = 
openScannerCount.get();<a name="line.204"></a>
-<span class="sourceLineNo">205</span>    if(count == 0) {<a 
name="line.205"></a>
-<span class="sourceLineNo">206</span>      recycleChunks();<a 
name="line.206"></a>
-<span class="sourceLineNo">207</span>    }<a name="line.207"></a>
-<span class="sourceLineNo">208</span>  }<a name="line.208"></a>
-<span class="sourceLineNo">209</span><a name="line.209"></a>
-<span class="sourceLineNo">210</span>  /**<a name="line.210"></a>
-<span class="sourceLineNo">211</span>   * Called when opening a scanner on the 
data of this MemStoreLAB<a name="line.211"></a>
-<span class="sourceLineNo">212</span>   */<a name="line.212"></a>
-<span class="sourceLineNo">213</span>  @Override<a name="line.213"></a>
-<span class="sourceLineNo">214</span>  public void incScannerCount() {<a 
name="line.214"></a>
-<span class="sourceLineNo">215</span>    
this.openScannerCount.incrementAndGet();<a name="line.215"></a>
-<span class="sourceLineNo">216</span>  }<a name="line.216"></a>
-<span class="sourceLineNo">217</span><a name="line.217"></a>
-<span class="sourceLineNo">218</span>  /**<a name="line.218"></a>
-<span class="sourceLineNo">219</span>   * Called when closing a scanner on the 
data of this MemStoreLAB<a name="line.219"></a>
-<span class="sourceLineNo">220</span>   */<a name="line.220"></a>
-<span class="sourceLineNo">221</span>  @Override<a name="line.221"></a>
-<span class="sourceLineNo">222</span>  public void decScannerCount() {<a 
name="line.222"></a>
-<span class="sourceLineNo">223</span>    int count = 
this.openScannerCount.decrementAndGet();<a name="line.223"></a>
-<span class="sourceLineNo">224</span>    if (this.closed &amp;&amp; count == 
0) {<a name="line.224"></a>
-<span class="sourceLineNo">225</span>      recycleChunks();<a 
name="line.225"></a>
-<span class="sourceLineNo">226</span>    }<a name="line.226"></a>
-<span class="sourceLineNo">227</span>  }<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span>  private void recycleChunks() {<a 
name="line.229"></a>
-<span class="sourceLineNo">230</span>    if (reclaimed.compareAndSet(false, 
true)) {<a name="line.230"></a>
-<span class="sourceLineNo">231</span>      
chunkCreator.putbackChunks(chunks);<a name="line.231"></a>
-<span class="sourceLineNo">232</span>    }<a name="line.232"></a>
-<span class="sourceLineNo">233</span>  }<a name="line.233"></a>
-<span class="sourceLineNo">234</span><a name="line.234"></a>
-<span class="sourceLineNo">235</span>  /**<a name="line.235"></a>
-<span class="sourceLineNo">236</span>   * Try to retire the current chunk if 
it is still<a name="line.236"></a>
-<span class="sourceLineNo">237</span>   * &lt;code&gt;c&lt;/code&gt;. 
Postcondition is that curChunk.get()<a name="line.237"></a>
-<span class="sourceLineNo">238</span>   * != c<a name="line.238"></a>
-<span class="sourceLineNo">239</span>   * @param c the chunk to retire<a 
name="line.239"></a>
-<span class="sourceLineNo">240</span>   * @return true if we won the race to 
retire the chunk<a name="line.240"></a>
-<span class="sourceLineNo">241</span>   */<a name="line.241"></a>
-<span class="sourceLineNo">242</span>  private void tryRetireChunk(Chunk c) 
{<a name="line.242"></a>
-<span class="sourceLineNo">243</span>    currChunk.compareAndSet(c, null);<a 
name="line.243"></a>
-<span class="sourceLineNo">244</span>    // If the CAS succeeds, that means 
that we won the race<a name="line.244"></a>
-<span class="sourceLineNo">245</span>    // to retire the chunk. We could use 
this opportunity to<a name="line.245"></a>
-<span class="sourceLineNo">246</span>    // update metrics on external 
fragmentation.<a name="line.246"></a>
-<span class="sourceLineNo">247</span>    //<a name="line.247"></a>
-<span class="sourceLineNo">248</span>    // If the CAS fails, that means that 
someone else already<a name="line.248"></a>
-<span class="sourceLineNo">249</span>    // retired the chunk for us.<a 
name="line.249"></a>
-<span class="sourceLineNo">250</span>  }<a name="line.250"></a>
-<span class="sourceLineNo">251</span><a name="line.251"></a>
-<span class="sourceLineNo">252</span>  /**<a name="line.252"></a>
-<span class="sourceLineNo">253</span>   * Get the current chunk, or, if there 
is no current chunk,<a name="line.253"></a>
-<span class="sourceLineNo">254</span>   * allocate a new one from the JVM.<a 
name="line.254"></a>
-<span class="sourceLineNo">255</span>   */<a name="line.255"></a>
-<span class="sourceLineNo">256</span>  private Chunk getOrMakeChunk() {<a 
name="line.256"></a>
-<span class="sourceLineNo">257</span>    // Try to get the chunk<a 
name="line.257"></a>
-<span class="sourceLineNo">258</span>    Chunk c;<a name="line.258"></a>
-<span class="sourceLineNo">259</span>    c = currChunk.get();<a 
name="line.259"></a>
-<span class="sourceLineNo">260</span>    if (c != null) {<a 
name="line.260"></a>
-<span class="sourceLineNo">261</span>      return c;<a name="line.261"></a>
-<span class="sourceLineNo">262</span>    }<a name="line.262"></a>
-<span class="sourceLineNo">263</span>    // No current chunk, so we want to 
allocate one. We race<a name="line.263"></a>
-<span class="sourceLineNo">264</span>    // against other allocators to CAS in 
an uninitialized chunk<a name="line.264"></a>
-<span class="sourceLineNo">265</span>    // (which is cheap to allocate)<a 
name="line.265"></a>
-<span class="sourceLineNo">266</span>    if (lock.tryLock()) {<a 
name="line.266"></a>
-<span class="sourceLineNo">267</span>      try {<a name="line.267"></a>
-<span class="sourceLineNo">268</span>        // once again check inside the 
lock<a name="line.268"></a>
-<span class="sourceLineNo">269</span>        c = currChunk.get();<a 
name="line.269"></a>
-<span class="sourceLineNo">270</span>        if (c != null) {<a 
name="line.270"></a>
-<span class="sourceLineNo">271</span>          return c;<a name="line.271"></a>
-<span class="sourceLineNo">272</span>        }<a name="line.272"></a>
-<span class="sourceLineNo">273</span>        c = 
this.chunkCreator.getChunk(idxType);<a name="line.273"></a>
-<span class="sourceLineNo">274</span>        if (c != null) {<a 
name="line.274"></a>
-<span class="sourceLineNo">275</span>          // set the curChunk. No need of 
CAS as only one thread will be here<a name="line.275"></a>
-<span class="sourceLineNo">276</span>          currChunk.set(c);<a 
name="line.276"></a>
-<span class="sourceLineNo">277</span>          chunks.add(c.getId());<a 
name="line.277"></a>
-<span class="sourceLineNo">278</span>          return c;<a name="line.278"></a>
-<span class="sourceLineNo">279</span>        }<a name="line.279"></a>
-<span class="sourceLineNo">280</span>      } finally {<a name="line.280"></a>
-<span class="sourceLineNo">281</span>        lock.unlock();<a 
name="line.281"></a>
-<span class="sourceLineNo">282</span>      }<a name="line.282"></a>
-<span class="sourceLineNo">283</span>    }<a name="line.283"></a>
-<span class="sourceLineNo">284</span>    return null;<a name="line.284"></a>
-<span class="sourceLineNo">285</span>  }<a name="line.285"></a>
-<span class="sourceLineNo">286</span><a name="line.286"></a>
-<span class="sourceLineNo">287</span>  /* Returning a new pool chunk, without 
replacing current chunk,<a name="line.287"></a>
-<span class="sourceLineNo">288</span>  ** meaning MSLABImpl does not make the 
returned chunk as CurChunk.<a name="line.288"></a>
-<span class="sourceLineNo">289</span>  ** The space on this chunk will be 
allocated externally.<a name="line.289"></a>
-<span class="sourceLineNo">290</span>  ** The interface is only for external 
callers.<a name="line.290"></a>
-<span class="sourceLineNo">291</span>  */<a name="line.291"></a>
-<span class="sourceLineNo">292</span>  @Override<a name="line.292"></a>
-<span class="sourceLineNo">293</span>  public Chunk 
getNewExternalChunk(ChunkCreator.ChunkType chunkType) {<a name="line.293"></a>
-<span class="sourceLineNo">294</span>    switch (chunkType) {<a 
name="line.294"></a>
-<span class="sourceLineNo">295</span>      case INDEX_CHUNK:<a 
name="line.295"></a>
-<span class="sourceLineNo">296</span>      case DATA_CHUNK:<a 
name="line.296"></a>
-<span class="sourceLineNo">297</span>        Chunk c = 
this.chunkCreator.getChunk(chunkType);<a name="line.297"></a>
-<span class="sourceLineNo">298</span>        chunks.add(c.getId());<a 
name="line.298"></a>
-<span class="sourceLineNo">299</span>        return c;<a name="line.299"></a>
-<span class="sourceLineNo">300</span>      case JUMBO_CHUNK: // a jumbo chunk 
doesn't have a fixed size<a name="line.300"></a>
-<span class="sourceLineNo">301</span>      default:<a name="line.301"></a>
-<span class="sourceLineNo">302</span>        return null;<a 
name="line.302"></a>
-<span class="sourceLineNo">303</span>    }<a name="line.303"></a>
-<span class="sourceLineNo">304</span>  }<a name="line.304"></a>
-<span class="sourceLineNo">305</span><a name="line.305"></a>
-<span class="sourceLineNo">306</span>  /* Returning a new chunk, without 
replacing current chunk,<a name="line.306"></a>
-<span class="sourceLineNo">307</span>  ** meaning MSLABImpl does not make the 
returned chunk as CurChunk.<a name="line.307"></a>
-<span class="sourceLineNo">308</span>  ** The space on this chunk will be 
allocated externally.<a name="line.308"></a>
-<span class="sourceLineNo">309</span>  ** The interface is only for external 
callers.<a name="line.309"></a>
-<span class="sourceLineNo">310</span>  ** Chunks from pools are not allocated 
from here, since they have fixed sizes<a name="line.310"></a>
-<span class="sourceLineNo">311</span>  */<a name="line.311"></a>
-<span class="sourceLineNo">312</span>  @Override<a name="line.312"></a>
-<span class="sourceLineNo">313</span>  public Chunk getNewExternalChunk(int 
size) {<a name="line.313"></a>
-<span class="sourceLineNo">314</span>    int allocSize = size + 
ChunkCreator.getInstance().SIZEOF_CHUNK_HEADER;<a name="line.314"></a>
-<span class="sourceLineNo">315</span>    if (allocSize &lt;= 
ChunkCreator.getInstance().getChunkSize()) {<a name="line.315"></a>
-<span class="sourceLineNo">316</span>      return 
getNewExternalChunk(ChunkCreator.ChunkType.DATA_CHUNK);<a name="line.316"></a>
-<span class="sourceLineNo">317</span>    } else {<a name="line.317"></a>
-<span class="sourceLineNo">318</span>      Chunk c = 
this.chunkCreator.getJumboChunk(size);<a name="line.318"></a>
-<span class="sourceLineNo">319</span>      chunks.add(c.getId());<a 
name="line.319"></a>
-<span class="sourceLineNo">320</span>      return c;<a name="line.320"></a>
-<span class="sourceLineNo">321</span>    }<a name="line.321"></a>
-<span class="sourceLineNo">322</span>  }<a name="line.322"></a>
-<span class="sourceLineNo">323</span><a name="line.323"></a>
-<span class="sourceLineNo">324</span>  @Override<a name="line.324"></a>
-<span class="sourceLineNo">325</span>  public boolean isOnHeap() {<a 
name="line.325"></a>
-<span class="sourceLineNo">326</span>    return !isOffHeap();<a 
name="line.326"></a>
-<span class="sourceLineNo">327</span>  }<a name="line.327"></a>
-<span class="sourceLineNo">328</span><a name="line.328"></a>
-<span class="sourceLineNo">329</span>  @Override<a name="line.329"></a>
-<span class="sourceLineNo">330</span>  public boolean isOffHeap() {<a 
name="line.330"></a>
-<span class="sourceLineNo">331</span>    return 
this.chunkCreator.isOffheap();<a name="line.331"></a>
-<span class="sourceLineNo">332</span>  }<a name="line.332"></a>
-<span class="sourceLineNo">333</span><a name="line.333"></a>
-<span class="sourceLineNo">334</span>  @VisibleForTesting<a 
name="line.334"></a>
-<span class="sourceLineNo">335</span>  Chunk getCurrentChunk() {<a 
name="line.335"></a>
-<span class="sourceLineNo">336</span>    return currChunk.get();<a 
name="line.336"></a>
-<span class="sourceLineNo">337</span>  }<a name="line.337"></a>
-<span class="sourceLineNo">338</span><a name="line.338"></a>
-<span class="sourceLineNo">339</span>  @VisibleForTesting<a 
name="line.339"></a>
-<span class="sourceLineNo">340</span>  BlockingQueue&lt;Chunk&gt; 
getPooledChunks() {<a name="line.340"></a>
-<span class="sourceLineNo">341</span>    BlockingQueue&lt;Chunk&gt; 
pooledChunks = new LinkedBlockingQueue&lt;&gt;();<a name="line.341"></a>
-<span class="sourceLineNo">342</span>    for (Integer id : this.chunks) {<a 
name="line.342"></a>
-<span class="sourceLineNo">343</span>      Chunk chunk = 
chunkCreator.getChunk(id);<a name="line.343"></a>
-<span class="sourceLineNo">344</span>      if (chunk != null &amp;&amp; 
chunk.isFromPool()) {<a name="line.344"></a>
-<span class="sourceLineNo">345</span>        pooledChunks.add(chunk);<a 
name="line.345"></a>
-<span class="sourceLineNo">346</span>      }<a name="line.346"></a>
-<span class="sourceLineNo">347</span>    }<a name="line.347"></a>
-<span class="sourceLineNo">348</span>    return pooledChunks;<a 
name="line.348"></a>
-<span class="sourceLineNo">349</span>  }<a name="line.349"></a>
-<span class="sourceLineNo">350</span><a name="line.350"></a>
-<span class="sourceLineNo">351</span>  @VisibleForTesting Integer 
getNumOfChunksReturnedToPool() {<a name="line.351"></a>
-<span class="sourceLineNo">352</span>    int i = 0;<a name="line.352"></a>
-<span class="sourceLineNo">353</span>    for (Integer id : this.chunks) {<a 
name="line.353"></a>
-<span class="sourceLineNo">354</span>      if (chunkCreator.isChunkInPool(id)) 
{<a name="line.354"></a>
-<span class="sourceLineNo">355</span>        i++;<a name="line.355"></a>
-<span class="sourceLineNo">356</span>      }<a name="line.356"></a>
-<span class="sourceLineNo">357</span>    }<a name="line.357"></a>
-<span class="sourceLineNo">358</span>    return i;<a name="line.358"></a>
-<span class="sourceLineNo">359</span>  }<a name="line.359"></a>
-<span class="sourceLineNo">360</span>}<a name="line.360"></a>
+<span class="sourceLineNo">123</span>    int size = cell instanceof 
ExtendedCell? ((ExtendedCell)cell).getSerializedSize():<a name="line.123"></a>
+<span class="sourceLineNo">124</span>        KeyValueUtil.length(cell);<a 
name="line.124"></a>
+<span class="sourceLineNo">125</span>    size += 
ChunkCreator.SIZEOF_CHUNK_HEADER;<a name="line.125"></a>
+<span class="sourceLineNo">126</span>    Preconditions.checkArgument(size 
&gt;= 0, "negative size");<a name="line.126"></a>
+<span class="sourceLineNo">127</span>    if (size &lt;= dataChunkSize) {<a 
name="line.127"></a>
+<span class="sourceLineNo">128</span>      // Using copyCellInto for cells 
which are bigger than the original maxAlloc<a name="line.128"></a>
+<span class="sourceLineNo">129</span>      return copyCellInto(cell, 
dataChunkSize);<a name="line.129"></a>
+<span class="sourceLineNo">130</span>    } else {<a name="line.130"></a>
+<span class="sourceLineNo">131</span>      Chunk c = 
getNewExternalChunk(size);<a name="line.131"></a>
+<span class="sourceLineNo">132</span>      int allocOffset = c.alloc(size);<a 
name="line.132"></a>
+<span class="sourceLineNo">133</span>      return copyToChunkCell(cell, 
c.getData(), allocOffset, size);<a name="line.133"></a>
+<span class="sourceLineNo">134</span>    }<a name="line.134"></a>
+<span class="sourceLineNo">135</span>  }<a name="line.135"></a>
+<span class="sourceLineNo">136</span><a name="line.136"></a>
+<span class="sourceLineNo">137</span>  private Cell copyCellInto(Cell cell, 
int maxAlloc) {<a name="line.137"></a>
+<span class="sourceLineNo">138</span>    int size = cell instanceof 
ExtendedCell? ((ExtendedCell)cell).getSerializedSize():<a name="line.138"></a>
+<span class="sourceLineNo">139</span>        KeyValueUtil.length(cell);<a 
name="line.139"></a>
+<span class="sourceLineNo">140</span>    Preconditions.checkArgument(size 
&gt;= 0, "negative size");<a name="line.140"></a>
+<span class="sourceLineNo">141</span>    // Callers should satisfy large 
allocations directly from JVM since they<a name="line.141"></a>
+<span class="sourceLineNo">142</span>    // don't cause fragmentation as 
badly.<a name="line.142"></a>
+<span class="sourceLineNo">143</span>    if (size &gt; maxAlloc) {<a 
name="line.143"></a>
+<span class="sourceLineNo">144</span>      return null;<a name="line.144"></a>
+<span class="sourceLineNo">145</span>    }<a name="line.145"></a>
+<span class="sourceLineNo">146</span>    Chunk c = null;<a name="line.146"></a>
+<span class="sourceLineNo">147</span>    int allocOffset = 0;<a 
name="line.147"></a>
+<span class="sourceLineNo">148</span>    while (true) {<a name="line.148"></a>
+<span class="sourceLineNo">149</span>      // Try to get the chunk<a 
name="line.149"></a>
+<span class="sourceLineNo">150</span>      c = getOrMakeChunk();<a 
name="line.150"></a>
+<span class="sourceLineNo">151</span>      // we may get null because the some 
other thread succeeded in getting the lock<a name="line.151"></a>
+<span class="sourceLineNo">152</span>      // and so the current thread has to 
try again to make its chunk or grab the chunk<a name="line.152"></a>
+<span class="sourceLineNo">153</span>      // that the other thread created<a 
name="line.153"></a>
+<span class="sourceLineNo">154</span>      // Try to allocate from this 
chunk<a name="line.154"></a>
+<span class="sourceLineNo">155</span>      if (c != null) {<a 
name="line.155"></a>
+<span class="sourceLineNo">156</span>        allocOffset = c.alloc(size);<a 
name="line.156"></a>
+<span class="sourceLineNo">157</span>        if (allocOffset != -1) {<a 
name="line.157"></a>
+<span class="sourceLineNo">158</span>          // We succeeded - this is the 
common case - small alloc<a name="line.158"></a>
+<span class="sourceLineNo">159</span>          // from a big buffer<a 
name="line.159"></a>
+<span class="sourceLineNo">160</span>          break;<a name="line.160"></a>
+<span class="sourceLineNo">161</span>        }<a name="line.161"></a>
+<span class="sourceLineNo">162</span>        // not enough space!<a 
name="line.162"></a>
+<span class="sourceLineNo">163</span>        // try to retire this chunk<a 
name="line.163"></a>
+<span class="sourceLineNo">164</span>        tryRetireChunk(c);<a 
name="line.164"></a>
+<span class="sourceLineNo">165</span>      }<a name="line.165"></a>
+<span class="sourceLineNo">166</span>    }<a name="line.166"></a>
+<span class="sourceLineNo">167</span>    return copyToChunkCell(cell, 
c.getData(), allocOffset, size);<a name="line.167"></a>
+<span class="sourceLineNo">168</span>  }<a name="line.168"></a>
+<span class="sourceLineNo">169</span><a name="line.169"></a>
+<span class="sourceLineNo">170</span>  /**<a name="line.170"></a>
+<span class="sourceLineNo">171</span>   * Clone the passed cell by copying its 
data into the passed buf and create a cell with a chunkid<a name="line.171"></a>
+<span class="sourceLineNo">172</span>   * out of it<a name="line.172"></a>
+<span class="sourceLineNo">173</span>   */<a name="line.173"></a>
+<span class="sourceLineNo">174</span>  private static Cell 
copyToChunkCell(Cell cell, ByteBuffer buf, int offset, int len) {<a 
name="line.174"></a>
+<span class="sourceLineNo">175</span>    int tagsLen = cell.getTagsLength();<a 
name="line.175"></a>
+<span class="sourceLineNo">176</span>    if (cell instanceof ExtendedCell) {<a 
name="line.176"></a>
+<span class="sourceLineNo">177</span>      ((ExtendedCell) cell).write(buf, 
offset);<a name="line.177"></a>
+<span class="sourceLineNo">178</span>    } else {<a name="line.178"></a>
+<span class="sourceLineNo">179</span>      // Normally all Cell impls within 
Server will be of type ExtendedCell. Just considering the<a name="line.179"></a>
+<span class="sourceLineNo">180</span>      // other case also. The data 
fragments within Cell is copied into buf as in KeyValue<a name="line.180"></a>
+<span class="sourceLineNo">181</span>      // serialization format only.<a 
name="line.181"></a>
+<span class="sourceLineNo">182</span>      KeyValueUtil.appendTo(cell, buf, 
offset, true);<a name="line.182"></a>
+<span class="sourceLineNo">183</span>    }<a name="line.183"></a>
+<span class="sourceLineNo">184</span>    // TODO : write the seqid here. For 
writing seqId we should create a new cell type so<a name="line.184"></a>
+<span class="sourceLineNo">185</span>    // that seqId is not used as the 
state<a name="line.185"></a>
+<span class="sourceLineNo">186</span>    if (tagsLen == 0) {<a 
name="line.186"></a>
+<span class="sourceLineNo">187</span>      // When tagsLen is 0, make a 
NoTagsByteBufferKeyValue version. This is an optimized class<a 
name="line.187"></a>
+<span class="sourceLineNo">188</span>      // which directly return tagsLen as 
0. So we avoid parsing many length components in<a name="line.188"></a>
+<span class="sourceLineNo">189</span>      // reading the tagLength stored in 
the backing buffer. The Memstore addition of every Cell<a name="line.189"></a>
+<span class="sourceLineNo">190</span>      // call getTagsLength().<a 
name="line.190"></a>
+<span class="sourceLineNo">191</span>      return new 
NoTagByteBufferChunkKeyValue(buf, offset, len, cell.getSequenceId());<a 
name="line.191"></a>
+<span class="sourceLineNo">192</span>    } else {<a name="line.192"></a>
+<span class="sourceLineNo">193</span>      return new 
ByteBufferChunkKeyValue(buf, offset, len, cell.getSequenceId());<a 
name="line.193"></a>
+<span class="sourceLineNo">194</span>    }<a name="line.194"></a>
+<span class="sourceLineNo">195</span>  }<a name="line.195"></a>
+<span class="sourceLineNo">196</span><a name="line.196"></a>
+<span class="sourceLineNo">197</span>  /**<a name="line.197"></a>
+<span class="sourceLineNo">198</span>   * Close this instance since it won't 
be used any more, try to put the chunks<a name="line.198"></a>
+<span class="sourceLineNo">199</span>   * back to pool<a name="line.199"></a>
+<span class="sourceLineNo">200</span>   */<a name="line.200"></a>
+<span class="sourceLineNo">201</span>  @Override<a name="line.201"></a>
+<span class="sourceLineNo">202</span>  public void close() {<a 
name="line.202"></a>
+<span class="sourceLineNo">203</span>    this.closed = true;<a 
name="line.203"></a>
+<span class="sourceLineNo">204</span>    // We could put back the chunks to 
pool for reusing only when there is no<a name="line.204"></a>
+<span class="sourceLineNo">205</span>    // opening scanner which will read 
their data<a name="line.205"></a>
+<span class="sourceLineNo">206</span>    int count  = 
openScannerCount.get();<a name="line.206"></a>
+<span class="sourceLineNo">207</span>    if(count == 0) {<a 
name="line.207"></a>
+<span class="sourceLineNo">208</span>      recycleChunks();<a 
name="line.208"></a>
+<span class="sourceLineNo">209</span>    }<a name="line.209"></a>
+<span class="sourceLineNo">210</span>  }<a name="line.210"></a>
+<span class="sourceLineNo">211</span><a name="line.211"></a>
+<span class="sourceLineNo">212</span>  /**<a name="line.212"></a>
+<span class="sourceLineNo">213</span>   * Called when opening a scanner on the 
data of this MemStoreLAB<a name="line.213"></a>
+<span class="sourceLineNo">214</span>   */<a name="line.214"></a>
+<span class="sourceLineNo">215</span>  @Override<a name="line.215"></a>
+<span class="sourceLineNo">216</span>  public void incScannerCount() {<a 
name="line.216"></a>
+<span class="sourceLineNo">217</span>    
this.openScannerCount.incrementAndGet();<a name="line.217"></a>
+<span class="sourceLineNo">218</span>  }<a name="line.218"></a>
+<span class="sourceLineNo">219</span><a name="line.219"></a>
+<span class="sourceLineNo">220</span>  /**<a name="line.220"></a>
+<span class="sourceLineNo">221</span>   * Called when closing a scanner on the 
data of this MemStoreLAB<a name="line.221"></a>
+<span class="sourceLineNo">222</span>   */<a name="line.222"></a>
+<span class="sourceLineNo">223</span>  @Override<a name="line.223"></a>
+<span class="sourceLineNo">224</span>  public void decScannerCount() {<a 
name="line.224"></a>
+<span class="sourceLineNo">225</span>    int count = 
this.openScannerCount.decrementAndGet();<a name="line.225"></a>
+<span class="sourceLineNo">226</span>    if (this.closed &amp;&amp; count == 
0) {<a name="line.226"></a>
+<span class="sourceLineNo">227</span>      recycleChunks();<a 
name="line.227"></a>
+<span class="sourceLineNo">228</span>    }<a name="line.228"></a>
+<span class="sourceLineNo">229</span>  }<a name="line.229"></a>
+<span class="sourceLineNo">230</span><a name="line.230"></a>
+<span class="sourceLineNo">231</span>  private void recycleChunks() {<a 
name="line.231"></a>
+<span class="sourceLineNo">232</span>    if (reclaimed.compareAndSet(false, 
true)) {<a name="line.232"></a>
+<span class="sourceLineNo">233</span>      
chunkCreator.putbackChunks(chunks);<a name="line.233"></a>
+<span class="sourceLineNo">234</span>    }<a name="line.234"></a>
+<span class="sourceLineNo">235</span>  }<a name="line.235"></a>
+<span class="sourceLineNo">236</span><a name="line.236"></a>
+<span class="sourceLineNo">237</span>  /**<a name="line.237"></a>
+<span class="sourceLineNo">238</span>   * Try to retire the current chunk if 
it is still<a name="line.238"></a>
+<span class="sourceLineNo">239</span>   * &lt;code&gt;c&lt;/code&gt;. 
Postcondition is that curChunk.get()<a name="line.239"></a>
+<span class="sourceLineNo">240</span>   * != c<a name="line.240"></a>
+<span class="sourceLineNo">241</span>   * @param c the chunk to retire<a 
name="line.241"></a>
+<span class="sourceLineNo">242</span>   * @return true if we won the race to 
retire the chunk<a name="line.242"></a>
+<span class="sourceLineNo">243</span>   */<a name="line.243"></a>
+<span class="sourceLineNo">244</span>  private void tryRetireChunk(Chunk c) 
{<a name="line.244"></a>
+<span class="sourceLineNo">245</span>    currChunk.compareAndSet(c, null);<a 
name="line.245"></a>
+<span class="sourceLineNo">246</span>    // If the CAS succeeds, that means 
that we won the race<a name="line.246"></a>
+<span class="sourceLineNo">247</span>    // to retire the chunk. We could use 
this opportunity to<a name="line.247"></a>
+<span class="sourceLineNo">248</span>    // update metrics on external 
fragmentation.<a name="line.248"></a>
+<span class="sourceLineNo">249</span>    //<a name="line.249"></a>
+<span class="sourceLineNo">250</span>    // If the CAS fails, that means that 
someone else already<a name="line.250"></a>
+<span class="sourceLineNo">251</span>    // retired the chunk for us.<a 
name="line.251"></a>
+<span class="sourceLineNo">252</span>  }<a name="line.252"></a>
+<span class="sourceLineNo">253</span><a name="line.253"></a>
+<span class="sourceLineNo">254</span>  /**<a name="line.254"></a>
+<span class="sourceLineNo">255</span>   * Get the current chunk, or, if there 
is no current chunk,<a name="line.255"></a>
+<span class="sourceLineNo">256</span>   * allocate a new one from the JVM.<a 
name="line.256"></a>
+<span class="sourceLineNo">257</span>   */<a name="line.257"></a>
+<span class="sourceLineNo">258</span>  private Chunk getOrMakeChunk() {<a 
name="line.258"></a>
+<span class="sourceLineNo">259</span>    // Try to get the chunk<a 
name="line.259"></a>
+<span class="sourceLineNo">260</span>    Chunk c = currChunk.get();<a 
name="line.260"></a>
+<span class="sourceLineNo">261</span>    if (c != null) {<a 
name="line.261"></a>
+<span class="sourceLineNo">262</span>      return c;<a name="line.262"></a>
+<span class="sourceLineNo">263</span>    }<a name="line.263"></a>
+<span class="sourceLineNo">264</span>    // No current chunk, so we want to 
allocate one. We race<a name="line.264"></a>
+<span class="sourceLineNo">265</span>    // against other allocators to CAS in 
an uninitialized chunk<a name="line.265"></a>
+<span class="sourceLineNo">266</span>    // (which is cheap to allocate)<a 
name="line.266"></a>
+<span class="sourceLineNo">267</span>    if (lock.tryLock()) {<a 
name="line.267"></a>
+<span class="sourceLineNo">268</span>      try {<a name="line.268"></a>
+<span class="sourceLineNo">269</span>        // once again check inside the 
lock<a name="line.269"></a>
+<span class="sourceLineNo">270</span>        c = currChunk.get();<a 
name="line.270"></a>
+<span class="sourceLineNo">271</span>        if (c != null) {<a 
name="line.271"></a>
+<span class="sourceLineNo">272</span>          return c;<a name="line.272"></a>
+<span class="sourceLineNo">273</span>        }<a name="line.273"></a>
+<span class="sourceLineNo">274</span>        c = 
this.chunkCreator.getChunk(idxType);<a name="line.274"></a>
+<span class="sourceLineNo">275</span>        if (c != null) {<a 
name="line.275"></a>
+<span class="sourceLineNo">276</span>          // set the curChunk. No need of 
CAS as only one thread will be here<a name="line.276"></a>
+<span class="sourceLineNo">277</span>          currChunk.set(c);<a 
name="line.277"></a>
+<span class="sourceLineNo">278</span>          chunks.add(c.getId());<a 
name="line.278"></a>
+<span class="sourceLineNo">279</span>          return c;<a name="line.279"></a>
+<span class="sourceLineNo">280</span>        }<a name="line.280"></a>
+<span class="sourceLineNo">281</span>      } finally {<a name="line.281"></a>
+<span class="sourceLineNo">282</span>        lock.unlock();<a 
name="line.282"></a>
+<span class="sourceLineNo">283</span>      }<a name="line.283"></a>
+<span class="sourceLineNo">284</span>    }<a name="line.284"></a>
+<span class="sourceLineNo">285</span>    return null;<a name="line.285"></a>
+<span class="sourceLineNo">286</span>  }<a name="line.286"></a>
+<span class="sourceLineNo">287</span><a name="line.287"></a>
+<span class="sourceLineNo">288</span>  /* Returning a new pool chunk, without 
replacing current chunk,<a name="line.288"></a>
+<span class="sourceLineNo">289</span>  ** meaning MSLABImpl does not make the 
returned chunk as CurChunk.<a name="line.289"></a>
+<span class="sourceLineNo">290</span>  ** The space on this chunk will be 
allocated externally.<a name="line.290"></a>
+<span class="sourceLineNo">291</span>  ** The interface is only for external 
callers.<a name="line.291"></a>
+<span class="sourceLineNo">292</span>  */<a name="line.292"></a>
+<span class="sourceLineNo">293</span>  @Override<a name="line.293"></a>
+<span class="sourceLineNo">294</span>  public Chunk 
getNewExternalChunk(ChunkCreator.ChunkType chunkType) {<a name="line.294"></a>
+<span class="sourceLineNo">295</span>    switch (chunkType) {<a 
name="line.295"></a>
+<span class="sourceLineNo">296</span>      case INDEX_CHUNK:<a 
name="line.296"></a>
+<span class="sourceLineNo">297</span>      case DATA_CHUNK:<a 
name="line.297"></a>
+<span class="sourceLineNo">298</span>        Chunk c = 
this.chunkCreator.getChunk(chunkType);<a name="line.298"></a>
+<span class="sourceLineNo">299</span>        chunks.add(c.getId());<a 
name="line.299"></a>
+<span class="sourceLineNo">300</span>        return c;<a name="line.300"></a>
+<span class="sourceLineNo">301</span>      case JUMBO_CHUNK: // a jumbo chunk 
doesn't have a fixed size<a name="line.301"></a>
+<span class="sourceLineNo">302</span>      default:<a name="line.302"></a>
+<span class="sourceLineNo">303</span>        return null;<a 
name="line.303"></a>
+<span class="sourceLineNo">304</span>    }<a name="line.304"></a>
+<span class="sourceLineNo">305</span>  }<a name="line.305"></a>
+<span class="sourceLineNo">306</span><a name="line.306"></a>
+<span class="sourceLineNo">307</span>  /* Returning a new chunk, without 
replacing current chunk,<a name="line.307"></a>
+<span class="sourceLineNo">308</span>  ** meaning MSLABImpl does not make the 
returned chunk as CurChunk.<a name="line.308"></a>
+<span class="sourceLineNo">309</span>  ** The space on this chunk will be 
allocated externally.<a name="line.309"></a>
+<span class="sourceLineNo">310</span>  ** The interface is only for external 
callers.<a name="line.310"></a>
+<span class="sourceLineNo">311</span>  ** Chunks from pools are not allocated 
from here, since they have fixed sizes<a name="line.311"></a>
+<span class="sourceLineNo">312</span>  */<a name="line.312"></a>
+<span class="sourceLineNo">313</span>  @Override<a name="line.313"></a>
+<span class="sourceLineNo">314</span>  public Chunk getNewExternalChunk(int 
size) {<a name="line.314"></a>
+<span class="sourceLineNo">315</span>    int allocSize = size + 
ChunkCreator.getInstance().SIZEOF_CHUNK_HEADER;<a name="line.315"></a>
+<span class="sourceLineNo">316</span>    if (allocSize &lt;= 
ChunkCreator.getInstance().getChunkSize()) {<a name="line.316"></a>
+<span class="sourceLineNo">317</span>      return 
getNewExternalChunk(ChunkCreator.ChunkType.DATA_CHUNK);<a name="line.317"></a>
+<span class="sourceLineNo">318</span>    } else {<a name="line.318"></a>
+<span class="sourceLineNo">319</span>      Chunk c = 
this.chunkCreator.getJumboChunk(size);<a name="line.319"></a>
+<span class="sourceLineNo">320</span>      chunks.add(c.getId());<a 
name="line.320"></a>
+<span class="sourceLineNo">321</span>      return c;<a name="line.321"></a>
+<span class="sourceLineNo">322</span>    }<a name="line.322"></a>
+<span class="sourceLineNo">323</span>  }<a name="line.323"></a>
+<span class="sourceLineNo">324</span><a name="line.324"></a>
+<span class="sourceLineNo">325</span>  @Override<a name="line.325"></a>
+<span class="sourceLineNo">326</span>  public boolean isOnHeap() {<a 
name="line.326"></a>
+<span class="sourceLineNo">327</span>    return !isOffHeap();<a 
name="line.327"></a>
+<span class="sourceLineNo">328</span>  }<a name="line.328"></a>
+<span class="sourceLineNo">329</span><a name="line.329"></a>
+<span class="sourceLineNo">330</span>  @Override<a name="line.330"></a>
+<span class="sourceLineNo">331</span>  public boolean isOffHeap() {<a 
name="line.331"></a>
+<span class="sourceLineNo">332</span>    return 
this.chunkCreator.isOffheap();<a name="line.332"></a>
+<span class="sourceLineNo">333</span>  }<a name="line.333"></a>
+<span class="sourceLineNo">334</span><a name="line.334"></a>
+<span class="sourceLineNo">335</span>  @VisibleForTesting<a 
name="line.335"></a>
+<span class="sourceLineNo">336</span>  Chunk getCurrentChunk() {<a 
name="line.336"></a>
+<span class="sourceLineNo">337</span>    return currChunk.get();<a 
name="line.337"></a>
+<span class="sourceLineNo">338</span>  }<a name="line.338"></a>
+<span class="sourceLineNo">339</span><a name="line.339"></a>
+<span class="sourceLineNo">340</span>  @VisibleForTesting<a 
name="line.340"></a>
+<span class="sourceLineNo">341</span>  BlockingQueue&lt;Chunk&gt; 
getPooledChunks() {<a name="line.341"></a>
+<span class="sourceLineNo">342</span>    BlockingQueue&lt;Chunk&gt; 
pooledChunks = new LinkedBlockingQueue&lt;&gt;();<a name="line.342"></a>
+<span class="sourceLineNo">343</span>    for (Integer id : this.chunks) {<a 
name="line.343"></a>
+<span class="sourceLineNo">344</span>      Chunk chunk = 
chunkCreator.getChunk(id);<a name="line.344"></a>
+<span class="sourceLineNo">345</span>      if (chunk != null &amp;&amp; 
chunk.isFromPool()) {<a name="line.345"></a>
+<span class="sourceLineNo">346</span>        pooledChunks.add(chunk);<a 
name="line.346"></a>
+<span class="sourceLineNo">347</span>      }<a name="line.347"></a>
+<span class="sourceLineNo">348</span>    }<a name="line.348"></a>
+<span class="sourceLineNo">349</span>    return pooledChunks;<a 
name="line.349"></a>
+<span class="sourceLineNo">350</span>  }<a name="line.350"></a>
+<span class="sourceLineNo">351</span><a name="line.351"></a>
+<span class="sourceLineNo">352</span>  @VisibleForTesting Integer 
getNumOfChunksReturnedToPool() {<a name="line.352"></a>
+<span class="sourceLineNo">353</span>    int i = 0;<a name="line.353"></a>
+<span class="sourceLineNo">354</span>    for (Integer id : this.chunks) {<a 
name="line.354"></a>
+<span class="sourceLineNo">355</span>      if (chunkCreator.isChunkInPool(id)) 
{<a name="line.355"></a>
+<span class="sourceLineNo">356</span>        i++;<a name="line.356"></a>
+<span class="sourceLineNo">357</span>      }<a name="line.357"></a>
+<span class="sourceLineNo">358</span>    }<a name="line.358"></a>
+<span class="sourceLineNo">359</span>    return i;<a name="line.359"></a>
+<span class="sourceLineNo">360</span>  }<a name="line.360"></a>
+<span class="sourceLineNo">361</span>}<a name="line.361"></a>
 
 
 

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/883dde2f/devapidocs/src-html/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.PeerRegionServerListener.html
----------------------------------------------------------------------
diff --git 
a/devapidocs/src-html/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.PeerRegionServerListener.html
 
b/devapidocs/src-html/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.PeerRegionServerListener.html
index a588fcf..098dc5e 100644
--- 
a/devapidocs/src-html/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.PeerRegionServerListener.html
+++ 
b/devapidocs/src-html/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.PeerRegionServerListener.html
@@ -51,197 +51,208 @@
 <span class="sourceLineNo">043</span> * target cluster is an HBase cluster.<a 
name="line.43"></a>
 <span class="sourceLineNo">044</span> */<a name="line.44"></a>
 <span class="sourceLineNo">045</span>@InterfaceAudience.Private<a 
name="line.45"></a>
-<span 
class="sourceLineNo">046</span>@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="MT_CORRECTNESS",<a
 name="line.46"></a>
-<span class="sourceLineNo">047</span>  justification="Thinks zkw needs to be 
synchronized access but should be fine as is.")<a name="line.47"></a>
-<span class="sourceLineNo">048</span>public abstract class 
HBaseReplicationEndpoint extends BaseReplicationEndpoint<a name="line.48"></a>
-<span class="sourceLineNo">049</span>  implements Abortable {<a 
name="line.49"></a>
+<span class="sourceLineNo">046</span>public abstract class 
HBaseReplicationEndpoint extends BaseReplicationEndpoint<a name="line.46"></a>
+<span class="sourceLineNo">047</span>  implements Abortable {<a 
name="line.47"></a>
+<span class="sourceLineNo">048</span><a name="line.48"></a>
+<span class="sourceLineNo">049</span>  private static final Logger LOG = 
LoggerFactory.getLogger(HBaseReplicationEndpoint.class);<a name="line.49"></a>
 <span class="sourceLineNo">050</span><a name="line.50"></a>
-<span class="sourceLineNo">051</span>  private static final Logger LOG = 
LoggerFactory.getLogger(HBaseReplicationEndpoint.class);<a name="line.51"></a>
-<span class="sourceLineNo">052</span><a name="line.52"></a>
-<span class="sourceLineNo">053</span>  private ZKWatcher zkw = null; // 
FindBugs: MT_CORRECTNESS<a name="line.53"></a>
-<span class="sourceLineNo">054</span><a name="line.54"></a>
-<span class="sourceLineNo">055</span>  private List&lt;ServerName&gt; 
regionServers = new ArrayList&lt;&gt;(0);<a name="line.55"></a>
-<span class="sourceLineNo">056</span>  private long lastRegionServerUpdate;<a 
name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span>  protected void disconnect() {<a 
name="line.58"></a>
-<span class="sourceLineNo">059</span>    if (zkw != null) {<a 
name="line.59"></a>
-<span class="sourceLineNo">060</span>      zkw.close();<a name="line.60"></a>
-<span class="sourceLineNo">061</span>    }<a name="line.61"></a>
-<span class="sourceLineNo">062</span>  }<a name="line.62"></a>
-<span class="sourceLineNo">063</span><a name="line.63"></a>
-<span class="sourceLineNo">064</span>  /**<a name="line.64"></a>
-<span class="sourceLineNo">065</span>   * A private method used to 
re-establish a zookeeper session with a peer cluster.<a name="line.65"></a>
-<span class="sourceLineNo">066</span>   * @param ke<a name="line.66"></a>
-<span class="sourceLineNo">067</span>   */<a name="line.67"></a>
-<span class="sourceLineNo">068</span>  protected void 
reconnect(KeeperException ke) {<a name="line.68"></a>
-<span class="sourceLineNo">069</span>    if (ke instanceof 
ConnectionLossException || ke instanceof SessionExpiredException<a 
name="line.69"></a>
-<span class="sourceLineNo">070</span>        || ke instanceof 
AuthFailedException) {<a name="line.70"></a>
-<span class="sourceLineNo">071</span>      String clusterKey = 
ctx.getPeerConfig().getClusterKey();<a name="line.71"></a>
-<span class="sourceLineNo">072</span>      LOG.warn("Lost the ZooKeeper 
connection for peer " + clusterKey, ke);<a name="line.72"></a>
-<span class="sourceLineNo">073</span>      try {<a name="line.73"></a>
-<span class="sourceLineNo">074</span>        reloadZkWatcher();<a 
name="line.74"></a>
-<span class="sourceLineNo">075</span>      } catch (IOException io) {<a 
name="line.75"></a>
-<span class="sourceLineNo">076</span>        LOG.warn("Creation of 
ZookeeperWatcher failed for peer " + clusterKey, io);<a name="line.76"></a>
-<span class="sourceLineNo">077</span>      }<a name="line.77"></a>
-<span class="sourceLineNo">078</span>    }<a name="line.78"></a>
-<span class="sourceLineNo">079</span>  }<a name="line.79"></a>
-<span class="sourceLineNo">080</span><a name="line.80"></a>
-<span class="sourceLineNo">081</span>  @Override<a name="line.81"></a>
-<span class="sourceLineNo">082</span>  public void start() {<a 
name="line.82"></a>
-<span class="sourceLineNo">083</span>    startAsync();<a name="line.83"></a>
-<span class="sourceLineNo">084</span>  }<a name="line.84"></a>
-<span class="sourceLineNo">085</span><a name="line.85"></a>
-<span class="sourceLineNo">086</span>  @Override<a name="line.86"></a>
-<span class="sourceLineNo">087</span>  public void stop() {<a 
name="line.87"></a>
-<span class="sourceLineNo">088</span>    stopAsync();<a name="line.88"></a>
-<span class="sourceLineNo">089</span>  }<a name="line.89"></a>
-<span class="sourceLineNo">090</span><a name="line.90"></a>
-<span class="sourceLineNo">091</span>  @Override<a name="line.91"></a>
-<span class="sourceLineNo">092</span>  protected void doStart() {<a 
name="line.92"></a>
-<span class="sourceLineNo">093</span>    try {<a name="line.93"></a>
-<span class="sourceLineNo">094</span>      reloadZkWatcher();<a 
name="line.94"></a>
-<span class="sourceLineNo">095</span>      notifyStarted();<a 
name="line.95"></a>
-<span class="sourceLineNo">096</span>    } catch (IOException e) {<a 
name="line.96"></a>
-<span class="sourceLineNo">097</span>      notifyFailed(e);<a 
name="line.97"></a>
-<span class="sourceLineNo">098</span>    }<a name="line.98"></a>
-<span class="sourceLineNo">099</span>  }<a name="line.99"></a>
-<span class="sourceLineNo">100</span><a name="line.100"></a>
-<span class="sourceLineNo">101</span>  @Override<a name="line.101"></a>
-<span class="sourceLineNo">102</span>  protected void doStop() {<a 
name="line.102"></a>
-<span class="sourceLineNo">103</span>    disconnect();<a name="line.103"></a>
-<span class="sourceLineNo">104</span>    notifyStopped();<a 
name="line.104"></a>
-<span class="sourceLineNo">105</span>  }<a name="line.105"></a>
-<span class="sourceLineNo">106</span><a name="line.106"></a>
-<span class="sourceLineNo">107</span>  @Override<a name="line.107"></a>
-<span class="sourceLineNo">108</span>  // Synchronize peer cluster connection 
attempts to avoid races and rate<a name="line.108"></a>
-<span class="sourceLineNo">109</span>  // limit connections when multiple 
replication sources try to connect to<a name="line.109"></a>
-<span class="sourceLineNo">110</span>  // the peer cluster. If the peer 
cluster is down we can get out of control<a name="line.110"></a>
-<span class="sourceLineNo">111</span>  // over time.<a name="line.111"></a>
-<span class="sourceLineNo">112</span>  public synchronized UUID getPeerUUID() 
{<a name="line.112"></a>
-<span class="sourceLineNo">113</span>    UUID peerUUID = null;<a 
name="line.113"></a>
-<span class="sourceLineNo">114</span>    try {<a name="line.114"></a>
-<span class="sourceLineNo">115</span>      peerUUID = 
ZKClusterId.getUUIDForCluster(zkw);<a name="line.115"></a>
-<span class="sourceLineNo">116</span>    } catch (KeeperException ke) {<a 
name="line.116"></a>
-<span class="sourceLineNo">117</span>      reconnect(ke);<a 
name="line.117"></a>
-<span class="sourceLineNo">118</span>    }<a name="line.118"></a>
-<span class="sourceLineNo">119</span>    return peerUUID;<a 
name="line.119"></a>
-<span class="sourceLineNo">120</span>  }<a name="line.120"></a>
-<span class="sourceLineNo">121</span><a name="line.121"></a>
-<span class="sourceLineNo">122</span>  /**<a name="line.122"></a>
-<span class="sourceLineNo">123</span>   * Get the ZK connection to this peer<a 
name="line.123"></a>
-<span class="sourceLineNo">124</span>   * @return zk connection<a 
name="line.124"></a>
-<span class="sourceLineNo">125</span>   */<a name="line.125"></a>
-<span class="sourceLineNo">126</span>  protected ZKWatcher getZkw() {<a 
name="line.126"></a>
-<span class="sourceLineNo">127</span>    return zkw;<a name="line.127"></a>
-<span class="sourceLineNo">128</span>  }<a name="line.128"></a>
-<span class="sourceLineNo">129</span><a name="line.129"></a>
-<span class="sourceLineNo">130</span>  /**<a name="line.130"></a>
-<span class="sourceLineNo">131</span>   * Closes the current ZKW (if not null) 
and creates a new one<a name="line.131"></a>
-<span class="sourceLineNo">132</span>   * @throws IOException If anything goes 
wrong connecting<a name="line.132"></a>
-<span class="sourceLineNo">133</span>   */<a name="line.133"></a>
-<span class="sourceLineNo">134</span>  void reloadZkWatcher() throws 
IOException {<a name="line.134"></a>
-<span class="sourceLineNo">135</span>    if (zkw != null) zkw.close();<a 
name="line.135"></a>
-<span class="sourceLineNo">136</span>    zkw = new 
ZKWatcher(ctx.getConfiguration(),<a name="line.136"></a>
-<span class="sourceLineNo">137</span>        "connection to cluster: " + 
ctx.getPeerId(), this);<a name="line.137"></a>
-<span class="sourceLineNo">138</span>    getZkw().registerListener(new 
PeerRegionServerListener(this));<a name="line.138"></a>
-<span class="sourceLineNo">139</span>  }<a name="line.139"></a>
-<span class="sourceLineNo">140</span><a name="line.140"></a>
-<span class="sourceLineNo">141</span>  @Override<a name="line.141"></a>
-<span class="sourceLineNo">142</span>  public void abort(String why, Throwable 
e) {<a name="line.142"></a>
-<span class="sourceLineNo">143</span>    LOG.error("The 
HBaseReplicationEndpoint corresponding to peer " + ctx.getPeerId()<a 
name="line.143"></a>
-<span class="sourceLineNo">144</span>        + " was aborted for the following 
reason(s):" + why, e);<a name="line.144"></a>
-<span class="sourceLineNo">145</span>  }<a name="line.145"></a>
-<span class="sourceLineNo">146</span><a name="line.146"></a>
-<span class="sourceLineNo">147</span>  @Override<a name="line.147"></a>
-<span class="sourceLineNo">148</span>  public boolean isAborted() {<a 
name="line.148"></a>
-<span class="sourceLineNo">149</span>    // Currently this is never "Aborted", 
we just log when the abort method is called.<a name="line.149"></a>
-<span class="sourceLineNo">150</span>    return false;<a name="line.150"></a>
-<span class="sourceLineNo">151</span>  }<a name="line.151"></a>
-<span class="sourceLineNo">152</span><a name="line.152"></a>
-<span class="sourceLineNo">153</span>  /**<a name="line.153"></a>
-<span class="sourceLineNo">154</span>   * Get the list of all the region 
servers from the specified peer<a name="line.154"></a>
-<span class="sourceLineNo">155</span>   * @param zkw zk connection to use<a 
name="line.155"></a>
-<span class="sourceLineNo">156</span>   * @return list of region server 
addresses or an empty list if the slave is unavailable<a name="line.156"></a>
-<span class="sourceLineNo">157</span>   */<a name="line.157"></a>
-<span class="sourceLineNo">158</span>  protected static List&lt;ServerName&gt; 
fetchSlavesAddresses(ZKWatcher zkw)<a name="line.158"></a>
-<span class="sourceLineNo">159</span>      throws KeeperException {<a 
name="line.159"></a>
-<span class="sourceLineNo">160</span>    List&lt;String&gt; children = 
ZKUtil.listChildrenAndWatchForNewChildren(zkw, zkw.znodePaths.rsZNode);<a 
name="line.160"></a>
-<span class="sourceLineNo">161</span>    if (children == null) {<a 
name="line.161"></a>
-<span class="sourceLineNo">162</span>      return Collections.emptyList();<a 
name="line.162"></a>
-<span class="sourceLineNo">163</span>    }<a name="line.163"></a>
-<span class="sourceLineNo">164</span>    List&lt;ServerName&gt; addresses = 
new ArrayList&lt;&gt;(children.size());<a name="line.164"></a>
-<span class="sourceLineNo">165</span>    for (String child : children) {<a 
name="line.165"></a>
-<span class="sourceLineNo">166</span>      
addresses.add(ServerName.parseServerName(child));<a name="line.166"></a>
-<span class="sourceLineNo">167</span>    }<a name="line.167"></a>
-<span class="sourceLineNo">168</span>    return addresses;<a 
name="line.168"></a>
-<span class="sourceLineNo">169</span>  }<a name="line.169"></a>
-<span class="sourceLineNo">170</span><a name="line.170"></a>
-<span class="sourceLineNo">171</span>  /**<a name="line.171"></a>
-<span class="sourceLineNo">172</span>   * Get a list of all the addresses of 
all the region servers<a name="line.172"></a>
-<span class="sourceLineNo">173</span>   * for this peer cluster<a 
name="line.173"></a>
-<span class="sourceLineNo">174</span>   * @return list of addresses<a 
name="line.174"></a>
-<span class="sourceLineNo">175</span>   */<a name="line.175"></a>
-<span class="sourceLineNo">176</span>  // Synchronize peer cluster connection 
attempts to avoid races and rate<a name="line.176"></a>
-<span class="sourceLineNo">177</span>  // limit connections when multiple 
replication sources try to connect to<a name="line.177"></a>
-<span class="sourceLineNo">178</span>  // the peer cluster. If the peer 
cluster is down we can get out of control<a name="line.178"></a>
-<span class="sourceLineNo">179</span>  // over time.<a name="line.179"></a>
-<span class="sourceLineNo">180</span>  public synchronized 
List&lt;ServerName&gt; getRegionServers() {<a name="line.180"></a>
-<span class="sourceLineNo">181</span>    try {<a name="line.181"></a>
-<span class="sourceLineNo">182</span>      
setRegionServers(fetchSlavesAddresses(this.getZkw()));<a name="line.182"></a>
-<span class="sourceLineNo">183</span>    } catch (KeeperException ke) {<a 
name="line.183"></a>
-<span class="sourceLineNo">184</span>      if (LOG.isDebugEnabled()) {<a 
name="line.184"></a>
-<span class="sourceLineNo">185</span>        LOG.debug("Fetch slaves addresses 
failed", ke);<a name="line.185"></a>
-<span class="sourceLineNo">186</span>      }<a name="line.186"></a>
-<span class="sourceLineNo">187</span>      reconnect(ke);<a 
name="line.187"></a>
-<span class="sourceLineNo">188</span>    }<a name="line.188"></a>
-<span class="sourceLineNo">189</span>    return regionServers;<a 
name="line.189"></a>
-<span class="sourceLineNo">190</span>  }<a name="line.190"></a>
-<span class="sourceLineNo">191</span><a name="line.191"></a>
-<span class="sourceLineNo">192</span>  /**<a name="line.192"></a>
-<span class="sourceLineNo">193</span>   * Set the list of region servers for 
that peer<a name="line.193"></a>
-<span class="sourceLineNo">194</span>   * @param regionServers list of 
addresses for the region servers<a name="line.194"></a>
-<span class="sourceLineNo">195</span>   */<a name="line.195"></a>
-<span class="sourceLineNo">196</span>  public synchronized void 
setRegionServers(List&lt;ServerName&gt; regionServers) {<a name="line.196"></a>
-<span class="sourceLineNo">197</span>    this.regionServers = regionServers;<a 
name="line.197"></a>
-<span class="sourceLineNo">198</span>    lastRegionServerUpdate = 
System.currentTimeMillis();<a name="line.198"></a>
-<span class="sourceLineNo">199</span>  }<a name="line.199"></a>
-<span class="sourceLineNo">200</span><a name="line.200"></a>
-<span class="sourceLineNo">201</span>  /**<a name="line.201"></a>
-<span class="sourceLineNo">202</span>   * Get the timestamp at which the last 
change occurred to the list of region servers to replicate<a 
name="line.202"></a>
-<span class="sourceLineNo">203</span>   * to.<a name="line.203"></a>
-<span class="sourceLineNo">204</span>   * @return The System.currentTimeMillis 
at the last time the list of peer region servers changed.<a name="line.204"></a>
-<span class="sourceLineNo">205</span>   */<a name="line.205"></a>
-<span class="sourceLineNo">206</span>  public long getLastRegionServerUpdate() 
{<a name="line.206"></a>
-<span class="sourceLineNo">207</span>    return lastRegionServerUpdate;<a 
name="line.207"></a>
-<span class="sourceLineNo">208</span>  }<a name="line.208"></a>
-<span class="sourceLineNo">209</span><a name="line.209"></a>
-<span class="sourceLineNo">210</span>  /**<a name="line.210"></a>
-<span class="sourceLineNo">211</span>   * Tracks changes to the list of region 
servers in a peer's cluster.<a name="line.211"></a>
-<span class="sourceLineNo">212</span>   */<a name="line.212"></a>
-<span class="sourceLineNo">213</span>  public static class 
PeerRegionServerListener extends ZKListener {<a name="line.213"></a>
-<span class="sourceLineNo">214</span><a name="line.214"></a>
-<span class="sourceLineNo">215</span>    private final 
HBaseReplicationEndpoint replicationEndpoint;<a name="line.215"></a>
-<span class="sourceLineNo">216</span>    private final String 
regionServerListNode;<a name="line.216"></a>
-<span class="sourceLineNo">217</span><a name="line.217"></a>
-<span class="sourceLineNo">218</span>    public 
PeerRegionServerListener(HBaseReplicationEndpoint replicationPeer) {<a 
name="line.218"></a>
-<span class="sourceLineNo">219</span>      super(replicationPeer.getZkw());<a 
name="line.219"></a>
-<span class="sourceLineNo">220</span>      this.replicationEndpoint = 
replicationPeer;<a name="line.220"></a>
-<span class="sourceLineNo">221</span>      this.regionServerListNode = 
replicationEndpoint.getZkw().znodePaths.rsZNode;<a name="line.221"></a>
-<span class="sourceLineNo">222</span>    }<a name="line.222"></a>
-<span class="sourceLineNo">223</span><a name="line.223"></a>
-<span class="sourceLineNo">224</span>    @Override<a name="line.224"></a>
-<span class="sourceLineNo">225</span>    public synchronized void 
nodeChildrenChanged(String path) {<a name="line.225"></a>
-<span class="sourceLineNo">226</span>      if 
(path.equals(regionServerListNode)) {<a name="line.226"></a>
-<span class="sourceLineNo">227</span>        try {<a name="line.227"></a>
-<span class="sourceLineNo">228</span>          LOG.info("Detected change to 
peer region servers, fetching updated list");<a name="line.228"></a>
-<span class="sourceLineNo">229</span>          
replicationEndpoint.setRegionServers(fetchSlavesAddresses(replicationEndpoint.getZkw()));<a
 name="line.229"></a>
-<span class="sourceLineNo">230</span>        } catch (KeeperException e) {<a 
name="line.230"></a>
-<span class="sourceLineNo">231</span>          LOG.error("Error reading slave 
addresses", e);<a name="line.231"></a>
-<span class="sourceLineNo">232</span>        }<a name="line.232"></a>
-<span class="sourceLineNo">233</span>      }<a name="line.233"></a>
-<span class="sourceLineNo">234</span>    }<a name="line.234"></a>
-<span class="sourceLineNo">235</span>  }<a name="line.235"></a>
-<span class="sourceLineNo">236</span>}<a name="line.236"></a>
+<span class="sourceLineNo">051</span>  private Object zkwLock = new 
Object();<a name="line.51"></a>
+<span class="sourceLineNo">052</span>  private ZKWatcher zkw = null;<a 
name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span>  private List&lt;ServerName&gt; 
regionServers = new ArrayList&lt;&gt;(0);<a name="line.54"></a>
+<span class="sourceLineNo">055</span>  private long lastRegionServerUpdate;<a 
name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span>  protected void disconnect() {<a 
name="line.57"></a>
+<span class="sourceLineNo">058</span>    synchronized (zkwLock) {<a 
name="line.58"></a>
+<span class="sourceLineNo">059</span>      if (zkw != null) {<a 
name="line.59"></a>
+<span class="sourceLineNo">060</span>        zkw.close();<a name="line.60"></a>
+<span class="sourceLineNo">061</span>      }<a name="line.61"></a>
+<span class="sourceLineNo">062</span>    }<a name="line.62"></a>
+<span class="sourceLineNo">063</span>  }<a name="line.63"></a>
+<span class="sourceLineNo">064</span><a name="line.64"></a>
+<span class="sourceLineNo">065</span>  /**<a name="line.65"></a>
+<span class="sourceLineNo">066</span>   * A private method used to 
re-establish a zookeeper session with a peer cluster.<a name="line.66"></a>
+<span class="sourceLineNo">067</span>   * @param ke<a name="line.67"></a>
+<span class="sourceLineNo">068</span>   */<a name="line.68"></a>
+<span class="sourceLineNo">069</span>  protected void 
reconnect(KeeperException ke) {<a name="line.69"></a>
+<span class="sourceLineNo">070</span>    if (ke instanceof 
ConnectionLossException || ke instanceof SessionExpiredException<a 
name="line.70"></a>
+<span class="sourceLineNo">071</span>        || ke instanceof 
AuthFailedException) {<a name="line.71"></a>
+<span class="sourceLineNo">072</span>      String clusterKey = 
ctx.getPeerConfig().getClusterKey();<a name="line.72"></a>
+<span class="sourceLineNo">073</span>      LOG.warn("Lost the ZooKeeper 
connection for peer " + clusterKey, ke);<a name="line.73"></a>
+<span class="sourceLineNo">074</span>      try {<a name="line.74"></a>
+<span class="sourceLineNo">075</span>        reloadZkWatcher();<a 
name="line.75"></a>
+<span class="sourceLineNo">076</span>      } catch (IOException io) {<a 
name="line.76"></a>
+<span class="sourceLineNo">077</span>        LOG.warn("Creation of 
ZookeeperWatcher failed for peer " + clusterKey, io);<a name="line.77"></a>
+<span class="sourceLineNo">078</span>      }<a name="line.78"></a>
+<span class="sourceLineNo">079</span>    }<a name="line.79"></a>
+<span class="sourceLineNo">080</span>  }<a name="line.80"></a>
+<span class="sourceLineNo">081</span><a name="line.81"></a>
+<span class="sourceLineNo">082</span>  @Override<a name="line.82"></a>
+<span class="sourceLineNo">083</span>  public void start() {<a 
name="line.83"></a>
+<span class="sourceLineNo">084</span>    startAsync();<a name="line.84"></a>
+<span class="sourceLineNo">085</span>  }<a name="line.85"></a>
+<span class="sourceLineNo">086</span><a name="line.86"></a>
+<span class="sourceLineNo">087</span>  @Override<a name="line.87"></a>
+<span class="sourceLineNo">088</span>  public void stop() {<a 
name="line.88"></a>
+<span class="sourceLineNo">089</span>    stopAsync();<a name="line.89"></a>
+<span class="sourceLineNo">090</span>  }<a name="line.90"></a>
+<span class="sourceLineNo">091</span><a name="line.91"></a>
+<span class="sourceLineNo">092</span>  @Override<a name="line.92"></a>
+<span class="sourceLineNo">093</span>  protected void doStart() {<a 
name="line.93"></a>
+<span class="sourceLineNo">094</span>    try {<a name="line.94"></a>
+<span class="sourceLineNo">095</span>      reloadZkWatcher();<a 
name="line.95"></a>
+<span class="sourceLineNo">096</span>      notifyStarted();<a 
name="line.96"></a>
+<span class="sourceLineNo">097</span>    } catch (IOException e) {<a 
name="line.97"></a>
+<span class="sourceLineNo">098</span>      notifyFailed(e);<a 
name="line.98"></a>
+<span class="sourceLineNo">099</span>    }<a name="line.99"></a>
+<span class="sourceLineNo">100</span>  }<a name="line.100"></a>
+<span class="sourceLineNo">101</span><a name="line.101"></a>
+<span class="sourceLineNo">102</span>  @Override<a name="line.102"></a>
+<span class="sourceLineNo">103</span>  protected void doStop() {<a 
name="line.103"></a>
+<span class="sourceLineNo">104</span>    disconnect();<a name="line.104"></a>
+<span class="sourceLineNo">105</span>    notifyStopped();<a 
name="line.105"></a>
+<span class="sourceLineNo">106</span>  }<a name="line.106"></a>
+<span class="sourceLineNo">107</span><a name="line.107"></a>
+<span class="sourceLineNo">108</span>  @Override<a name="line.108"></a>
+<span class="sourceLineNo">109</span>  // Synchronize peer cluster connection 
attempts to avoid races and rate<a name="line.109"></a>
+<span class="sourceLineNo">110</span>  // limit connections when multiple 
replication sources try to connect to<a name="line.110"></a>
+<span class="sourceLineNo">111</span>  // the peer cluster. If the peer 
cluster is down we can get out of control<a name="line.111"></a>
+<span class="sourceLineNo">112</span>  // over time.<a name="line.112"></a>
+<span class="sourceLineNo">113</span>  public synchronized UUID getPeerUUID() 
{<a name="line.113"></a>
+<span class="sourceLineNo">114</span>    UUID peerUUID = null;<a 
name="line.114"></a>
+<span class="sourceLineNo">115</span>    try {<a name="line.115"></a>
+<span class="sourceLineNo">116</span>      synchronized (zkwLock) {<a 
name="line.116"></a>
+<span class="sourceLineNo">117</span>        peerUUID = 
ZKClusterId.getUUIDForCluster(zkw);<a name="line.117"></a>
+<span class="sourceLineNo">118</span>      }<a name="line.118"></a>
+<span class="sourceLineNo">119</span>    } catch (KeeperException ke) {<a 
name="line.119"></a>
+<span class="sourceLineNo">120</span>      reconnect(ke);<a 
name="line.120"></a>
+<span class="sourceLineNo">121</span>    }<a name="line.121"></a>
+<span class="sourceLineNo">122</span>    return peerUUID;<a 
name="line.122"></a>
+<span class="sourceLineNo">123</span>  }<a name="line.123"></a>
+<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">125</span>  /**<a name="line.125"></a>
+<span class="sourceLineNo">126</span>   * Get the ZK connection to this peer<a 
name="line.126"></a>
+<span class="sourceLineNo">127</span>   * @return zk connection<a 
name="line.127"></a>
+<span class="sourceLineNo">128</span>   */<a name="line.128"></a>
+<span class="sourceLineNo">129</span>  protected ZKWatcher getZkw() {<a 
name="line.129"></a>
+<span class="sourceLineNo">130</span>    synchronized (zkwLock) {<a 
name="line.130"></a>
+<span class="sourceLineNo">131</span>      return zkw;<a name="line.131"></a>
+<span class="sourceLineNo">132</span>    }<a name="line.132"></a>
+<span class="sourceLineNo">133</span>  }<a name="line.133"></a>
+<span class="sourceLineNo">134</span><a name="line.134"></a>
+<span class="sourceLineNo">135</span>  /**<a name="line.135"></a>
+<span class="sourceLineNo">136</span>   * Closes the current ZKW (if not null) 
and creates a new one<a name="line.136"></a>
+<span class="sourceLineNo">137</span>   * @throws IOException If anything goes 
wrong connecting<a name="line.137"></a>
+<span class="sourceLineNo">138</span>   */<a name="line.138"></a>
+<span class="sourceLineNo">139</span>  void reloadZkWatcher() throws 
IOException {<a name="line.139"></a>
+<span class="sourceLineNo">140</span>    synchronized (zkwLock) {<a 
name="line.140"></a>
+<span class="sourceLineNo">141</span>      if (zkw != null) {<a 
name="line.141"></a>
+<span class="sourceLineNo">142</span>        zkw.close();<a 
name="line.142"></a>
+<span class="sourceLineNo">143</span>      }<a name="line.143"></a>
+<span class="sourceLineNo">144</span>      zkw = new 
ZKWatcher(ctx.getConfiguration(),<a name="line.144"></a>
+<span class="sourceLineNo">145</span>        "connection to cluster: " + 
ctx.getPeerId(), this);<a name="line.145"></a>
+<span class="sourceLineNo">146</span>      zkw.registerListener(new 
PeerRegionServerListener(this));<a name="line.146"></a>
+<span class="sourceLineNo">147</span>    }<a name="line.147"></a>
+<span class="sourceLineNo">148</span>  }<a name="line.148"></a>
+<span class="sourceLineNo">149</span><a name="line.149"></a>
+<span class="sourceLineNo">150</span>  @Override<a name="line.150"></a>
+<span class="sourceLineNo">151</span>  public void abort(String why, Throwable 
e) {<a name="line.151"></a>
+<span class="sourceLineNo">152</span>    LOG.error("The 
HBaseReplicationEndpoint corresponding to peer " + ctx.getPeerId()<a 
name="line.152"></a>
+<span class="sourceLineNo">153</span>        + " was aborted for the following 
reason(s):" + why, e);<a name="line.153"></a>
+<span class="sourceLineNo">154</span>  }<a name="line.154"></a>
+<span class="sourceLineNo">155</span><a name="line.155"></a>
+<span class="sourceLineNo">156</span>  @Override<a name="line.156"></a>
+<span class="sourceLineNo">157</span>  public boolean isAborted() {<a 
name="line.157"></a>
+<span class="sourceLineNo">158</span>    // Currently this is never "Aborted", 
we just log when the abort method is called.<a name="line.158"></a>
+<span class="sourceLineNo">159</span>    return false;<a name="line.159"></a>
+<span class="sourceLineNo">160</span>  }<a name="line.160"></a>
+<span class="sourceLineNo">161</span><a name="line.161"></a>
+<span class="sourceLineNo">162</span>  /**<a name="line.162"></a>
+<span class="sourceLineNo">163</span>   * Get the list of all the region 
servers from the specified peer<a name="line.163"></a>
+<span class="sourceLineNo">164</span>   * @param zkw zk connection to use<a 
name="line.164"></a>
+<span class="sourceLineNo">165</span>   * @return list of region server 
addresses or an empty list if the slave is unavailable<a name="line.165"></a>
+<span class="sourceLineNo">166</span>   */<a name="line.166"></a>
+<span class="sourceLineNo">167</span>  protected static List&lt;ServerName&gt; 
fetchSlavesAddresses(ZKWatcher zkw)<a name="line.167"></a>
+<span class="sourceLineNo">168</span>      throws KeeperException {<a 
name="line.168"></a>
+<span class="sourceLineNo">169</span>    List&lt;String&gt; children = 
ZKUtil.listChildrenAndWatchForNewChildren(zkw, zkw.znodePaths.rsZNode);<a 
name="line.169"></a>
+<span class="sourceLineNo">170</span>    if (children == null) {<a 
name="line.170"></a>
+<span class="sourceLineNo">171</span>      return Collections.emptyList();<a 
name="line.171"></a>
+<span class="sourceLineNo">172</span>    }<a name="line.172"></a>
+<span class="sourceLineNo">173</span>    List&lt;ServerName&gt; addresses = 
new ArrayList&lt;&gt;(children.size());<a name="line.173"></a>
+<span class="sourceLineNo">174</span>    for (String child : children) {<a 
name="line.174"></a>
+<span class="sourceLineNo">175</span>      
addresses.add(ServerName.parseServerName(child));<a name="line.175"></a>
+<span class="sourceLineNo">176</span>    }<a name="line.176"></a>
+<span class="sourceLineNo">177</span>    return addresses;<a 
name="line.177"></a>
+<span class="sourceLineNo">178</span>  }<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span>  /**<a name="line.180"></a>
+<span class="sourceLineNo">181</span>   * Get a list of all the addresses of 
all the region servers<a name="line.181"></a>
+<span class="sourceLineNo">182</span>   * for this peer cluster<a 
name="line.182"></a>
+<span class="sourceLineNo">183</span>   * @return list of addresses<a 
name="line.183"></a>
+<span class="sourceLineNo">184</span>   */<a name="line.184"></a>
+<span class="sourceLineNo">185</span>  public List&lt;ServerName&gt; 
getRegionServers() {<a name="line.185"></a>
+<span class="sourceLineNo">186</span>    try {<a name="line.186"></a>
+<span class="sourceLineNo">187</span>      // Synchronize peer cluster 
connection attempts to avoid races and rate<a name="line.187"></a>
+<span class="sourceLineNo">188</span>      // limit connections when multiple 
replication sources try to connect to<a name="line.188"></a>
+<span class="sourceLineNo">189</span>      // the peer cluster. If the peer 
cluster is down we can get out of control<a name="line.189"></a>
+<span class="sourceLineNo">190</span>      // over time.<a name="line.190"></a>
+<span class="sourceLineNo">191</span>      synchronized (zkwLock) {<a 
name="line.191"></a>
+<span class="sourceLineNo">192</span>        
setRegionServers(fetchSlavesAddresses(zkw));<a name="line.192"></a>
+<span class="sourceLineNo">193</span>      }<a name="line.193"></a>
+<span class="sourceLineNo">194</span>    } catch (KeeperException ke) {<a 
name="line.194"></a>
+<span class="sourceLineNo">195</span>      if (LOG.isDebugEnabled()) {<a 
name="line.195"></a>
+<span class="sourceLineNo">196</span>        LOG.debug("Fetch slaves addresses 
failed", ke);<a name="line.196"></a>
+<span class="sourceLineNo">197</span>      }<a name="line.197"></a>
+<span class="sourceLineNo">198</span>      reconnect(ke);<a 
name="line.198"></a>
+<span class="sourceLineNo">199</span>    }<a name="line.199"></a>
+<span class="sourceLineNo">200</span>    return regionServers;<a 
name="line.200"></a>
+<span class="sourceLineNo">201</span>  }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span>  /**<a name="line.203"></a>
+<span class="sourceLineNo">204</span>   * Set the list of region servers for 
that peer<a name="line.204"></a>
+<span class="sourceLineNo">205</span>   * @param regionServers list of 
addresses for the region servers<a name="line.205"></a>
+<span class="sourceLineNo">206</span>   */<a name="line.206"></a>
+<span class="sourceLineNo">207</span>  public synchronized void 
setRegionServers(List&lt;ServerName&gt; regionServers) {<a name="line.207"></a>
+<span class="sourceLineNo">208</span>    this.regionServers = regionServers;<a 
name="line.208"></a>
+<span class="sourceLineNo">209</span>    lastRegionServerUpdate = 
System.currentTimeMillis();<a name="line.209"></a>
+<span class="sourceLineNo">210</span>  }<a name="line.210"></a>
+<span class="sourceLineNo">211</span><a name="line.211"></a>
+<span class="sourceLineNo">212</span>  /**<a name="line.212"></a>
+<span class="sourceLineNo">213</span>   * Get the timestamp at which the last 
change occurred to the list of region servers to replicate<a 
name="line.213"></a>
+<span class="sourceLineNo">214</span>   * to.<a name="line.214"></a>
+<span class="sourceLineNo">215</span>   * @return The System.currentTimeMillis 
at the last time the list of peer region servers changed.<a name="line.215"></a>
+<span class="sourceLineNo">216</span>   */<a name="line.216"></a>
+<span class="sourceLineNo">217</span>  public long getLastRegionServerUpdate() 
{<a name="line.217"></a>
+<span class="sourceLineNo">218</span>    return lastRegionServerUpdate;<a 
name="line.218"></a>
+<span class="sourceLineNo">219</span>  }<a name="line.219"></a>
+<span class="sourceLineNo">220</span><a name="line.220"></a>
+<span class="sourceLineNo">221</span>  /**<a name="line.221"></a>
+<span class="sourceLineNo">222</span>   * Tracks changes to the list of region 
servers in a peer's cluster.<a name="line.222"></a>
+<span class="sourceLineNo">223</span>   */<a name="line.223"></a>
+<span class="sourceLineNo">224</span>  public static class 
PeerRegionServerListener extends ZKListener {<a name="line.224"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span>    private final 
HBaseReplicationEndpoint replicationEndpoint;<a name="line.226"></a>
+<span class="sourceLineNo">227</span>    private final String 
regionServerListNode;<a name="line.227"></a>
+<span class="sourceLineNo">228</span><a name="line.228"></a>
+<span class="sourceLineNo">229</span>    public 
PeerRegionServerListener(HBaseReplicationEndpoint replicationPeer) {<a 
name="line.229"></a>
+<span class="sourceLineNo">230</span>      super(replicationPeer.getZkw());<a 
name="line.230"></a>
+<span class="sourceLineNo">231</span>      this.replicationEndpoint = 
replicationPeer;<a name="line.231"></a>
+<span class="sourceLineNo">232</span>      this.regionServerListNode = 
replicationEndpoint.getZkw().znodePaths.rsZNode;<a name="line.232"></a>
+<span class="sourceLineNo">233</span>    }<a name="line.233"></a>
+<span class="sourceLineNo">234</span><a name="line.234"></a>
+<span class="sourceLineNo">235</span>    @Override<a name="line.235"></a>
+<span class="sourceLineNo">236</span>    public synchronized void 
nodeChildrenChanged(String path) {<a name="line.236"></a>
+<span class="sourceLineNo">237</span>      if 
(path.equals(regionServerListNode)) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span>        try {<a name="line.238"></a>
+<span class="sourceLineNo">239</span>          LOG.info("Detected change to 
peer region servers, fetching updated list");<a name="line.239"></a>
+<span class="sourceLineNo">240</span>          
replicationEndpoint.setRegionServers(fetchSlavesAddresses(replicationEndpoint.getZkw()));<a
 name="line.240"></a>
+<span class="sourceLineNo">241</span>        } catch (KeeperException e) {<a 
name="line.241"></a>
+<span class="sourceLineNo">242</span>          LOG.error("Error reading slave 
addresses", e);<a name="line.242"></a>
+<span class="sourceLineNo">243</span>        }<a name="line.243"></a>
+<span class="sourceLineNo">244</span>      }<a name="line.244"></a>
+<span class="sourceLineNo">245</span>    }<a name="line.245"></a>
+<span class="sourceLineNo">246</span>  }<a name="line.246"></a>
+<span class="sourceLineNo">247</span>}<a name="line.247"></a>
 
 
 

Reply via email to