HBASE-21610, numOpenConnections metric is set to -1 when zero server channel exist
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/78756733 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/78756733 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/78756733 Branch: refs/heads/HBASE-21512 Commit: 787567336afb9c5c1e00aaa0326566a5522a5e31 Parents: 8991877 Author: Pankaj <pankaj...@huawei.com> Authored: Tue Dec 18 01:31:55 2018 +0530 Committer: stack <st...@apache.org> Committed: Thu Dec 20 16:36:42 2018 -0800 ---------------------------------------------------------------------- .../src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/78756733/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java index 8ea2057..742a728 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java @@ -169,8 +169,9 @@ public class NettyRpcServer extends RpcServer { @Override public int getNumOpenConnections() { + int channelsCount = allChannels.size(); // allChannels also contains the server channel, so exclude that from the count. - return allChannels.size() - 1; + return channelsCount > 0 ? channelsCount - 1 : channelsCount; } @Override
