[hbase-filesystem] branch master updated: HBASE-26786 [hboss] Limit synchronization from hot path of HBoss APIs (#32)

[ankit]

This is an automated email from the ASF dual-hosted git repository.

ankit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase-filesystem.git


The following commit(s) were added to refs/heads/master by this push:
     new 773be13  HBASE-26786 [hboss] Limit synchronization from hot path of 
HBoss APIs (#32)
773be13 is described below

commit 773be136b6e2b07a061bcb656e5ed73685bf592d
Author: Ankit Singhal <ankitsingha...@gmail.com>
AuthorDate: Wed Mar 2 15:44:08 2022 -0800

    HBASE-26786 [hboss] Limit synchronization from hot path of HBoss APIs (#32)
---
 .../hadoop/hbase/oss/sync/ZKTreeLockManager.java   | 29 +++++++++++-----------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git 
a/hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
 
b/hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
index 16bd57e..66dcde4 100644
--- 
a/hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
+++ 
b/hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
@@ -20,12 +20,13 @@ package org.apache.hadoop.hbase.oss.sync;
 
 import java.io.IOException;
 import java.util.Collections;
-import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.TimeUnit;
+
 import org.apache.curator.RetryPolicy;
 import org.apache.curator.framework.CuratorFramework;
 import org.apache.curator.framework.CuratorFrameworkFactory;
@@ -70,7 +71,7 @@ public class ZKTreeLockManager extends TreeLockManager {
 
   public static final String LOCK_SUB_ZNODE = ".hboss-lock-znode";
 
-  private Map<Path,InterProcessReadWriteLock> lockCache = new HashMap<>();
+  private ConcurrentHashMap<Path,InterProcessReadWriteLock> lockCache = new 
ConcurrentHashMap<>();
 
   public void initialize(FileSystem fs) throws IOException {
     this.fs = fs;
@@ -196,7 +197,7 @@ public class ZKTreeLockManager extends TreeLockManager {
   We need to protect this block against potential concurrent calls to close()
    */
   @Override
-  protected synchronized boolean writeLockAbove(Path p) throws IOException {
+  protected boolean writeLockAbove(Path p) throws IOException {
     LOG.debug("Checking for write lock above {}", p);
     while (!p.isRoot()) {
       p = p.getParent();
@@ -242,8 +243,9 @@ public class ZKTreeLockManager extends TreeLockManager {
     }
   }
 
-  synchronized void removeInMemoryLocks(Path p) {
-    Iterator<Entry<Path,InterProcessReadWriteLock>> iter = 
lockCache.entrySet().iterator();
+  void removeInMemoryLocks(Path p) {
+    Iterator<Entry<Path, InterProcessReadWriteLock>> iter =
+        lockCache.entrySet().iterator();
     while (iter.hasNext()) {
       Entry<Path,InterProcessReadWriteLock> entry = iter.next();
       if (isBeneath(p, entry.getKey())) {
@@ -380,24 +382,23 @@ public class ZKTreeLockManager extends TreeLockManager {
     return sb.toString();
   }
 
-  public synchronized Map<Path,InterProcessReadWriteLock> 
getUnmodifiableCache() {
+  public Map<Path,InterProcessReadWriteLock> getUnmodifiableCache() {
     return Collections.unmodifiableMap(lockCache);
   }
 
-  private synchronized InterProcessReadWriteLock get(Path path) throws 
IOException {
-    if (!lockCache.containsKey(path)) {
+  private InterProcessReadWriteLock get(Path path) {
+    return lockCache.computeIfAbsent(path, s -> {
       String zkPath = new Path(path, LOCK_SUB_ZNODE).toString();
       try {
-        ZKPaths.mkdirs(curator.getZookeeperClient().getZooKeeper(), zkPath, 
true);
+        ZKPaths.mkdirs(curator.getZookeeperClient().getZooKeeper(), zkPath,
+            true);
       } catch (KeeperException.NodeExistsException e) {
         // Ignore
       } catch (Exception e) {
-        throw new IOException("Exception while ensuring lock parents exist: " +
-              path, e);
+        throw new RuntimeException(e);
       }
-      lockCache.put(path, new InterProcessReadWriteLock(curator, zkPath));
-    }
-    return lockCache.get(path);
+      return new InterProcessReadWriteLock(curator, zkPath);
+    });
   }
 }