Fix a minor issue when updating a workflowConfig with empty workflowId.
Project: http://git-wip-us.apache.org/repos/asf/helix/repo Commit: http://git-wip-us.apache.org/repos/asf/helix/commit/00f8efea Tree: http://git-wip-us.apache.org/repos/asf/helix/tree/00f8efea Diff: http://git-wip-us.apache.org/repos/asf/helix/diff/00f8efea Branch: refs/heads/master Commit: 00f8efea0daf0418d4a85dcfe6c6c2a009114c47 Parents: 31cec91 Author: Lei Xia <[email protected]> Authored: Thu Nov 2 13:26:38 2017 -0700 Committer: Junkai Xue <[email protected]> Committed: Wed Jan 24 18:30:17 2018 -0800 ---------------------------------------------------------------------- helix-core/src/main/java/org/apache/helix/task/TaskDriver.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/helix/blob/00f8efea/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ---------------------------------------------------------------------- diff --git a/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java b/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java index 90abc59..732a717 100644 --- a/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java +++ b/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java @@ -167,7 +167,7 @@ public class TaskDriver { * @param newWorkflowConfig */ public void updateWorkflow(String workflow, WorkflowConfig newWorkflowConfig) { - if (newWorkflowConfig.getWorkflowId() == null) { + if (newWorkflowConfig.getWorkflowId() == null || newWorkflowConfig.getWorkflowId().isEmpty()) { newWorkflowConfig.getRecord() .setSimpleField(WorkflowConfig.WorkflowConfigProperty.WorkflowID.name(), workflow); }
