This is an automated email from the ASF dual-hosted git repository.

hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 7424ad9  Fix incorrect name in exception of SharedZkClient (#1024)
7424ad9 is described below

commit 7424ad9031857316a70aff9c9124b53df35bdc1c
Author: Huizhi Lu <[email protected]>
AuthorDate: Tue May 26 23:37:40 2020 -0700

    Fix incorrect name in exception of SharedZkClient (#1024)
    
    There is a typo in the IllegalArgumentException of SharedZkClient which is 
confusing: DedicatedZkClient should be changed to SharedZkClient.
---
 .../java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java
 
b/zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java
index 0989136..a2b0d00 100644
--- 
a/zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java
+++ 
b/zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java
@@ -518,13 +518,12 @@ public class SharedZkClient implements RealmAwareZkClient 
{
   }
 
   private void checkIfPathContainsShardingKey(String path) {
-    // TODO: replace with the singleton MetadataStoreRoutingData
     try {
       String zkRealmForPath = 
_metadataStoreRoutingData.getMetadataStoreRealm(path);
       if (!_zkRealmAddress.equals(zkRealmForPath)) {
         throw new IllegalArgumentException("Given path: " + path + "'s ZK 
realm: " + zkRealmForPath
             + " does not match the ZK realm: " + _zkRealmAddress + " and 
sharding key: "
-            + _zkRealmShardingKey + " for this DedicatedZkClient!");
+            + _zkRealmShardingKey + " for this SharedZkClient!");
       }
     } catch (NoSuchElementException e) {
       throw new IllegalArgumentException(

Reply via email to