This is an automated email from the ASF dual-hosted git repository.

nealsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new a9a76fa30 Fix partition-list row expand bug (#2211)
a9a76fa30 is described below

commit a9a76fa303213fa60f40e59730a3c92024640406
Author: Micah Stubbs <[email protected]>
AuthorDate: Tue Sep 13 17:31:39 2022 -0700

    Fix partition-list row expand bug (#2211)
    
    Update helix-front for a breaking change
    introduced by dependency ngx-datatable
---
 .../src/app/resource/partition-list/partition-list.component.ts      | 5 +++--
 .../src/app/resource/resource-list/resource-list.component.ts        | 5 +++--
 helix-front/src/app/workflow/job-list/job-list.component.ts          | 5 +++--
 .../src/app/workflow/workflow-list/workflow-list.component.ts        | 5 +++--
 4 files changed, 12 insertions(+), 8 deletions(-)

diff --git 
a/helix-front/src/app/resource/partition-list/partition-list.component.ts 
b/helix-front/src/app/resource/partition-list/partition-list.component.ts
index b4d80d1b4..82bcef38c 100644
--- a/helix-front/src/app/resource/partition-list/partition-list.component.ts
+++ b/helix-front/src/app/resource/partition-list/partition-list.component.ts
@@ -5,6 +5,7 @@ import { Settings } from '../../core/settings';
 import { Partition, IReplica, Resource } from '../shared/resource.model';
 import { HelperService } from '../../shared/helper.service';
 import { ResourceService } from '../shared/resource.service';
+import { DatatableComponent } from '@swimlane/ngx-datatable';
 
 @Component({
   selector: 'hi-partition-list',
@@ -12,8 +13,8 @@ import { ResourceService } from '../shared/resource.service';
   styleUrls: ['./partition-list.component.scss'],
 })
 export class PartitionListComponent implements OnInit {
-  @ViewChild('partitionsTable', { static: true })
-  table: any;
+  @ViewChild('partitionsTable', { static: false })
+  table: DatatableComponent;
 
   isLoading = true;
   clusterName: string;
diff --git 
a/helix-front/src/app/resource/resource-list/resource-list.component.ts 
b/helix-front/src/app/resource/resource-list/resource-list.component.ts
index 6a3cc35be..c2b3f01ef 100644
--- a/helix-front/src/app/resource/resource-list/resource-list.component.ts
+++ b/helix-front/src/app/resource/resource-list/resource-list.component.ts
@@ -10,6 +10,7 @@ import { Resource } from '../shared/resource.model';
 import { ResourceService } from '../shared/resource.service';
 import { WorkflowService } from '../../workflow/shared/workflow.service';
 import { HelperService } from '../../shared/helper.service';
+import { DatatableComponent } from '@swimlane/ngx-datatable';
 
 @Component({
   selector: 'hi-resource-list',
@@ -18,8 +19,8 @@ import { HelperService } from '../../shared/helper.service';
   providers: [WorkflowService],
 })
 export class ResourceListComponent implements OnInit {
-  @ViewChild('resourcesTable', { static: true })
-  table: any;
+  @ViewChild('resourcesTable', { static: false })
+  table: DatatableComponent;
 
   isForInstance = false;
   headerHeight = Settings.tableHeaderHeight;
diff --git a/helix-front/src/app/workflow/job-list/job-list.component.ts 
b/helix-front/src/app/workflow/job-list/job-list.component.ts
index a45cefcaf..a846b464f 100644
--- a/helix-front/src/app/workflow/job-list/job-list.component.ts
+++ b/helix-front/src/app/workflow/job-list/job-list.component.ts
@@ -4,6 +4,7 @@ import moment from 'moment';
 
 import { Settings } from '../../core/settings';
 import { Job } from '../shared/workflow.model';
+import { DatatableComponent } from '@swimlane/ngx-datatable';
 
 @Component({
   selector: 'hi-job-list',
@@ -14,8 +15,8 @@ export class JobListComponent implements OnInit {
   @Input()
   jobs: Job[];
 
-  @ViewChild('jobsTable', { static: true })
-  table: any;
+  @ViewChild('jobsTable', { static: false })
+  table: DatatableComponent;
 
   rowHeight = Settings.tableRowHeight;
   headerHeight = Settings.tableHeaderHeight;
diff --git 
a/helix-front/src/app/workflow/workflow-list/workflow-list.component.ts 
b/helix-front/src/app/workflow/workflow-list/workflow-list.component.ts
index 07391112a..f4ac8d238 100644
--- a/helix-front/src/app/workflow/workflow-list/workflow-list.component.ts
+++ b/helix-front/src/app/workflow/workflow-list/workflow-list.component.ts
@@ -3,6 +3,7 @@ import { Router, ActivatedRoute } from '@angular/router';
 
 import { Settings } from '../../core/settings';
 import { WorkflowService } from '../shared/workflow.service';
+import { DatatableComponent } from '@swimlane/ngx-datatable';
 
 type WorkflowRow = {
   name: string;
@@ -14,8 +15,8 @@ type WorkflowRow = {
   styleUrls: ['./workflow-list.component.scss'],
 })
 export class WorkflowListComponent implements OnInit {
-  @ViewChild('workflowsTable', { static: true })
-  table: any;
+  @ViewChild('workflowsTable', { static: false })
+  table: DatatableComponent;
 
   isLoading = true;
   clusterName: string;

Reply via email to