This is an automated email from the ASF dual-hosted git repository.

jxue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 93c59a763 [apache/helix] -- Provide JDK 1.8 (backward) compatibility 
for meta-client (#2799)
93c59a763 is described below

commit 93c59a763c1f4ec72aeae8c654292b15d0f50ed5
Author: Himanshu Kandwal <himanshuk...@gmail.com>
AuthorDate: Wed May 8 18:25:45 2024 -0700

    [apache/helix] -- Provide JDK 1.8 (backward) compatibility for meta-client 
(#2799)
    
    We would like to provide a backward compatible support to our consumers 
where they also have an option to use JDK-8 compiled helix-core and meta-client 
jar, if they have such a requirement. By default we will generate JDK-11 jars 
and JDK-8 jars using a classifier.
---
 helix-core/pom.xml  |  1 -
 meta-client/pom.xml | 18 ++++++++++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/helix-core/pom.xml b/helix-core/pom.xml
index ba3d7b7e5..c8c5a504d 100644
--- a/helix-core/pom.xml
+++ b/helix-core/pom.xml
@@ -219,7 +219,6 @@
             <phase>package</phase>
             <goals>
               <goal>jar</goal>
-              <goal>test-jar</goal>
             </goals>
             <configuration>
               
<classesDirectory>${project.build.outputDirectory}_jdk8</classesDirectory>
diff --git a/meta-client/pom.xml b/meta-client/pom.xml
index 29092ef1e..e08872c8c 100644
--- a/meta-client/pom.xml
+++ b/meta-client/pom.xml
@@ -89,6 +89,24 @@ under the License.
       </resource>
     </resources>
     <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-jar-plugin</artifactId>
+        <version>3.3.0</version>
+        <executions>
+          <execution>
+            <id>default-package-jdk11</id>
+            <phase>package</phase>
+            <goals>
+              <goal>jar</goal>
+            </goals>
+            <configuration>
+              
<classesDirectory>${project.build.outputDirectory}_jdk8</classesDirectory>
+              <classifier>jdk8</classifier>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-assembly-plugin</artifactId>

Reply via email to