(helix) branch master updated: Performance improvement for IsEvacuateFinished (#3037)

[xyuanlu]

This is an automated email from the ASF dual-hosted git repository.

xyuanlu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.git


The following commit(s) were added to refs/heads/master by this push:
     new 3d2e8362a Performance improvement for IsEvacuateFinished (#3037)
3d2e8362a is described below

commit 3d2e8362ac003c60bdf678c193ec64383e6a98e7
Author: xyuanlu <xyua...@gmail.com>
AuthorDate: Mon May 12 15:03:47 2025 -0700

    Performance improvement for IsEvacuateFinished (#3037)
    
    IsEvacuateFinished is calling getChildValues for messages but actually we 
only need the child names.
---
 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 
b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
index 0d72ac4aa..5d917587e 100644
--- a/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
+++ b/helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
@@ -797,7 +797,7 @@ public class ZKHelixAdmin implements HelixAdmin {
     }
 
     // see if instance has pending message.
-    List<Message> messages = 
accessor.getChildValues(keyBuilder.messages(instanceName), true);
+    List<String> messages = 
accessor.getChildNames(keyBuilder.messages(instanceName));
     if (messages != null && !messages.isEmpty()) {
       logger.warn("Instance {} in cluster {} has pending messages.", 
instanceName, clusterName);
       return true;