armadillojim opened a new pull request #3624:
URL: https://github.com/apache/incubator-heron/pull/3624
Howdy! I'm relatively new to Heron, and it seems like a wonderful product.
Thanks for all your hard work in developing it!
As a newbie I've been reading through the documentation. One thing caught my
eye: the term "topology master". Other components don't use the same word. For
example, there are the "metrics manager", "stream manager", and "zoo keeper".
This PR is an attempt to change most occurrences of "master" and "slave" to
a different term such as "manager", "primary", "server", "secondary", and so
on. I didn't change every occurrence; for example there are some dependencies
on outside projects that use those terms:
* Mesos master/slave in `/vagrant`, `schedulers-mesos-local-mac.md`, and
`MesosFrameworkTest.java`
* YARN Application Master in documentation and:
* `HeronMasterDriver`
* `heron/schedulers/tests/java/org/apache/heron/scheduler/yarn`
* `heron/schedulers/src/java/org/apache/heron/scheduler/yarn`
* `heron/config/src/yaml/conf/yarn/scheduler.yaml`
* storm-compatibility and "master" node of Nimbus
Last, there is the "master" branch in use in this repo and many others.
The edits in this PR have the potential to credit merge conflicts in other
open PRs. I checked all open PRs from 2019 and 2020. Only five would have
conflicts, and hopefully they will be easy to resolve:
* #3227 line 69 in `RoundRobinPackingV2.java`
* #3561 changes to `/vagrant`
* #3584 many new uses of master/slave in
`heron/tools/admin/src/python/main.py`
* #3585 conflicts only in deletions of changes here
* #3602 a handful of conflicts in use of `tmaster`
There is one remaning TODO: `website2/docs/assets/tmanager.png`. Does
anyone have the SVG source for this image (to make an edit easier)?
I tried to break the edits into more digestible bites by splitting commits
among subdirectories. Hopefully this will make reviewing easier.
Some important questions:
* did I miss anything?
* did I break anything?
* do any external libraries rely on the use of `tmaster` or any such
variables?
I haven't done testing yet as the edits here took me much longer than I
originally anticipated. However, I will try my best to do so over the next few
days. Additional eyes are welcome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
