surahman commented on pull request #3710: URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-922103249
My confusion seems to stem from when the K8s cluster is provided with the K8s executor pod configs. Judging from [this](https://github.com/apache/incubator-heron/blob/master/website2/docs/schedulers-k8s-by-hand.md) a config file is not submitted to the cluster for the executor Pods, but a default one is created by `createStatefulSet` and [submitted](https://github.com/apache/incubator-heron/blob/396f2b848da0f56dcfda1d917928358133851cf5/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java#L126) with the job. If that is the case, and that has been my assumption thus far, then we would then need to read in the [ConfigMap](https://kubernetes.io/docs/concepts/configuration/configmap/) file that was provided as a parameter to `--config-property`. We would then do a simple check around [here](https://github.com/apache/incubator-heron/blob/396f2b848da0f56dcfda1d917928358133851cf5/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/V1Controller.java#L386) and insert the contents of the ConfigMap into the `PodTemplateSpec`. If this is correct, would it not be simpler to declare a Pod Template file for the executor Pods and provide that as a parameter to `--config-property`, read it in using the k8s V1 YAML parser and place it into the `PodTemplateSpec` in the `StatefulSet`? If there is a k8s config submitted (I do not have any experience with Heron with k8s) then we could locate the configs in the `Config` object and linearly probe the `V1ConfigMapList` for a name provided by the `--config-property` and insert that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
