surahman commented on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-930300053


   Thank you @nicknezis, I have begun to affect changes on `dev`.
   
   > 1. Add configmaps k8s role permissions
   > 
   > ```
   > rules:
   > - apiGroups: 
   >   - ""
   >   resources: 
   >   - configmaps
   >   verbs: 
   >   - get
   >   - watch
   >   - list
   > ```
   
   I have looked into K8s `RBAC` on the v11 API and found 
[`createNamespacedRole`](https://github.com/kubernetes-client/java/blob/release-11/kubernetes/docs/RbacAuthorizationV1Api.md#createNamespacedRole)
 within the 
[`RbacAuthorizationV1Api`](https://github.com/kubernetes-client/java/blob/release-11/kubernetes/docs/RbacAuthorizationV1Api.md).
 It seems reasonably straightforward to get the above role into a 
[`V1Role`](https://github.com/kubernetes-client/java/blob/release-11/kubernetes/docs/V1Role.md)
 but it does require an API key. This can be set up in the `V1Controller` 
constructor.
   
   > 2. The `listConfigMaps` call is looking in the default namespace, but it 
should be using `getNamespace()` instead for that value.
   
   Good point, do not access directly and use the getter routine, resolved.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to