surahman commented on pull request #3710:
URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-934010151


   > I suspect what I had in the ConfigMap was being replaced with 
`getPodSpec()` in the code. We may need to merge the code configured aspects 
with anything loaded from the PodTemplate.
   
   That makes perfect sense, thank you! I shall have a look at how the two 
`V1PodSpec` can be merged.
   
   > It is important to note that Spark is opinionated about certain pod 
configurations so there are values in the pod template that will always be 
overwritten by Spark. Therefore, users of this feature should note that 
specifying the pod template file only lets Spark start with a template pod 
instead of an empty pod during the pod-building process. For details, see the 
full list of pod template values that will be overwritten by spark.
   
   I think we will need to follow the same protocol and standards and document 
this information. Not all fields are lists or maps...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to