nicknezis commented on pull request #3725: URL: https://github.com/apache/incubator-heron/pull/3725#issuecomment-961959088
I'll hopefully get some time to test soon. But in the meantime I have a question. Does this support mounting pre-existing PVCs and also dynamically creating the PVC? In the Spark implementation they had a special claim name `OnDemand` that would signify to create a dynamic PVC. With the current implementation, it seems we always create a new PVC. If so, this would preclude the ability to mount existing PVCs. For the dynamic PVCs, I think it's ok that the PVC is not cleaned up dynamically when the analytic is killed. Perhaps that can be a config item on the scheduler that toggles the behavior of whether it should clean up any dynamically provisioned PVCs? We can always add this feature later. Not a blocker for merging this current Pull Request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
