surahman edited a comment on pull request #3725: URL: https://github.com/apache/incubator-heron/pull/3725#issuecomment-966415541
`VolumeClaimTemplate`s is a cleaner way of handling all this, I shall switch over to using them. I think we can remove the shared PVC volume; there are certain things that should be left to being manually created in Pod Templates. I need to figure out how to rejig the code. On a side note, we need to fix the CI issues. The `statemgr_unit` test needs to be fixed and we _need_ the ability to manually retrigger the CI pipeline. **_Edit:_** switching to the `VolumeClaimTemplate` seems to be ~a simple~ an "involved" adjustment with a lot of test updates. I am figuring things out. We are going to need to drop the `claimName` option and switch to only using only `Volume Claim Templates` going forward. This will allow people to set up a statically backed PV or expect a dynamically backed one using the `storageClassName` option. If nothing is provided for the `storageClassName` a statically backed PV will be expected. This means PVCs will always be generated and deployed whenever anyone uses these CLI options. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
