nicknezis commented on pull request #3725: URL: https://github.com/apache/incubator-heron/pull/3725#issuecomment-967792144
The "dynamic" creation of the PVCs would only happen when the special claim name `OnDemand` is used. This would be a special toggle that triggers the logic to dynamically create the PVC with the Claim Template. Only then do we use the other options to populate the Claim Template. I think we're getting close. Hopefully that explanation helps. One thing I notice on the Spark config structure that might be worth noting, they use the `mount` and `options` to distinguish the volume mount set of configs and the options that are specific to the type of storage. In our case, so far we are only implementing the PVC approach, but in the future we might also add `hostPath`. I'm not sure if having the `mount` and `options` configuration hierarchy helps make the code cleaner. I can see things still working the way you currently have the naming, so it might not be a big deal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
