surahman commented on pull request #3741: URL: https://github.com/apache/incubator-heron/pull/3741#issuecomment-986250149
> Im testing on the build, and wondering the needs of `heron.kubernetes.executor.pod.template=pod-templ-executor.pod-template-executor.yaml` Is this necessary on deployment and where is this file located? @windhamwong It is not required, and if not supplied a default `Executor` and `Manager` pod will be deployed. You will need to load the Pod Template into a ConfigMap. Please see the first section of the [documentation](https://github.com/apache/incubator-heron/blob/b53d476f68900a8b1cc83a59da5208316857e0cb/website2/docs/schedulers-k8s-execution-environment.md) for usage and details. This functionality was initially introduced in an earlier PR. > I don't have problem with the PVC but just wondering, do we need > > ``` > --config-property heron.kubernetes.executor.limits.cpu=5 \ > --config-property heron.kubernetes.executor.limits.memory=6Gi \ > --config-property heron.kubernetes.executor.requests.cpu=2 \ > --config-property heron.kubernetes.executor.requests.memory=1Gi \ > ``` > > as we already got > > ``` > constants.TOPOLOGY_CONTAINER_CPU_REQUESTED > constants.TOPOLOGY_CONTAINER_RAM_REQUESTED > ``` > > in each topology. > > Will there be a way to implement the config in topology constants so we can change the value for specific topology? This functionality mirrors what is available in Spark and permits deployment time tweaking of resources without having to repackage a `Jar` file your topology. The ability to configure resources via configs remains unchanged but the CLI commands take precedence to facilitate the aforementioned functionality. > I think we got another bug here. As the Python version using is 3.8 under your pr branch, it warns the Python library kazoo (used in zookeeper connection). Heron Tracker uses kazoo 2.7.0 but Python 3.8 is not compatible with it and has to upgrade kazoo to 2.8.0. Warning: > > ``` > /root/.pex/installed_wheels/6e40458c80f1b6a2bb9c38603c9fe8a17f0aa169/kazoo-2.7.0-py2.py3-none-any.whl/kazoo/protocol/serialization.py:114: SyntaxWarning: "is" > with a literal. Did you mean "=="? > read_only = bool_struct.unpack_from(bytes, offset)[0] is 1 > /root/.pex/installed_wheels/6e40458c80f1b6a2bb9c38603c9fe8a17f0aa169/kazoo-2.7.0-py2.py3-none-any.whl/kazoo/protocol/serialization.py:449: SyntaxWarning: "is" with a literal. Did you mean "=="? > ``` > > Shall have another PR for this :D Good catch, please open a new issue if you have not already. These are not changes that were introduced in this PR and are most likely associated with updates to facilitate building on `macOS`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
