nicknezis commented on issue #3745: URL: https://github.com/apache/incubator-heron/issues/3745#issuecomment-997303062
I fixed the issue in this PR. https://github.com/apache/incubator-heron/pull/3749/files Nick On Sat, Dec 18, 2021 at 6:36 PM Nicholas Nezis ***@***.***> wrote: > It looks like we added anticrlf to heron-shell for security reasons in > this PR. https://github.com/apache/incubator-heron/pull/3718 > > But then removed it here 10 days ago: > https://github.com/apache/incubator-heron/pull/3746 > > Is the desire to have the library used? The fix might be to add the proper > Python dependency (as opposed to reverting the security fix). Looks like > this is the library. I'll try adding to the BUILD file as a dependency and > test. https://pypi.org/project/logging-formatter-anticrlf/#history > > What do you guys think? Just wanted to make sure we're all on the same > page with this. > > On Fri, Dec 10, 2021 at 6:05 AM Josh Fischer ***@***.***> > wrote: > >> Closed #3745 <https://github.com/apache/incubator-heron/issues/3745> via >> #3746 <https://github.com/apache/incubator-heron/pull/3746>. >> >> — >> You are receiving this because you are subscribed to this thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/incubator-heron/issues/3745#event-5747030181>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AABMNKXULWLU5S4E7LW4JODUQHNGVANCNFSM5JVY44KA> >> . >> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
