nicknezis commented on a change in pull request #3789:
URL: https://github.com/apache/incubator-heron/pull/3789#discussion_r824908430
##########
File path: heron/executor/src/python/heron_executor.py
##########
@@ -610,11 +610,20 @@ def _get_jvm_instance_options(self, instance_id,
component_name, remote_debugger
java_version.startswith("1.6") or \
java_version.startswith("1.5"):
java_metasize_param = 'PermSize'
+ xmn_param = '-Xmn%dM' % xmn_size
+ if self._get_java_major_version() >= 11:
+ # For Java 11 and above.
+ # The Xmx value is 25% of the available memory with a maximum of 25 GB.
Review comment:
This information only applies to the Xmx default value. But it seems we
are always setting Xmx on line 624. So perhaps this comment isn't needed? Or is
it related to the Xmn change this PR introduces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
