nicknezis commented on PR #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1094096215

   > I am not sure but I do not think there is a need to convert the zipped 
together values into a `list` and then a `dict`. But then I also do not believe 
this would affect the return value.
   > 
   > 
https://github.com/apache/incubator-heron/blob/06e9f75988fd254053b640689879c3393703b0dd/heron/tools/common/src/python/clients/tracker.py#L626
   > 
   > Maybe try this:
   > 
   > ```python
   > return dict(zip(keys, values))
   > ```
   
   I think `zip()` returns an `Iterator` and the `list()` call converts to an 
actual List. I was not familiar with the `zip` method, but it seems to be a 
[standard 
pattern](https://realpython.com/python-zip-function/#passing-n-arguments). When 
I print the value returned from that call I can see the value. It's only when 
that same result is returned from the `compute_max` that I get an empty `{}` in 
the `data` variable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to