nicknezis commented on PR #3819: URL: https://github.com/apache/incubator-heron/pull/3819#issuecomment-1101944984
Should the unit test be updated to be a float instead of string? I did not catch that. When I started working on the last PR, it was originally an `int` which I think was incorrect. `str` might be valid option. I think I tried to make it work, but we had enough other issues in the PR. I trust your opinion on `str` vs `float`. We should make sure we are setting the type consistently. Should this [line of code](https://github.com/apache/incubator-heron/blob/7db7c24733bd7e66ecfe704ea65f864d1fff4adc/heron/tools/tracker/src/python/query_operators.py#L46) also be updated to be a `str`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
