Author: cws Date: Mon Jun 25 19:59:44 2012 New Revision: 1353720 URL: http://svn.apache.org/viewvc?rev=1353720&view=rev Log: Hive thrift code doesnt generate quality hashCode() (Liu Tim via Carl Steinbach)
Summary: Hive thrift code doesnt generate quality hashCode(). Right now, it all has @Override public int hashCode() { return 0; } It will cause all entries go to the same bucket if it's used as hash key. Test Plan: ant clean package test pass 1946 tests Reviewers: njain, kevinwilfong, cwsteinbach Reviewed By: cwsteinbach Differential Revision: https://reviews.facebook.net/D3759 Modified: hive/trunk/build-common.xml hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlreadyExistsException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ConfigValSecurityException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectPrivilege.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/IndexAlreadyExistsException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidObjectException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidOperationException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidPartitionException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/MetaException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchObjectException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeGrantInfo.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UnknownDBException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UnknownPartitionException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UnknownTableException.java hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Version.java hive/trunk/ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Adjacency.java hive/trunk/ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Graph.java hive/trunk/ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Operator.java hive/trunk/ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Query.java hive/trunk/ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/QueryPlan.java hive/trunk/ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Stage.java hive/trunk/ql/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/ql/plan/api/Task.java hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java hive/trunk/service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveClusterStatus.java hive/trunk/service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/HiveServerException.java hive/trunk/service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java Modified: hive/trunk/build-common.xml URL: http://svn.apache.org/viewvc/hive/trunk/build-common.xml?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/build-common.xml (original) +++ hive/trunk/build-common.xml Mon Jun 25 19:59:44 2012 @@ -38,7 +38,7 @@ <property name="build.classes" location="${build.dir}/classes"/> <property name="build.encoding" value="ISO-8859-1"/> - <property name="thrift.args" value="-I ${thrift.home} --gen java:beans --gen cpp --gen php --gen py --gen rb"/> + <property name="thrift.args" value="-I ${thrift.home} --gen java:beans,hashcode --gen cpp --gen php --gen py --gen rb"/> <property name="hadoop.conf.dir" location="${hadoop.root}/conf"/> @@ -68,7 +68,7 @@ <property name="hadoop.opts.23" value="-D mapreduce.framework.name=local" /> <property name="hadoop.opts.20" value="" /> - + <path id="test.classpath"> <pathelement location="${test.build.classes}" /> <pathelement location="${test.build.resources}" /> @@ -170,7 +170,7 @@ <pathelement location="${build.dir.hive}/classes"/> <fileset dir="${build.dir.hive}" includes="*/*.jar"/> <fileset dir="${hive.root}/lib" includes="*.jar"/> - <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar" + <fileset dir="${build.ivy.lib.dir}/default" includes="*.jar" erroronmissingdir="false"/> </path> @@ -376,7 +376,7 @@ </if> <if> <equals arg1="${test.print.classpath}" arg2="true" /> - <then> + <then> <echo message="Test Classpath: ${hadoop.testcp}"/> </then> </if> Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlreadyExistsException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlreadyExistsException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlreadyExistsException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AlreadyExistsException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class AlreadyExistsException exte @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(AlreadyExistsException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ConfigValSecurityException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ConfigValSecurityException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ConfigValSecurityException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ConfigValSecurityException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class ConfigValSecurityException @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(ConfigValSecurityException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -464,7 +465,34 @@ public class Database implements org.apa @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_name = true && (isSetName()); + builder.append(present_name); + if (present_name) + builder.append(name); + + boolean present_description = true && (isSetDescription()); + builder.append(present_description); + if (present_description) + builder.append(description); + + boolean present_locationUri = true && (isSetLocationUri()); + builder.append(present_locationUri); + if (present_locationUri) + builder.append(locationUri); + + boolean present_parameters = true && (isSetParameters()); + builder.append(present_parameters); + if (present_parameters) + builder.append(parameters); + + boolean present_privileges = true && (isSetPrivileges()); + builder.append(present_privileges); + if (present_privileges) + builder.append(privileges); + + return builder.toHashCode(); } public int compareTo(Database other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -234,7 +235,14 @@ public class EnvironmentContext implemen @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_properties = true && (isSetProperties()); + builder.append(present_properties); + if (present_properties) + builder.append(properties); + + return builder.toHashCode(); } public int compareTo(EnvironmentContext other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FieldSchema.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -325,7 +326,24 @@ public class FieldSchema implements org. @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_name = true && (isSetName()); + builder.append(present_name); + if (present_name) + builder.append(name); + + boolean present_type = true && (isSetType()); + builder.append(present_type); + if (present_type) + builder.append(type); + + boolean present_comment = true && (isSetComment()); + builder.append(present_comment); + if (present_comment) + builder.append(comment); + + return builder.toHashCode(); } public int compareTo(FieldSchema other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectPrivilege.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectPrivilege.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectPrivilege.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectPrivilege.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -395,7 +396,29 @@ public class HiveObjectPrivilege impleme @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_hiveObject = true && (isSetHiveObject()); + builder.append(present_hiveObject); + if (present_hiveObject) + builder.append(hiveObject); + + boolean present_principalName = true && (isSetPrincipalName()); + builder.append(present_principalName); + if (present_principalName) + builder.append(principalName); + + boolean present_principalType = true && (isSetPrincipalType()); + builder.append(present_principalType); + if (present_principalType) + builder.append(principalType.getValue()); + + boolean present_grantInfo = true && (isSetGrantInfo()); + builder.append(present_grantInfo); + if (present_grantInfo) + builder.append(grantInfo); + + return builder.toHashCode(); } public int compareTo(HiveObjectPrivilege other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -473,7 +474,34 @@ public class HiveObjectRef implements or @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_objectType = true && (isSetObjectType()); + builder.append(present_objectType); + if (present_objectType) + builder.append(objectType.getValue()); + + boolean present_dbName = true && (isSetDbName()); + builder.append(present_dbName); + if (present_dbName) + builder.append(dbName); + + boolean present_objectName = true && (isSetObjectName()); + builder.append(present_objectName); + if (present_objectName) + builder.append(objectName); + + boolean present_partValues = true && (isSetPartValues()); + builder.append(present_partValues); + if (present_partValues) + builder.append(partValues); + + boolean present_columnName = true && (isSetColumnName()); + builder.append(present_columnName); + if (present_columnName) + builder.append(columnName); + + return builder.toHashCode(); } public int compareTo(HiveObjectRef other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -759,7 +760,59 @@ public class Index implements org.apache @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_indexName = true && (isSetIndexName()); + builder.append(present_indexName); + if (present_indexName) + builder.append(indexName); + + boolean present_indexHandlerClass = true && (isSetIndexHandlerClass()); + builder.append(present_indexHandlerClass); + if (present_indexHandlerClass) + builder.append(indexHandlerClass); + + boolean present_dbName = true && (isSetDbName()); + builder.append(present_dbName); + if (present_dbName) + builder.append(dbName); + + boolean present_origTableName = true && (isSetOrigTableName()); + builder.append(present_origTableName); + if (present_origTableName) + builder.append(origTableName); + + boolean present_createTime = true; + builder.append(present_createTime); + if (present_createTime) + builder.append(createTime); + + boolean present_lastAccessTime = true; + builder.append(present_lastAccessTime); + if (present_lastAccessTime) + builder.append(lastAccessTime); + + boolean present_indexTableName = true && (isSetIndexTableName()); + builder.append(present_indexTableName); + if (present_indexTableName) + builder.append(indexTableName); + + boolean present_sd = true && (isSetSd()); + builder.append(present_sd); + if (present_sd) + builder.append(sd); + + boolean present_parameters = true && (isSetParameters()); + builder.append(present_parameters); + if (present_parameters) + builder.append(parameters); + + boolean present_deferredRebuild = true; + builder.append(present_deferredRebuild); + if (present_deferredRebuild) + builder.append(deferredRebuild); + + return builder.toHashCode(); } public int compareTo(Index other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/IndexAlreadyExistsException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/IndexAlreadyExistsException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/IndexAlreadyExistsException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/IndexAlreadyExistsException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class IndexAlreadyExistsException @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(IndexAlreadyExistsException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidObjectException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidObjectException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidObjectException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidObjectException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class InvalidObjectException exte @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(InvalidObjectException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidOperationException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidOperationException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidOperationException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidOperationException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class InvalidOperationException e @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(InvalidOperationException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidPartitionException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidPartitionException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidPartitionException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InvalidPartitionException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class InvalidPartitionException e @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(InvalidPartitionException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/MetaException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/MetaException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/MetaException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/MetaException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class MetaException extends Excep @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(MetaException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchObjectException.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchObjectException.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchObjectException.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NoSuchObjectException.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -209,7 +210,14 @@ public class NoSuchObjectException exten @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_message = true && (isSetMessage()); + builder.append(present_message); + if (present_message) + builder.append(message); + + return builder.toHashCode(); } public int compareTo(NoSuchObjectException other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Order.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -270,7 +271,19 @@ public class Order implements org.apache @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_col = true && (isSetCol()); + builder.append(present_col); + if (present_col) + builder.append(col); + + boolean present_order = true; + builder.append(present_order); + if (present_order) + builder.append(order); + + return builder.toHashCode(); } public int compareTo(Order other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -661,7 +662,49 @@ public class Partition implements org.ap @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_values = true && (isSetValues()); + builder.append(present_values); + if (present_values) + builder.append(values); + + boolean present_dbName = true && (isSetDbName()); + builder.append(present_dbName); + if (present_dbName) + builder.append(dbName); + + boolean present_tableName = true && (isSetTableName()); + builder.append(present_tableName); + if (present_tableName) + builder.append(tableName); + + boolean present_createTime = true; + builder.append(present_createTime); + if (present_createTime) + builder.append(createTime); + + boolean present_lastAccessTime = true; + builder.append(present_lastAccessTime); + if (present_lastAccessTime) + builder.append(lastAccessTime); + + boolean present_sd = true && (isSetSd()); + builder.append(present_sd); + if (present_sd) + builder.append(sd); + + boolean present_parameters = true && (isSetParameters()); + builder.append(present_parameters); + if (present_parameters) + builder.append(parameters); + + boolean present_privileges = true && (isSetPrivileges()); + builder.append(present_privileges); + if (present_privileges) + builder.append(privileges); + + return builder.toHashCode(); } public int compareTo(Partition other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -412,7 +413,24 @@ public class PrincipalPrivilegeSet imple @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_userPrivileges = true && (isSetUserPrivileges()); + builder.append(present_userPrivileges); + if (present_userPrivileges) + builder.append(userPrivileges); + + boolean present_groupPrivileges = true && (isSetGroupPrivileges()); + builder.append(present_groupPrivileges); + if (present_groupPrivileges) + builder.append(groupPrivileges); + + boolean present_rolePrivileges = true && (isSetRolePrivileges()); + builder.append(present_rolePrivileges); + if (present_rolePrivileges) + builder.append(rolePrivileges); + + return builder.toHashCode(); } public int compareTo(PrincipalPrivilegeSet other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -229,7 +230,14 @@ public class PrivilegeBag implements org @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_privileges = true && (isSetPrivileges()); + builder.append(present_privileges); + if (present_privileges) + builder.append(privileges); + + return builder.toHashCode(); } public int compareTo(PrivilegeBag other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeGrantInfo.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeGrantInfo.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeGrantInfo.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeGrantInfo.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -456,7 +457,34 @@ public class PrivilegeGrantInfo implemen @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_privilege = true && (isSetPrivilege()); + builder.append(present_privilege); + if (present_privilege) + builder.append(privilege); + + boolean present_createTime = true; + builder.append(present_createTime); + if (present_createTime) + builder.append(createTime); + + boolean present_grantor = true && (isSetGrantor()); + builder.append(present_grantor); + if (present_grantor) + builder.append(grantor); + + boolean present_grantorType = true && (isSetGrantorType()); + builder.append(present_grantorType); + if (present_grantorType) + builder.append(grantorType.getValue()); + + boolean present_grantOption = true; + builder.append(present_grantOption); + if (present_grantOption) + builder.append(grantOption); + + return builder.toHashCode(); } public int compareTo(PrivilegeGrantInfo other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Role.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -328,7 +329,24 @@ public class Role implements org.apache. @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_roleName = true && (isSetRoleName()); + builder.append(present_roleName); + if (present_roleName) + builder.append(roleName); + + boolean present_createTime = true; + builder.append(present_createTime); + if (present_createTime) + builder.append(createTime); + + boolean present_ownerName = true && (isSetOwnerName()); + builder.append(present_ownerName); + if (present_ownerName) + builder.append(ownerName); + + return builder.toHashCode(); } public int compareTo(Role other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -312,7 +313,19 @@ public class Schema implements org.apach @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_fieldSchemas = true && (isSetFieldSchemas()); + builder.append(present_fieldSchemas); + if (present_fieldSchemas) + builder.append(fieldSchemas); + + boolean present_properties = true && (isSetProperties()); + builder.append(present_properties); + if (present_properties) + builder.append(properties); + + return builder.toHashCode(); } public int compareTo(Schema other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -350,7 +351,24 @@ public class SerDeInfo implements org.ap @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_name = true && (isSetName()); + builder.append(present_name); + if (present_name) + builder.append(name); + + boolean present_serializationLib = true && (isSetSerializationLib()); + builder.append(present_serializationLib); + if (present_serializationLib) + builder.append(serializationLib); + + boolean present_parameters = true && (isSetParameters()); + builder.append(present_parameters); + if (present_parameters) + builder.append(parameters); + + return builder.toHashCode(); } public int compareTo(SerDeInfo other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -819,7 +820,59 @@ public class StorageDescriptor implement @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_cols = true && (isSetCols()); + builder.append(present_cols); + if (present_cols) + builder.append(cols); + + boolean present_location = true && (isSetLocation()); + builder.append(present_location); + if (present_location) + builder.append(location); + + boolean present_inputFormat = true && (isSetInputFormat()); + builder.append(present_inputFormat); + if (present_inputFormat) + builder.append(inputFormat); + + boolean present_outputFormat = true && (isSetOutputFormat()); + builder.append(present_outputFormat); + if (present_outputFormat) + builder.append(outputFormat); + + boolean present_compressed = true; + builder.append(present_compressed); + if (present_compressed) + builder.append(compressed); + + boolean present_numBuckets = true; + builder.append(present_numBuckets); + if (present_numBuckets) + builder.append(numBuckets); + + boolean present_serdeInfo = true && (isSetSerdeInfo()); + builder.append(present_serdeInfo); + if (present_serdeInfo) + builder.append(serdeInfo); + + boolean present_bucketCols = true && (isSetBucketCols()); + builder.append(present_bucketCols); + if (present_bucketCols) + builder.append(bucketCols); + + boolean present_sortCols = true && (isSetSortCols()); + builder.append(present_sortCols); + if (present_sortCols) + builder.append(sortCols); + + boolean present_parameters = true && (isSetParameters()); + builder.append(present_parameters); + if (present_parameters) + builder.append(parameters); + + return builder.toHashCode(); } public int compareTo(StorageDescriptor other) { Modified: hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java?rev=1353720&r1=1353719&r2=1353720&view=diff ============================================================================== --- hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java (original) +++ hive/trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java Mon Jun 25 19:59:44 2012 @@ -5,6 +5,7 @@ */ package org.apache.hadoop.hive.metastore.api; +import org.apache.commons.lang.builder.HashCodeBuilder; import java.util.List; import java.util.ArrayList; import java.util.Map; @@ -951,7 +952,74 @@ public class Table implements org.apache @Override public int hashCode() { - return 0; + HashCodeBuilder builder = new HashCodeBuilder(); + + boolean present_tableName = true && (isSetTableName()); + builder.append(present_tableName); + if (present_tableName) + builder.append(tableName); + + boolean present_dbName = true && (isSetDbName()); + builder.append(present_dbName); + if (present_dbName) + builder.append(dbName); + + boolean present_owner = true && (isSetOwner()); + builder.append(present_owner); + if (present_owner) + builder.append(owner); + + boolean present_createTime = true; + builder.append(present_createTime); + if (present_createTime) + builder.append(createTime); + + boolean present_lastAccessTime = true; + builder.append(present_lastAccessTime); + if (present_lastAccessTime) + builder.append(lastAccessTime); + + boolean present_retention = true; + builder.append(present_retention); + if (present_retention) + builder.append(retention); + + boolean present_sd = true && (isSetSd()); + builder.append(present_sd); + if (present_sd) + builder.append(sd); + + boolean present_partitionKeys = true && (isSetPartitionKeys()); + builder.append(present_partitionKeys); + if (present_partitionKeys) + builder.append(partitionKeys); + + boolean present_parameters = true && (isSetParameters()); + builder.append(present_parameters); + if (present_parameters) + builder.append(parameters); + + boolean present_viewOriginalText = true && (isSetViewOriginalText()); + builder.append(present_viewOriginalText); + if (present_viewOriginalText) + builder.append(viewOriginalText); + + boolean present_viewExpandedText = true && (isSetViewExpandedText()); + builder.append(present_viewExpandedText); + if (present_viewExpandedText) + builder.append(viewExpandedText); + + boolean present_tableType = true && (isSetTableType()); + builder.append(present_tableType); + if (present_tableType) + builder.append(tableType); + + boolean present_privileges = true && (isSetPrivileges()); + builder.append(present_privileges); + if (present_privileges) + builder.append(privileges); + + return builder.toHashCode(); } public int compareTo(Table other) {