HIVE-10608 : Fix useless 'if' stamement in RetryingMetaStoreClient (135) (Alexander Pivovarov via Szehon)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/7149ab15 Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/7149ab15 Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/7149ab15 Branch: refs/heads/beeline-cli Commit: 7149ab15787a5f26954ece2283944ab78e8694ec Parents: 48a243e Author: Szehon Ho <sze...@cloudera.com> Authored: Thu May 7 11:13:59 2015 -0700 Committer: Szehon Ho <sze...@cloudera.com> Committed: Thu May 7 11:13:59 2015 -0700 ---------------------------------------------------------------------- .../apache/hadoop/hive/metastore/RetryingMetaStoreClient.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hive/blob/7149ab15/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java ---------------------------------------------------------------------- diff --git a/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java b/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java index fb44484..e282981 100644 --- a/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java +++ b/metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java @@ -173,8 +173,11 @@ public class RetryingMetaStoreClient implements InvocationHandler { throw e.getCause(); } } catch (MetaException e) { - if (e.getMessage().matches("(?s).*(IO|TTransport)Exception.*")); - caughtException = e; + if (e.getMessage().matches("(?s).*(IO|TTransport)Exception.*")) { + caughtException = e; + } else { + throw e; + } } if (retriesMade >= retryLimit) {
