HIVE-16175: Possible race condition in InstanceCache (Chao Sun, reviewed by Xuefu Zhang)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/1047126a Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/1047126a Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/1047126a Branch: refs/heads/hive-14535 Commit: 1047126a3a91006a7a8395fec539825da43b1261 Parents: 374b46c Author: Chao Sun <[email protected]> Authored: Fri Mar 10 08:55:31 2017 -0800 Committer: Chao Sun <[email protected]> Committed: Fri Mar 10 15:00:41 2017 -0800 ---------------------------------------------------------------------- .../src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hive/blob/1047126a/serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java ---------------------------------------------------------------------- diff --git a/serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java b/serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java index 09fca68..2d52020 100644 --- a/serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java +++ b/serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java @@ -51,7 +51,7 @@ public abstract class InstanceCache<SeedObject, Instance> { * Retrieve (or create if it doesn't exist) the correct Instance for this * SeedObject using 'seenSchemas' to resolve circular references */ - public Instance retrieve(SeedObject hv, + public synchronized Instance retrieve(SeedObject hv, Set<SeedObject> seenSchemas) throws AvroSerdeException { if(LOG.isDebugEnabled()) LOG.debug("Checking for hv: " + hv.toString());
