This is an automated email from the ASF dual-hosted git repository. kgyrtkirk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push: new 9efafef HIVE-22983: Fix the comments on ConstantPropagate (Zhihua Deng via Zoltan Haindrich) 9efafef is described below commit 9efafef0822bac0cf7bb5f146f847f1591a456a1 Author: Zhihua Deng <dengzhhu...@163.com> AuthorDate: Fri Mar 27 08:11:33 2020 +0000 HIVE-22983: Fix the comments on ConstantPropagate (Zhihua Deng via Zoltan Haindrich) Signed-off-by: Zoltan Haindrich <k...@rxd.hu> --- .../java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java b/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java index 47d9ec7..a040d7e 100644 --- a/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java +++ b/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java @@ -57,7 +57,7 @@ import org.apache.hadoop.hive.ql.parse.SemanticException; * some constants of its parameters. * * 3. Propagate expression: if the expression is an assignment like column=constant, the expression - * will be propagate to parents to see if further folding operation is possible. + * will be propagate to children to see if further folding operation is possible. */ public class ConstantPropagate extends Transform { @@ -147,7 +147,7 @@ public class ConstantPropagate extends Transform { || getDispatchedList().containsAll(parents)) { opStack.push(nd); - // all children are done or no need to walk the children + // all parents are done or no need to walk the parents dispatch(nd, opStack); opStack.pop(); } else { @@ -157,7 +157,7 @@ public class ConstantPropagate extends Transform { return; } - // move all the children to the front of queue + // move all the children to the end of queue List<? extends Node> children = nd.getChildren(); if (children != null) { toWalk.removeAll(children);