[hive] branch master updated: HIVE-23922: Improve code quality, UDFArgumentException.getMessage Method requires only two parameters (#1307)

[sunchao]

This is an automated email from the ASF dual-hosted git repository.

sunchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new f49f191  HIVE-23922: Improve code quality, 
UDFArgumentException.getMessage Method requires only two parameters (#1307)
f49f191 is described below

commit f49f19183b4436039c03c6b072dc67bf0b231a55
Author: dh20 <65940415+d...@users.noreply.github.com>
AuthorDate: Wed Aug 12 22:51:41 2020 +0800

    HIVE-23922: Improve code quality, UDFArgumentException.getMessage Method 
requires only two parameters (#1307)
---
 .../org/apache/hadoop/hive/ql/exec/UDFArgumentException.java     | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/udf/src/java/org/apache/hadoop/hive/ql/exec/UDFArgumentException.java 
b/udf/src/java/org/apache/hadoop/hive/ql/exec/UDFArgumentException.java
index d25dbbb..00b4bae 100644
--- a/udf/src/java/org/apache/hadoop/hive/ql/exec/UDFArgumentException.java
+++ b/udf/src/java/org/apache/hadoop/hive/ql/exec/UDFArgumentException.java
@@ -65,16 +65,13 @@ public class UDFArgumentException extends SemanticException 
{
       Class<?> funcClass,
       List<TypeInfo> argTypeInfos,
       List<Method> methods) {
-    super(getMessage(message, funcClass, argTypeInfos, methods));
+    super(getMessage(message, methods));
     this.funcClass = funcClass;
     this.argTypeInfos = argTypeInfos;
     this.methods = methods;
   }
-  
-  private static String getMessage(String message, 
-      Class<?> funcClass,
-      List<TypeInfo> argTypeInfos,
-      List<Method> methods) {
+  //HIVE-23896 remove unnecessary parameter
+  private static String getMessage(String message, List<Method> methods) {
     StringBuilder sb = new StringBuilder();
     sb.append(message);
     if (methods != null) {