This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hive.git
commit b47798e56f14321db251652fa1c43887282bbf9b Author: Stamatis Zampetakis <zabe...@gmail.com> AuthorDate: Mon Nov 28 13:03:01 2022 +0100 HIVE-26785: Remove explicit protobuf-java dependency from blobstore and minikdc modules (Stamatis Zampetakis, reviewed by Ayush Saxena) The modules do not directly need protobuf dependency so it is misleading to declare it explicitly. Moreover, these modules use a different protobuf version (3.3.0) than the rest of the project (3.21.4) which can lead to compatibility problems, incosistent behavior in tests, and undesired transitive propagation to other modules. Closes #3809 --- itests/hive-blobstore/pom.xml | 6 ------ itests/hive-minikdc/pom.xml | 6 ------ 2 files changed, 12 deletions(-) diff --git a/itests/hive-blobstore/pom.xml b/itests/hive-blobstore/pom.xml index 3e0b882e56e..aab62d8de31 100644 --- a/itests/hive-blobstore/pom.xml +++ b/itests/hive-blobstore/pom.xml @@ -32,15 +32,9 @@ <execute.beeline.tests>false</execute.beeline.tests> <active.hadoop.version>${hadoop.version}</active.hadoop.version> <test.dfs.mkdir>-mkdir -p</test.dfs.mkdir> - <!-- Required by Calcite Avatica --> - <protobuf.version>3.3.0</protobuf.version> </properties> <dependencies> <!-- dependencies are always listed in sorted order by groupId, artifactId --> - <dependency> - <groupId>com.google.protobuf</groupId> - <artifactId>protobuf-java</artifactId> - </dependency> <dependency> <groupId>org.apache.hive</groupId> <artifactId>hive-common</artifactId> diff --git a/itests/hive-minikdc/pom.xml b/itests/hive-minikdc/pom.xml index 404bd9bd746..92a89cc5ffa 100644 --- a/itests/hive-minikdc/pom.xml +++ b/itests/hive-minikdc/pom.xml @@ -26,15 +26,9 @@ <properties> <hive.path.to.root>../..</hive.path.to.root> <exclude.tests>None</exclude.tests> - <!-- Required by Calcite Avatica --> - <protobuf.version>3.3.0</protobuf.version> </properties> <dependencies> <!-- dependencies are always listed in sorted order by groupId, artifactId --> - <dependency> - <groupId>com.google.protobuf</groupId> - <artifactId>protobuf-java</artifactId> - </dependency> <dependency> <groupId>org.apache.hive</groupId> <artifactId>hive-common</artifactId>