This is an automated email from the ASF dual-hosted git repository.

gsaihemanth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 491bff597d0 HIVE-28371: Optimize add partitions authorization in 
HiveMetaStore (#5346) (Sai Hemanth Gantasala, Reviewed by Naresh PR, Zhihua 
Deng)
491bff597d0 is described below

commit 491bff597d016d8bcc574bbe2569a5ae64a9d3ef
Author: Sai Hemanth Gantasala 
<[email protected]>
AuthorDate: Wed Jul 24 17:13:14 2024 -0700

    HIVE-28371: Optimize add partitions authorization in HiveMetaStore (#5346) 
(Sai Hemanth Gantasala, Reviewed by Naresh PR, Zhihua Deng)
---
 .../main/java/org/apache/hadoop/hive/metastore/HMSHandler.java   | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
 
b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
index caf1be66770..e770a953afa 100644
--- 
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
+++ 
b/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
@@ -4249,10 +4249,6 @@ public class HMSHandler extends FacebookBase implements 
IHMSHandler {
       MTable mTable = getMS().ensureGetMTable(catName, dbName, tblName);
       db = ms.getDatabase(catName, dbName);
 
-      if (!parts.isEmpty()) {
-        firePreEvent(new PreAddPartitionEvent(tbl, parts, this));
-      }
-
       Set<PartValEqWrapperLite> partsToAdd = new HashSet<>(parts.size());
       List<Partition> partitionsToAdd = new ArrayList<>(parts.size());
       List<FieldSchema> partitionKeys = tbl.getPartitionKeys();
@@ -4282,6 +4278,11 @@ public class HMSHandler extends FacebookBase implements 
IHMSHandler {
         }
       }
 
+      // Only authorize on newly created partitions
+      if (!partitionsToAdd.isEmpty()) {
+        firePreEvent(new PreAddPartitionEvent(tbl, partitionsToAdd, this));
+      }
+
       newParts.addAll(createPartitionFolders(partitionsToAdd, tbl, 
addedPartitions, envContext));
 
       if (!newParts.isEmpty()) {

Reply via email to