This is an automated email from the ASF dual-hosted git repository.

zabetak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git

commit 90165d76826439cbad38e10eb126e8710ffc1d28
Author: Stamatis Zampetakis <[email protected]>
AuthorDate: Wed Jul 24 16:51:27 2024 +0300

    HIVE-28401: Drop redundant XML test report post-processing from CI pipeline 
(Stamatis Zampetakis reviewed by Alessandro Solimando)
    
    The Maven Surefire Plugin (3.0.0-M4) does not store system-out and
    system-err in the XML report for successful tests; the plugin stores
    out/err in XML for skipped/failed tests.
    
    The main intention of the xmlstarlet post-processing step is to remove
    out/err for tests that run sucessfully since it can be very large and
    most of the time we don't need to retain it.
    
    The change leads to a slight change in behavior since now the out/err
    from skipped tests will be retained. As a result the size of the
    test-results.tgz archive will also increase (+1.5MB).
    
    Nevertheless, the change is beneficial since it will avoid the
    "Huge input lookup" problem, which is more detrimental for the CI
    when it happens. In addition, it alleviates the burden to handle
    out/err from Hive CI and leaves that responsibility to Surefire, that
    is more appropriate.
    
    Close apache/hive#5364
---
 Jenkinsfile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Jenkinsfile b/Jenkinsfile
index ce05c408e8a..50250d739b3 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -376,8 +376,6 @@ tar -xzf packaging/target/apache-hive-*-nightly-*-src.tar.gz
                   RENAME_TMP=`echo \$a | sed s/TEST-//g`
                   mv \${RENAME_TMP/.xml/-output.txt} 
\${RENAME_TMP/.xml/-output-save.txt}
                 done
-                # removes all stdout and err for passed tests
-                xmlstarlet ed -L -d 
'testsuite/testcase/system-out[count(../failure)=0]' -d 
'testsuite/testcase/system-err[count(../failure)=0]' `find . -name 'TEST*xml' 
-path '*/surefire-reports/*'`
                 # remove all output.txt files
                 find . -name '*output.txt' -path '*/surefire-reports/*' -exec 
unlink "{}" \\;
               """

Reply via email to