(hive) branch master updated: HIVE-15540: Impl `DatabaseMetaData#getURL()` and `DatabaseMetaData#getUserName()` for HiveServer2 JDBC Driver (#5554). (QING ZHU, reviewed by Ayush Saxena, Zsolt Miskolczi)

[ayushsaxena]

This is an automated email from the ASF dual-hosted git repository.

ayushsaxena pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 28baba24e94 HIVE-15540: Impl `DatabaseMetaData#getURL()` and 
`DatabaseMetaData#getUserName()` for HiveServer2 JDBC Driver (#5554). (QING 
ZHU, reviewed by Ayush Saxena, Zsolt Miskolczi)
28baba24e94 is described below

commit 28baba24e9464bd46fc7bc22561f7851cbb3b390
Author: Ling Hengqian <linghengq...@outlook.com>
AuthorDate: Fri Dec 13 03:33:44 2024 +0800

    HIVE-15540: Impl `DatabaseMetaData#getURL()` and 
`DatabaseMetaData#getUserName()` for HiveServer2 JDBC Driver (#5554). (QING 
ZHU, reviewed by Ayush Saxena, Zsolt Miskolczi)
---
 .../org/apache/hive/jdbc/TestHiveDatabaseMetaData.java     | 14 ++++++++++++--
 jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java     |  2 +-
 .../java/org/apache/hive/jdbc/HiveDatabaseMetaData.java    |  8 ++++----
 3 files changed, 17 insertions(+), 7 deletions(-)

diff --git 
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestHiveDatabaseMetaData.java
 
b/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestHiveDatabaseMetaData.java
index 2e5128e1eaf..70f222e0857 100644
--- 
a/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestHiveDatabaseMetaData.java
+++ 
b/itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestHiveDatabaseMetaData.java
@@ -18,8 +18,6 @@
 
 package org.apache.hive.jdbc;
 
-import org.apache.hive.jdbc.HiveConnection;
-import org.apache.hive.jdbc.Utils;
 import org.apache.hive.jdbc.Utils.JdbcConnectionParams;
 
 import java.util.LinkedHashMap;
@@ -107,4 +105,16 @@ public class TestHiveDatabaseMetaData {
         .get(Utils.JdbcConnectionParams.HIVE_CONF_PREFIX + 
"hive.default.nulls.last"));
 
   }
+
+  @Test
+  public void testGetUserName() throws SQLException {
+    HiveConnection hiveConnection = new 
HiveConnection("jdbc:hive2:///;user=foo", new Properties());
+    hiveDatabaseMetaData = new HiveDatabaseMetaData(hiveConnection, null, 
null);
+    assertEquals("foo", hiveDatabaseMetaData.getUserName());
+  }
+
+  @Test
+  public void testGetURL() {
+    assertEquals(connection.getConnectedUrl(), hiveDatabaseMetaData.getURL());
+  }
 }
\ No newline at end of file
diff --git a/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 
b/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
index 2850ccdddde..054400c2024 100644
--- a/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
+++ b/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
@@ -1307,7 +1307,7 @@ public class HiveConnection implements 
java.sql.Connection {
   /**
    * @return username from sessConfMap
    */
-  private String getUserName() {
+  String getUserName() {
     return getSessionValue(JdbcConnectionParams.AUTH_USER, 
JdbcConnectionParams.ANONYMOUS_USER);
   }
 
diff --git a/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 
b/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
index d1cfd7eb2c5..41f9857cd5e 100644
--- a/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
+++ b/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
@@ -744,12 +744,12 @@ public class HiveDatabaseMetaData implements 
DatabaseMetaData {
     };
   }
 
-  public String getURL() throws SQLException {
-    throw new SQLFeatureNotSupportedException("Method not supported");
+  public String getURL() {
+    return connection.getConnectedUrl();
   }
 
-  public String getUserName() throws SQLException {
-    throw new SQLFeatureNotSupportedException("Method not supported");
+  public String getUserName() {
+    return connection.getUserName();
   }
 
   public ResultSet getVersionColumns(String catalog, String schema, String 
table)