This is an automated email from the ASF dual-hosted git repository.

difin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 0520076f002 HIVE-28781: Hive shouldn't disable IPv6 stack. (#5753)
0520076f002 is described below

commit 0520076f002b28aea96161dd35c78fe6d5ed3936
Author: Dmitriy Fingerman <[email protected]>
AuthorDate: Tue May 27 14:54:59 2025 -0400

    HIVE-28781: Hive shouldn't disable IPv6 stack. (#5753)
---
 .../templeton/deployers/config/webhcat/webhcat-site.updateConfig.xml    | 2 +-
 .../src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.xml    | 2 +-
 hcatalog/webhcat/svr/src/main/config/webhcat-default.xml                | 2 +-
 llap-server/bin/runLlapDaemon.sh                                        | 2 +-
 pom.xml                                                                 | 1 -
 ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java             | 1 -
 testutils/hadoop                                                        | 1 +
 7 files changed, 5 insertions(+), 6 deletions(-)

diff --git 
a/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.updateConfig.xml
 
b/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.updateConfig.xml
index 54040f76c96..8609c16cf84 100644
--- 
a/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.updateConfig.xml
+++ 
b/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.updateConfig.xml
@@ -97,7 +97,7 @@
 
     <property>
         <name>templeton.controller.mr.child.opts</name>
-        <value> -Xmx64m -Djava.net.preferIPv4Stack=true</value>
+        <value> -Xmx64m</value>
     </property>
 
     <property>
diff --git 
a/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.xml 
b/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.xml
index eecb6162f91..7a5dfc6518b 100644
--- a/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.xml
+++ b/hcatalog/src/test/e2e/templeton/deployers/config/webhcat/webhcat-site.xml
@@ -95,7 +95,7 @@
 
     <property>
         <name>templeton.controller.mr.child.opts</name>
-        <value> -Xmx64m -Djava.net.preferIPv4Stack=true</value>
+        <value> -Xmx64m</value>
     </property>
 
     <property>
diff --git a/hcatalog/webhcat/svr/src/main/config/webhcat-default.xml 
b/hcatalog/webhcat/svr/src/main/config/webhcat-default.xml
index 2de85258412..e76a20d2269 100644
--- a/hcatalog/webhcat/svr/src/main/config/webhcat-default.xml
+++ b/hcatalog/webhcat/svr/src/main/config/webhcat-default.xml
@@ -193,7 +193,7 @@
 
   <property>
     <name>templeton.controller.mr.child.opts</name>
-    <value>-server -Xmx256m -Djava.net.preferIPv4Stack=true</value>
+    <value>-server -Xmx256m</value>
     <description>Java options to be passed to templeton controller map task.
         The default value of mapreduce child "-Xmx" (heap memory limit)
         might be close to what is allowed for a map task.
diff --git a/llap-server/bin/runLlapDaemon.sh b/llap-server/bin/runLlapDaemon.sh
index 1fe350bb02a..37607e39db4 100755
--- a/llap-server/bin/runLlapDaemon.sh
+++ b/llap-server/bin/runLlapDaemon.sh
@@ -57,7 +57,7 @@ JAVA_GC_OPTS="-XX:+PrintGCDetails -XX:+UseGCLogFileRotation 
-XX:NumberOfGCLogFil
 if [ "$JAVA_VERSION" -gt "1" ]; then # from java9+, -Xlog argument should be 
used
   
JAVA_GC_OPTS="-Xlog:gc*,safepoint:gc.log:time,uptime:filecount=4,filesize=100M"
 fi
-JAVA_OPTS_BASE="-server -Djava.net.preferIPv4Stack=true -XX:+UseNUMA 
-verbose:gc $JAVA_GC_OPTS"
+JAVA_OPTS_BASE="-server -XX:+UseNUMA -verbose:gc $JAVA_GC_OPTS"
 
 if [ ! -d "${LLAP_DAEMON_HOME}" ]; then
   echo No LLAP_DAEMON_HOME set, or is not a directory. 
diff --git a/pom.xml b/pom.xml
index 98006cb3705..f4fc2b09541 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1815,7 +1815,6 @@
             
<test.output.overwrite>${test.output.overwrite}</test.output.overwrite>
             
<test.warehouse.dir>${test.warehouse.scheme}${test.warehouse.dir}</test.warehouse.dir>
             
<test.local.warehouse.dir>${test.warehouse.scheme}${test.local.warehouse.dir}</test.local.warehouse.dir>
-            <java.net.preferIPv4Stack>true</java.net.preferIPv4Stack>
             <!-- EnforceReadOnlyTables hook and QTestUtil -->
             <test.src.tables/>
             
<java.security.krb5.conf>${test.conf.dir}/krb5.conf</java.security.krb5.conf>
diff --git a/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java 
b/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java
index aaa63fb094f..8c5a92416af 100644
--- a/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java
+++ b/ql/src/test/org/apache/hive/testutils/HiveTestEnvSetup.java
@@ -131,7 +131,6 @@ public void beforeClass(HiveTestEnvContext ctx) throws 
Exception {
       System.setProperty("test.tmp.dir.uri", "file://" + tmpFolderPath);
       System.setProperty("test.dfs.mkdir", "-mkdir -p");
       System.setProperty("test.warehouse.dir", tmpFolderPath + "/warehouse"); 
// this is changed to be *under* tmp dir
-      System.setProperty("java.net.preferIPv4Stack", "true"); // not sure if 
this will have any effect..
       System.setProperty("test.src.tables", "src");
       System.setProperty("hive.jar.directory", tmpFolderPath);
     }
diff --git a/testutils/hadoop b/testutils/hadoop
index 08fa2e87985..5140f77f81f 100755
--- a/testutils/hadoop
+++ b/testutils/hadoop
@@ -69,6 +69,7 @@ fi
 HADOOP_OPTS="$HADOOP_OPTS -Dhadoop.policy.file=$HADOOP_POLICYFILE"
 
 # Disable ipv6 as it can cause issues
+# TODO: change to -Djava.net.preferIPv4Stack=false after Hadoop adds support 
for IPv6
 HADOOP_OPTS="$HADOOP_OPTS -Djava.net.preferIPv4Stack=true"
 
 COMMAND=$1

Reply via email to