This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new f374f39ec72 HIVE-29207: Remove check-spelling CI action (#6080)
f374f39ec72 is described below
commit f374f39ec7205d98ad5605be6890564fc58eea0c
Author: Stamatis Zampetakis <[email protected]>
AuthorDate: Thu Sep 18 09:15:39 2025 +0200
HIVE-29207: Remove check-spelling CI action (#6080)
The check-spelling action reports many false positives that require
additional work and extra commits to address. Addressing the errors requires
additional work from contributors and extra resources from CI since all tests
are triggered again on new commits. Occasionally it also detects valid typos
but at this stage the negatives outweigh the positives.
See:
https://lists.apache.org/thread/bb2ncb5ytk50j73fcwzw0wbdsblkw9x3
https://lists.apache.org/thread/n7k808bkxtclww95fhgkznfsol32f0mn
---
.github/actions/spelling/README.md | 35 ---
.github/actions/spelling/advice.md | 43 ----
.github/actions/spelling/allow.txt | 1 -
.github/actions/spelling/excludes.txt | 57 -----
.github/actions/spelling/expect.txt | 443 ----------------------------------
.github/actions/spelling/only.txt | 1 -
.github/actions/spelling/patterns.txt | 40 ---
.github/actions/spelling/reject.txt | 7 -
.github/workflows/spelling.yml | 85 -------
9 files changed, 712 deletions(-)
diff --git a/.github/actions/spelling/README.md
b/.github/actions/spelling/README.md
deleted file mode 100644
index ce0a2cc8c70..00000000000
--- a/.github/actions/spelling/README.md
+++ /dev/null
@@ -1,35 +0,0 @@
-<!--
-{% comment %}
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to you under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-{% endcomment %}
--->
-# check-spelling/check-spelling configuration
-
-File | Purpose | Format | Info
--|-|-|-
-<!--
-[dictionary.txt](dictionary.txt) | Replacement dictionary (creating this file
will override the default dictionary) | one word per line |
[dictionary](https://github.com/check-spelling/check-spelling/wiki/Configuration#dictionary)
--->
-[allow.txt](allow.txt) | Add words to the dictionary | one word per line (only
letters and `'`s allowed) |
[allow](https://github.com/check-spelling/check-spelling/wiki/Configuration#allow)
-[reject.txt](reject.txt) | Remove words from the dictionary (after allow) |
grep pattern matching whole dictionary words |
[reject](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-reject)
-[excludes.txt](excludes.txt) | Files to ignore entirely | perl regular
expression |
[excludes](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-excludes)
-[only.txt](only.txt) | Only check matching files (applied after excludes) |
perl regular expression |
[only](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-only)
-[patterns.txt](patterns.txt) | Patterns to ignore from checked lines | perl
regular expression (order matters, first match wins) |
[patterns](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-patterns)
-[expect.txt](expect.txt) | Expected words that aren't in the dictionary | one
word per line (sorted, alphabetically) |
[expect](https://github.com/check-spelling/check-spelling/wiki/Configuration#expect)
-[advice.md](advice.md) | Supplement for GitHub comment when unrecognized words
are found | GitHub Markdown |
[advice](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-advice)
-
-Note: you can replace any of these files with a directory by the same name
(minus the suffix)
-and then include multiple files inside that directory (with that suffix) to
merge multiple files together.
diff --git a/.github/actions/spelling/advice.md
b/.github/actions/spelling/advice.md
deleted file mode 100644
index 48dafab6fa9..00000000000
--- a/.github/actions/spelling/advice.md
+++ /dev/null
@@ -1,43 +0,0 @@
-<!--
-{% comment %}
-Licensed to the Apache Software Foundation (ASF) under one or more
-contributor license agreements. See the NOTICE file distributed with
-this work for additional information regarding copyright ownership.
-The ASF licenses this file to you under the Apache License, Version 2.0
-(the "License"); you may not use this file except in compliance with
-the License. You may obtain a copy of the License at
-
-http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-{% endcomment %}
--->
-<!-- See
https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-advice
--> <!-- markdownlint-disable MD033 MD041 -->
-<details><summary>If the flagged items do not appear to be text</summary>
-
-If items relate to a ...
-* well-formed pattern.
-
- If you can write a
[pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns)
that would match it,
- try adding it to the `patterns.txt` file.
-
- Patterns are Perl 5 Regular Expressions - you can [test](
-https://www.regexplanet.com/advanced/perl/) yours before committing to verify
it will match your lines.
-
- Note that patterns can't match multiline strings.
-
-* binary file.
-
- Please add a file path to the `excludes.txt` file matching the containing
file.
-
- File paths are Perl 5 Regular Expressions - you can [test](
-https://www.regexplanet.com/advanced/perl/) yours before committing to verify
it will match your files.
-
- `^` refers to the file's path from the root of the repository, so
`^README\.md$` would exclude [README.md](
-../tree/HEAD/README.md) (on whichever branch you're using).
-
-</details>
diff --git a/.github/actions/spelling/allow.txt
b/.github/actions/spelling/allow.txt
deleted file mode 100644
index 7d03fa2095f..00000000000
--- a/.github/actions/spelling/allow.txt
+++ /dev/null
@@ -1 +0,0 @@
-HTTP
diff --git a/.github/actions/spelling/excludes.txt
b/.github/actions/spelling/excludes.txt
deleted file mode 100644
index f15a0e0c9ca..00000000000
--- a/.github/actions/spelling/excludes.txt
+++ /dev/null
@@ -1,57 +0,0 @@
-# See
https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-excludes
-(?:^|/)(?i)COPYRIGHT
-(?:^|/)(?i)LICEN[CS]E
-(?:^|/)package(?:-lock|)\.json$
-(?:^|/)vendor/
-ignore$
-LICENSE
-\.avi$
-\.avro$
-\.bz2$
-\.deflate$
-\.eot$
-\.gif$
-\.gz$
-\.ico$
-\.jar$
-\.jceks$
-\.jks$
-\.jpe?g$
-\.jpeg$
-\.jpg$
-\.keep$
-\.lock$
-\.log$
-\.map$
-\.min\.
-\.min\..
-\.mod$
-\.mp[34]$
-\.orc$
-\.out$
-\.out\.
-\.parq$
-\.parquet$
-\.png$
-\.q$
-\.rc$
-\.rcfile$
-\.seq$
-\.svg$
-\.ttf$
-\.wav$
-\.woff$
-^data/files
-^data/scripts/q_test_cleanup\.sql$
-^docs/people\.md$
-^errata\.txt$
-^hplsql/src/test/queries/local/to_timestamp\.sql$
-^iceberg-handler/checkstyle/checkstyle-suppressions\.xml$
-^itests/hive-unit/src/test/resources/simple-saml-idp-metadata-template\.xml$
-^llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos\.java$
-^llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/plugin/rpc/LlapPluginProtocolProtos\.java$
-^serde/src/test/resources/json/single_pixel\.json$
-^spark-client/src/test/java/org/apache/hive/spark/client/TestSparkClient\.java$
-^testutils/ptest2/src/test/resources/
-^\.github/
-^\Qql/src/test/resources/hsmm/hsmm_cfg_01.yaml\E$
diff --git a/.github/actions/spelling/expect.txt
b/.github/actions/spelling/expect.txt
deleted file mode 100644
index c55c7afe27a..00000000000
--- a/.github/actions/spelling/expect.txt
+++ /dev/null
@@ -1,443 +0,0 @@
-AAAAABJRU
-abcd
-abcde
-abcdef
-abcdefg
-abcdefgh
-abcdefghij
-abcdefghijklmnopqrstuvwxyz
-abyte
-adouble
-aeden
-afields
-AFq
-agrw
-aloi
-alphadigits
-amap
-ANANCIENTBLUEBOX
-ANull
-anullint
-anullstring
-aoig
-api
-APPLYQUOTESTOALL
-arecord
-args
-arraycopy
-asd
-ASF
-ashort
-astring
-ati
-attr
-aunion
-Autogenerated
-avro
-avrotest
-avsc
-bais
-baoi
-baos
-BArray
-basedir
-bdoi
-bdw
-bigint
-binarysortable
-bitfield
-bitset
-blahblahblah
-bnoi
-boi
-BTEQ
-buf
-byoi
-bytearrayinput
-bytebuffer
-byteinfo
-BYTEINT
-byw
-cae
-cfields
-charset
-classname
-clazz
-Cloneable
-cmp
-CODEPOINT
-coi
-columnset
-complexpb
-concat
-concating
-config
-cpp
-Cpy
-CReadable
-crlf
-csv
-ctl
-ctor
-ctype
-CYBERMEN
-DALEKS
-daos
-datetime
-ddl
-decs
-Deque
-deser
-deserialization
-deserialize
-deserialized
-deserializer
-deserializing
-dest
-dfr
-dfs
-dfw
-Dio
-doi
-DOTALL
-DOUBLEVALUE
-dti
-dtoi
-dtype
-DZone
-ecapseman
-ecast
-Eccleston
-eid
-ele
-elif
-endian
-endif
-entryinput
-entryoutput
-enum
-enumlist
-enumness
-enumset
-eoi
-EQVR
-Escapables
-ESCAPECHAR
-esri
-ETX
-etype
-facebook
-fastload
-ffec
-fff
-fieldids
-Fieldname
-firstfield
-foi
-foreach
-fourbytes
-frac
-ftype
-gallifrey
-garw
-gdr
-gdw
-gmt
-hadoop
-hamcrest
-hashcode
-Hashtable
-hbase
-hcoi
-hconf
-hcw
-HDFS
-hdoi
-hdw
-hiw
-href
-hvc
-hvoi
-iae
-IBegin
-identd
-idx
-ifndef
-ILength
-impl
-inited
-inlining
-inp
-INPATH
-inputformat
-inputmpkeyoi
-inputmpoi
-inputmpvalueoi
-inputstream
-instanceof
-interop
-Ints
-INTVALUE
-ioe
-ioi
-iosfwd
-iprot
-IScheme
-isdigit
-isinstance
-islist
-isset
-itest
-ith
-JAGRAFESS
-javabean
-Javadoc
-javax
-jdbc
-jdm
-Jggg
-Joda
-json
-junit
-kitchsink
-ktype
-kyro
-lasti
-lazybinary
-lazydio
-lazympkeyoi
-lazympoi
-lazympvalueoi
-lazyobj
-LAZYSIMPLE
-LBRACE
-LBRACKET
-len
-LINTSTRING
-loi
-LONGVALUE
-lstring
-ltype
-mapkey
-mapsize
-MAXVALUE
-mctesty
-Mega
-megastruct
-memoizes
-memoizing
-metadata
-metastore
-millis
-MINVALUE
-mkdirs
-mkoi
-mstring
-MSTRINGSTRING
-mti
-mtype
-mvoi
-mydouble
-myint
-mylong
-mysql
-MYSTRING
-namespace
-nano
-narray
-NByte
-Nestedin
-nfe
-nio
-noexcept
-nokey
-nondigits
-nullability
-nullableenum
-nullableint
-nullptr
-nullsafe
-nullstring
-NUu
-objectinspector
-objs
-ois
-olist
-omap
-opencsv
-oprot
-ostream
-outputmp
-outputstream
-params
-php
-plugin
-png
-println
-prj
-prot
-protobuf
-protoc
-pti
-ptr
-ptype
-QLFTWHXe
-QUOTECHAR
-RAWSTRING
-rawtypes
-RBRACE
-RBRACKET
-rdata
-readcolumn
-recv
-reencode
-reencoding
-regex
-RESULTSET
-returncode
-rhs
-rmi
-rossa
-RRID
-sde
-SEPARATORCHAR
-sequencefile
-serde
-serdeing
-SERDEPROPERTIES
-serializer
-shiftbits
-SInt
-SINTSTRING
-SJAAAADUl
-slist
-SLITHEEN
-smallint
-soi
-spoi
-sql
-src
-ssoi
-sti
-stringify
-stringlist
-stringset
-STRINGVALUE
-strtod
-structlist
-structs
-structset
-STX
-stype
-subrecord
-superfield
-sys
-TApplication
-TBase
-TBinary
-tbl
-tblproperties
-TBool
-TByte
-TColumn
-TCompact
-TConfiguration
-TConstant
-TCTL
-TDouble
-TEnum
-teradata
-testcompare
-testfield
-testget
-testi
-testthrift
-TException
-TEXTFILE
-TField
-TFrozen
-threebytes
-Throwable
-timelabel
-TIMESTAMPLOCALTZ
-timestamptz
-timezone
-TInput
-tinyint
-TIO
-tlist
-tmap
-TMemory
-TMessage
-tmp
-todo
-tokenized
-tokenizer
-tokenizing
-TOutput
-tprotocol
-TRecursive
-TReflection
-TRegex
-tsd
-TSet
-tsoi
-TSOP
-TSPEC
-TString
-tstruct
-tstz
-tsw
-TTo
-ttransport
-TTuple
-ttype
-TUnion
-typedef
-typeinfo
-typestring
-udf
-uint
-ULong
-uncompressing
-unescape
-unicode
-Uniob
-UNIONFIELD
-UNIONMSTRINGSTRING
-uniontype
-uoi
-uri
-urie
-url
-usoi
-utf
-Utils
-utype
-uuid
-vals
-varbyte
-varchar
-varname
-vchar
-versioned
-vidt
-vints
-viter
-viyt
-vlong
-voi
-vtype
-wkid
-workaround
-writables
-www
-XDh
-xfer
-xml
-xmlns
-xsi
-yadda
-yes'okay
-YYYYMMDD
-zid
diff --git a/.github/actions/spelling/only.txt
b/.github/actions/spelling/only.txt
deleted file mode 100644
index a1dd009c742..00000000000
--- a/.github/actions/spelling/only.txt
+++ /dev/null
@@ -1 +0,0 @@
-^serde/
diff --git a/.github/actions/spelling/patterns.txt
b/.github/actions/spelling/patterns.txt
deleted file mode 100644
index 46eb924fe57..00000000000
--- a/.github/actions/spelling/patterns.txt
+++ /dev/null
@@ -1,40 +0,0 @@
-# See
https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns
-
-# stackexchange -- https://stackexchange.com/feeds/sites
-\b(?:askubuntu|serverfault|stack(?:exchange|overflow)|superuser).com/questions/\d+/[a-z-]+
-# w3
-\bw3\.org/[-0-9a-zA-Z/#.]+
-# mvnrepository.com
-\bmvnrepository\.com/[-0-9a-z./]+
-# URL escaped characters
-\%[0-9A-F]{2}
-# sha-1
-"[0-9a-f]{40}"
-# hex digits including css/html color classes:
-(?:[\\0][xX]|\\u|[uU]\+|#|\%23)[0-9a-fA-FgGrR]{2,}[uU]?[lL]{0,2}\b
-# uuid:
-[{"'][0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}['"}]
-# curl arguments
-\b(?:)curl(?:\s+-[a-zA-Z]+)+
-# tar arguments
-\b(?:)tar(?:\s+-[a-zA-Z]+|\s[a-z]+)+
-# decode
-\.decode\("[0-9a-zA-Z]+"
-#
-"[0-9a-f]{80,}"
-# pom.xml
-<(additionalClasspathElement|arg|(?:artifact|group)Id|id|installDir|jvmArgs|mainClass|shadedClassifierName|template(?:Base|Source|Output)Dir|version)>[^<]*</\1>
-\b(?:(?:build|template(?:Base|Source|Output))Dir|(?:to|)dir|location)="[^"]*"
-xsi:schemaLocation="[^"]*"
-# java
-\bimport (?:com|org)\.[a-z0-9.]*\b
-#
ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/hooks/proto/HiveHookEvents.java
-016Hiv"
-# serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java
-\bNULLable\b
-#
serde/src/test/org/apache/hadoop/hive/serde2/lazy/fast/TestLazySimpleDeserializeRead.java
-"This\\{1,2}n..*"
-# ignore long runs of a single character:
-\b([A-Za-z])\g{-1}{3,}\b
-# Skip spell check on URLs
-\b(?i:https?)://\S+
diff --git a/.github/actions/spelling/reject.txt
b/.github/actions/spelling/reject.txt
deleted file mode 100644
index a5ba6f6390e..00000000000
--- a/.github/actions/spelling/reject.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-^attache$
-benefitting
-occurence
-Sorce
-^[Ss]pae
-^untill
-^wether
diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml
deleted file mode 100644
index 2cf34d60a95..00000000000
--- a/.github/workflows/spelling.yml
+++ /dev/null
@@ -1,85 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-name: Spell checking
-on:
- push:
- branches: ["**"]
- tags-ignore: ["**"]
- pull_request_target:
-
-jobs:
- spelling:
- name: Spell checking
- permissions:
- contents: read
- pull-requests: read
- outputs:
- internal_state_directory: ${{
steps.spelling.outputs.internal_state_directory }}
- runs-on: ubuntu-latest
- if: "contains(github.event_name, 'pull_request') || github.event_name ==
'push'"
- concurrency:
- group: spelling-${{ github.event.pull_request.number || github.ref }}
- # note: If you use only_check_changed_files, you do not want
cancel-in-progress
- cancel-in-progress: true
- steps:
- - name: checkout-merge
- if: "contains(github.event_name, 'pull_request')"
- uses: actions/checkout@v4
- with:
- ref: refs/pull/${{github.event.pull_request.number}}/merge
- - name: checkout
- if: github.event_name == 'push'
- uses: actions/checkout@v4
- - name: check-spelling
- id: spelling
- uses: check-spelling/[email protected]
- with:
- suppress_push_for_open_pull_request: 1
- post_comment: 0
- - name: store-comment
- if: failure()
- uses: actions/upload-artifact@v4
- with:
- retention-days: 1
- name: "check-spelling-comment-${{ github.run_id }}"
- path: |
- ${{ steps.spelling.outputs.internal_state_directory }}
-
- comment:
- name: Comment
- runs-on: ubuntu-latest
- needs: spelling
- permissions:
- contents: write
- pull-requests: write
- if: always() && needs.spelling.result == 'failure' &&
needs.spelling.outputs.internal_state_directory
- steps:
- - name: checkout
- uses: actions/checkout@v4
- - name: set up
- run: |
- mkdir /tmp/data
- - name: retrieve-comment
- uses: actions/download-artifact@v4
- with:
- name: "check-spelling-comment-${{ github.run_id }}"
- path: /tmp/data
- - name: comment
- uses: check-spelling/[email protected]
- with:
- custom_task: comment
- internal_state_directory: /tmp/data
