This is an automated email from the ASF dual-hosted git repository.
okumin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push:
new c046551541d HIVE-29264: Use metaconf prefix to honor metastore
configurations for direct sql in q-files (#6129)
c046551541d is described below
commit c046551541d81db73b1fae368e19fd0a63ab8bb6
Author: Raghav Aggarwal <[email protected]>
AuthorDate: Sun Oct 19 08:37:12 2025 +0530
HIVE-29264: Use metaconf prefix to honor metastore configurations for
direct sql in q-files (#6129)
* HIVE-29264: Use metaconf prefix to honor metastore configurations for
direct sql in q-files
* address review comments
---
ql/src/test/queries/clientpositive/alter_rename_table.q | 2 +-
ql/src/test/queries/clientpositive/alter_table_column_stats.q | 8 ++++----
ql/src/test/queries/clientpositive/create_with_constraints.q | 2 +-
ql/src/test/queries/clientpositive/default_constraint.q | 2 +-
.../queries/clientpositive/rename_table_update_column_stats.q | 4 ++--
ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q | 2 +-
6 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/ql/src/test/queries/clientpositive/alter_rename_table.q
b/ql/src/test/queries/clientpositive/alter_rename_table.q
index bcf6ad563b2..c45b339bae7 100644
--- a/ql/src/test/queries/clientpositive/alter_rename_table.q
+++ b/ql/src/test/queries/clientpositive/alter_rename_table.q
@@ -39,7 +39,7 @@ ALTER TABLE source.src RENAME TO target.src1;
select * from target.src1 tablesample (10 rows);
set metastore.rawstore.batch.size=1;
-set metastore.try.direct.sql=false;
+set metaconf:metastore.try.direct.sql=false;
create table source.src2 like default.src;
load data local inpath '../../data/files/kv1.txt' overwrite into table
source.src2;
diff --git a/ql/src/test/queries/clientpositive/alter_table_column_stats.q
b/ql/src/test/queries/clientpositive/alter_table_column_stats.q
index 16888c049ff..cd699b32dc3 100644
--- a/ql/src/test/queries/clientpositive/alter_table_column_stats.q
+++ b/ql/src/test/queries/clientpositive/alter_table_column_stats.q
@@ -2,7 +2,7 @@
--! qt:dataset:part
set hive.mapred.mode=nonstrict;
-set hive.metastore.try.direct.sql=true;
+set metaconf:metastore.try.direct.sql=true;
drop database if exists statsdb1;
create database statsdb1;
@@ -134,7 +134,7 @@ use default;
drop database statsdb1;
drop database statsdb2;
-set hive.metastore.try.direct.sql=false;
+set metaconf:metastore.try.direct.sql=false;
drop database if exists statsdb1;
create database statsdb1;
@@ -266,8 +266,8 @@ use default;
drop database statsdb1;
drop database statsdb2;
--- Test for external tables with hive.metastore.try.direct.sql.ddl as false
-set hive.metastore.try.direct.sql.ddl=false;
+-- Test for external tables with metastore.try.direct.sql.ddl as false
+set metaconf:metastore.try.direct.sql.ddl=false;
drop database if exists statsdb1;
create database statsdb1;
diff --git a/ql/src/test/queries/clientpositive/create_with_constraints.q
b/ql/src/test/queries/clientpositive/create_with_constraints.q
index 084ca8d8c1f..4cb6796558e 100644
--- a/ql/src/test/queries/clientpositive/create_with_constraints.q
+++ b/ql/src/test/queries/clientpositive/create_with_constraints.q
@@ -144,7 +144,7 @@ ALTER TABLE table23 ADD CONSTRAINT pk23_1 PRIMARY KEY (b)
DISABLE RELY;
DESCRIBE FORMATTED table23;
-set hive.metastore.try.direct.sql=false;
+set metaconf:metastore.try.direct.sql=false;
CREATE TABLE numericDataType_n0(a TINYINT, b SMALLINT NOT NULL ENABLE, c INT,
d BIGINT , e DOUBLE , f DECIMAL(9,2));
INSERT INTO numericDataType_n0 values(2,45,5667,67890,5.6,678.5);
diff --git a/ql/src/test/queries/clientpositive/default_constraint.q
b/ql/src/test/queries/clientpositive/default_constraint.q
index 36aa894c5f2..e3aeddc6fb8 100644
--- a/ql/src/test/queries/clientpositive/default_constraint.q
+++ b/ql/src/test/queries/clientpositive/default_constraint.q
@@ -148,7 +148,7 @@ INSERT INTO tablePartitioned_n0 partition(p1='today',
p2=10) values('not', 'null
DROP TABLE tablePartitioned_n0;
-- try constraint with direct sql as false
-set hive.metastore.try.direct.sql=false;
+set metaconf:metastore.try.direct.sql=false;
CREATE TABLE numericDataType_n1(a TINYINT CONSTRAINT tinyint_constraint
DEFAULT 127Y ENABLE, b SMALLINT DEFAULT 32767S, c INT DEFAULT 2147483647,
d BIGINT DEFAULT 9223372036854775807L, e DOUBLE DEFAULT 3.4E38, f
DECIMAL(9,2) DEFAULT 1234567.89)
clustered by (b) into 2 buckets stored as orc TBLPROPERTIES
('transactional'='true');
diff --git
a/ql/src/test/queries/clientpositive/rename_table_update_column_stats.q
b/ql/src/test/queries/clientpositive/rename_table_update_column_stats.q
index c220d44820e..eb8b2579cd6 100644
--- a/ql/src/test/queries/clientpositive/rename_table_update_column_stats.q
+++ b/ql/src/test/queries/clientpositive/rename_table_update_column_stats.q
@@ -1,6 +1,6 @@
--! qt:dataset:src
set hive.mapred.mode=nonstrict;
-set hive.metastore.try.direct.sql=true;
+set metaconf:metastore.try.direct.sql=true;
drop database if exists statsdb1;
create database statsdb1;
@@ -28,7 +28,7 @@ drop database statsdb1 cascade;
drop database statsdb2 cascade;
-set hive.metastore.try.direct.sql=false;
+set metaconf:metastore.try.direct.sql=false;
drop database if exists statsdb1;
create database statsdb1;
diff --git a/ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q
b/ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q
index 50e2993d89d..84246b0de2a 100644
--- a/ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q
+++ b/ql/src/test/queries/clientpositive/repl_4_exim_nocolstat.q
@@ -2,7 +2,7 @@ set hive.mapred.mode=nonstrict;
set hive.test.mode=true;
set hive.test.mode.prefix=;
set hive.test.mode.nosamplelist=replsrc,repldst;
-set metastore.try.direct.sql=false;
+set metaconf:metastore.try.direct.sql=false;
set hive.metastore.rawstore.impl=org.apache.hadoop.hive.metastore.ObjectStore;
set hive.repl.run.data.copy.tasks.on.target=false;
