This is an automated email from the ASF dual-hosted git repository. asf-gitbox-commits pushed a commit to branch HIVE-29591-precommit-image in repository https://gitbox.apache.org/repos/asf/hive.git
commit 5a54d956eac84dc6508381206b156b0f5fd354dd Author: Laszlo Bodor <[email protected]> AuthorDate: Wed Nov 11 13:30:28 2026 +0100 apache/hive-ci-runner --- .github/workflows/precommit-image.yml | 8 ++++---- Jenkinsfile | 2 +- dev-support/docker/precommit/README.md | 19 ++++++++++--------- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/.github/workflows/precommit-image.yml b/.github/workflows/precommit-image.yml index 380029acb47..fe91e94335c 100644 --- a/.github/workflows/precommit-image.yml +++ b/.github/workflows/precommit-image.yml @@ -15,7 +15,7 @@ # limitations under the License. # Builds the precommit image (dev-support/docker/precommit) and smoke tests it. On master it -# publishes the image as apache/hive:precommit, the image the Jenkinsfile runs in. +# publishes the image as apache/hive-ci-runner, the image the Jenkinsfile runs in. name: Precommit image on: @@ -32,9 +32,9 @@ on: workflow_dispatch: inputs: tag: - description: 'Tag to publish; use a custom one (e.g. precommit-candidate-HIVE-12345) to try an image with the IMAGE parameter of the precommit job' + description: 'Tag to publish; use a custom one (e.g. HIVE-12345) to try an image with the IMAGE parameter of the precommit job' required: true - default: 'precommit' + default: 'latest' permissions: contents: read @@ -43,7 +43,7 @@ jobs: build: runs-on: ubuntu-latest env: - IMAGE: ${{ github.repository_owner }}/hive:${{ github.event.inputs.tag || 'precommit' }} + IMAGE: ${{ github.repository_owner }}/hive-ci-runner:${{ github.event.inputs.tag || 'latest' }} steps: - name: Checkout uses: actions/checkout@v6 diff --git a/Jenkinsfile b/Jenkinsfile index 6d772605753..fef0cf9fe5f 100644 --- a/Jenkinsfile +++ b/Jenkinsfile @@ -36,7 +36,7 @@ properties([ ]) // Built from dev-support/docker/precommit/Dockerfile and pushed by .github/workflows/precommit-image.yml. -this.precommitImage = 'apache/hive:precommit' +this.precommitImage = 'apache/hive-ci-runner' this.prHead = null; def checkPrHead() { diff --git a/dev-support/docker/precommit/README.md b/dev-support/docker/precommit/README.md index 6bcffbf0458..ea89a314a7c 100644 --- a/dev-support/docker/precommit/README.md +++ b/dev-support/docker/precommit/README.md @@ -40,9 +40,10 @@ during the build. Before adding a package, check whether Maven can provide it in The [precommit-image](../../../.github/workflows/precommit-image.yml) workflow builds the image and smoke tests it on every pull request that changes this directory. When such a change lands on master, the workflow publishes the image for `linux/amd64` and `linux/arm64` -as `apache/hive:precommit`. That tag is the `precommitImage` of the Jenkinsfile, and -the precommit job pulls it again on every run. The tag is overwritten on every publish: -once the change is merged, every precommit run, on every branch, uses the new image. +as `apache/hive-ci-runner` (the default `latest` tag). That is the `precommitImage` of the +Jenkinsfile, and the precommit job pulls it again on every run. The tag is overwritten on +every publish: once the change is merged, every precommit run, on every branch, uses the new +image. ## Changing the image, step by step @@ -158,7 +159,7 @@ When you are done, remove the docker daemon with `docker rm -f -v hive-dind`. Open the pull request as usual. The precommit-image workflow builds the image and runs the smoke test on it. The precommit job of the pull request itself still runs in the published -`apache/hive:precommit`, not in your change. +`apache/hive-ci-runner`, not in your change. ### 9. Run the precommit job with the candidate image @@ -167,7 +168,7 @@ merging. This needs a committer. 1. Publish the candidate under a tag of its own. Either: * push the change to a branch of `apache/hive` and run the precommit-image workflow on that - branch from the Actions tab, with `tag` set to e.g. `precommit-candidate-HIVE-12345`; or + branch from the Actions tab, with `tag` set to e.g. `HIVE-12345`; or * build it for amd64 and push it to a registry you control: ```bash @@ -176,24 +177,24 @@ merging. This needs a committer. ``` 2. On the precommit job of the pull request in Jenkins, choose *Build with Parameters* and set - `IMAGE` to the candidate, e.g. `apache/hive:precommit-candidate-HIVE-12345`. The parameter + `IMAGE` to the candidate, e.g. `apache/hive-ci-runner:HIVE-12345`. The parameter is only offered after the job has run at least once with this Jenkinsfile. 3. Link the green run in the pull request. ### 10. Merge and verify Once merged, the precommit-image workflow on master publishes -`apache/hive:precommit`. Then: +`apache/hive-ci-runner`. Then: 1. Check that the workflow run succeeded. 2. Check the published image: ```bash - docker buildx imagetools inspect apache/hive:precommit + docker buildx imagetools inspect apache/hive-ci-runner ``` 3. Watch the next precommit runs. To roll back, revert the commit. The workflow then publishes the previous Dockerfile as -`precommit` again. The rebuilt image picks up the Debian packages current at that time, +`latest` again. The rebuilt image picks up the Debian packages current at that time, so it is equivalent to the old one but not identical.
