(hop) branch main updated: Fix documentation for supported mail protocols (#6861)

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new dd6e4ddd2b Fix documentation for supported mail protocols (#6861)
dd6e4ddd2b is described below

commit dd6e4ddd2ba13b75877888d5338b4947ff344785
Author: lance <leeh...@gmail.com>
AuthorDate: Wed Mar 25 00:20:47 2026 +0800

    Fix documentation for supported mail protocols (#6861)
    
    Signed-off-by: lance <leeh...@gmail.com>
---
 .../ROOT/pages/metadata-types/mail-server-connection.adoc        | 2 +-
 .../org/apache/hop/mail/metadata/MailServerConnectionEditor.java | 9 +++------
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git 
a/docs/hop-user-manual/modules/ROOT/pages/metadata-types/mail-server-connection.adoc
 
b/docs/hop-user-manual/modules/ROOT/pages/metadata-types/mail-server-connection.adoc
index 17a847611c..e830ec5911 100644
--- 
a/docs/hop-user-manual/modules/ROOT/pages/metadata-types/mail-server-connection.adoc
+++ 
b/docs/hop-user-manual/modules/ROOT/pages/metadata-types/mail-server-connection.adoc
@@ -33,7 +33,7 @@ xref:workflow/actions/mail.adoc[Mail] action
 |===
 |Option |Description
 |Connection name|The name to use for this mail server connection
-|Connection protocol|The connection protocol to use for this connection. 
Supported options are SMTP, IMAP, POP, MBOX (Only SMTP is currently supported).
+|Connection protocol|The connection protocol to use for this connection. 
Supported options are SMTP, IMAP, and POP. MBOX is currently not supported.
 |Server host|The mail server hostname to use for this connection
 |Server port|The mail server port to use for this connection
 |Use authentication?|Use authentication with this connection?
diff --git 
a/plugins/misc/mail/src/main/java/org/apache/hop/mail/metadata/MailServerConnectionEditor.java
 
b/plugins/misc/mail/src/main/java/org/apache/hop/mail/metadata/MailServerConnectionEditor.java
index 906c8f78d5..3bf71500fe 100644
--- 
a/plugins/misc/mail/src/main/java/org/apache/hop/mail/metadata/MailServerConnectionEditor.java
+++ 
b/plugins/misc/mail/src/main/java/org/apache/hop/mail/metadata/MailServerConnectionEditor.java
@@ -173,7 +173,7 @@ public class MailServerConnectionEditor extends 
MetadataEditor<MailServerConnect
     FormData fdlUseAuthenticationLabel = new FormData();
     fdlUseAuthenticationLabel.top = new FormAttachment(lastControl, margin);
     fdlUseAuthenticationLabel.left = new FormAttachment(0, 0);
-    fdlUseAuthenticationLabel.right = new FormAttachment(middle, 0);
+    fdlUseAuthenticationLabel.right = new FormAttachment(middle, -margin);
     wlUseAuthenticationLabel.setLayoutData(fdlUseAuthenticationLabel);
     wUseAuthentication = new Button(composite, SWT.CHECK | SWT.LEFT);
     PropsUi.setLook(wUseAuthentication);
@@ -275,7 +275,6 @@ public class MailServerConnectionEditor extends 
MetadataEditor<MailServerConnect
     fdSecureConnectionType.left = new FormAttachment(middle, 0);
     fdSecureConnectionType.right = new FormAttachment(100, 0);
     wSecureConnectionType.setLayoutData(fdSecureConnectionType);
-    String[] secureConnectionType = new String[] {"SSL", "TLS", "TLS 1.2"};
     lastControl = wSecureConnectionType;
 
     // Use check server identity
@@ -285,8 +284,8 @@ public class MailServerConnectionEditor extends 
MetadataEditor<MailServerConnect
     PropsUi.setLook(wlCheckServerIdentity);
     FormData fdlCheckServerIdentity = new FormData();
     fdlCheckServerIdentity.left = new FormAttachment(0, 0);
-    fdlCheckServerIdentity.top = new FormAttachment(lastControl, 0);
-    fdlCheckServerIdentity.right = new FormAttachment(middle, 0);
+    fdlCheckServerIdentity.top = new FormAttachment(lastControl, margin);
+    fdlCheckServerIdentity.right = new FormAttachment(middle, -margin);
     wlCheckServerIdentity.setLayoutData(fdlCheckServerIdentity);
     wCheckServerIdentity = new Button(composite, SWT.CHECK | SWT.LEFT);
     PropsUi.setLook(wCheckServerIdentity);
@@ -302,7 +301,6 @@ public class MailServerConnectionEditor extends 
MetadataEditor<MailServerConnect
             setChanged();
           }
         });
-    lastControl = wCheckServerIdentity;
 
     // Trusted Hosts line
     wTrustedHosts =
@@ -369,7 +367,6 @@ public class MailServerConnectionEditor extends 
MetadataEditor<MailServerConnect
     fdProxyPassword.left = new FormAttachment(middle, 0);
     fdProxyPassword.right = new FormAttachment(100, 0);
     wProxyPassword.setLayoutData(fdProxyPassword);
-    lastControl = wProxyPassword;
 
     setWidgetsContent();