(hop) branch main updated: Using the default hashCode/equals implementation (#6983)

[hansva]

This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new 53c4ccf3eb Using the default hashCode/equals implementation (#6983)
53c4ccf3eb is described below

commit 53c4ccf3eb858fb50f4c5feafdd5015f6cf33dac
Author: Lance <leeh...@gmail.com>
AuthorDate: Fri Apr 10 16:11:05 2026 +0800

    Using the default hashCode/equals implementation (#6983)
    
    Signed-off-by: lance <leeh...@gmail.com>
---
 .../src/main/java/org/apache/hop/core/BaseRowSet.java | 19 -------------------
 .../java/org/apache/hop/core/BaseRowSetTests.java     |  6 ++++--
 2 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/core/src/main/java/org/apache/hop/core/BaseRowSet.java 
b/core/src/main/java/org/apache/hop/core/BaseRowSet.java
index 45b3905c07..ff1353f080 100644
--- a/core/src/main/java/org/apache/hop/core/BaseRowSet.java
+++ b/core/src/main/java/org/apache/hop/core/BaseRowSet.java
@@ -17,7 +17,6 @@
 
 package org.apache.hop.core;
 
-import java.util.Objects;
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.locks.ReadWriteLock;
@@ -79,24 +78,6 @@ abstract class BaseRowSet implements Comparable<IRowSet>, 
IRowSet {
     return target.compareTo(comp);
   }
 
-  @Override
-  public boolean equals(Object o) {
-    if (this == o) {
-      return true;
-    }
-    if (!(o instanceof IRowSet other)) {
-      return false;
-    }
-
-    return compareTo(other) == 0;
-  }
-
-  @Override
-  public int hashCode() {
-    return Objects.hash(
-        remoteHopServerName, destinationTransformName, 
destinationTransformCopy.get());
-  }
-
   /*
    * (non-Javadoc)
    *
diff --git a/core/src/test/java/org/apache/hop/core/BaseRowSetTests.java 
b/core/src/test/java/org/apache/hop/core/BaseRowSetTests.java
index 4f0f4bff10..efb2dab40a 100644
--- a/core/src/test/java/org/apache/hop/core/BaseRowSetTests.java
+++ b/core/src/test/java/org/apache/hop/core/BaseRowSetTests.java
@@ -50,8 +50,10 @@ class BaseRowSetTests {
     r2.setThreadNameFromToCopy("X", 9, "B", 2);
 
     assertEquals(0, r1.compareTo(r2));
-    assertEquals(r1, r2);
-    assertEquals(r1.hashCode(), r2.hashCode());
+    assertNotEquals(r1, r2);
+    assertNotEquals(r1.hashCode(), r2.hashCode());
+
+    assertEquals(0, r1.compareTo(r2));
   }
 
   @Test