(hop) branch main updated: Issue #7003 (Combination Lookup importer fix) (#7039)

[mcasters]

This is an automated email from the ASF dual-hosted git repository.

mattcasters pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new d950a4b90b Issue #7003 (Combination Lookup importer fix) (#7039)
d950a4b90b is described below

commit d950a4b90b0daa9b0523cb2af993f2e881730df8
Author: Matt Casters <mattcast...@gmail.com>
AuthorDate: Wed Apr 22 17:59:08 2026 +0200

    Issue #7003 (Combination Lookup importer fix) (#7039)
    
    Issue #7003 (Combination Lookup importer fix)
---
 .../transforms/combinationlookup/CFields.java      | 58 ++--------------------
 .../combinationlookup/CombinationLookupMeta.java   | 14 ++++++
 2 files changed, 18 insertions(+), 54 deletions(-)

diff --git 
a/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CFields.java
 
b/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CFields.java
index be2a927eee..bb822b51c3 100644
--- 
a/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CFields.java
+++ 
b/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CFields.java
@@ -20,8 +20,12 @@ package org.apache.hop.pipeline.transforms.combinationlookup;
 
 import java.util.ArrayList;
 import java.util.List;
+import lombok.Getter;
+import lombok.Setter;
 import org.apache.hop.metadata.api.HopMetadataProperty;
 
+@Getter
+@Setter
 public class CFields {
   /** which fields do we use to look up a value? */
   @HopMetadataProperty(
@@ -63,58 +67,4 @@ public class CFields {
     }
     return -1;
   }
-
-  /**
-   * Gets keyFields
-   *
-   * @return value of keyFields
-   */
-  public List<KeyField> getKeyFields() {
-    return keyFields;
-  }
-
-  /**
-   * Sets keyFields
-   *
-   * @param keyFields value of keyFields
-   */
-  public void setKeyFields(List<KeyField> keyFields) {
-    this.keyFields = keyFields;
-  }
-
-  /**
-   * Gets sequenceFrom
-   *
-   * @return value of sequenceFrom
-   */
-  public String getSequenceFrom() {
-    return sequenceFrom;
-  }
-
-  /**
-   * Sets sequenceFrom
-   *
-   * @param sequenceFrom value of sequenceFrom
-   */
-  public void setSequenceFrom(String sequenceFrom) {
-    this.sequenceFrom = sequenceFrom;
-  }
-
-  /**
-   * Gets returnFields
-   *
-   * @return value of returnFields
-   */
-  public ReturnFields getReturnFields() {
-    return returnFields;
-  }
-
-  /**
-   * Sets returnFields
-   *
-   * @param returnFields value of returnFields
-   */
-  public void setReturnFields(ReturnFields returnFields) {
-    this.returnFields = returnFields;
-  }
 }
diff --git 
a/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CombinationLookupMeta.java
 
b/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CombinationLookupMeta.java
index 2640b2083d..34835c1e2a 100644
--- 
a/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CombinationLookupMeta.java
+++ 
b/plugins/transforms/combinationlookup/src/main/java/org/apache/hop/pipeline/transforms/combinationlookup/CombinationLookupMeta.java
@@ -20,6 +20,7 @@ package org.apache.hop.pipeline.transforms.combinationlookup;
 import java.util.List;
 import lombok.Getter;
 import lombok.Setter;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.hop.core.CheckResult;
 import org.apache.hop.core.Const;
 import org.apache.hop.core.ICheckResult;
@@ -37,6 +38,7 @@ import org.apache.hop.core.row.value.ValueMetaDate;
 import org.apache.hop.core.row.value.ValueMetaInteger;
 import org.apache.hop.core.util.Utils;
 import org.apache.hop.core.variables.IVariables;
+import org.apache.hop.core.xml.XmlHandler;
 import org.apache.hop.i18n.BaseMessages;
 import org.apache.hop.metadata.api.HopMetadataProperty;
 import org.apache.hop.metadata.api.HopMetadataPropertyType;
@@ -45,6 +47,7 @@ import org.apache.hop.pipeline.DatabaseImpact;
 import org.apache.hop.pipeline.PipelineMeta;
 import org.apache.hop.pipeline.transform.BaseTransformMeta;
 import org.apache.hop.pipeline.transform.TransformMeta;
+import org.w3c.dom.Node;
 
 @Transform(
     id = "CombinationLookup",
@@ -723,4 +726,15 @@ public class CombinationLookupMeta
   public boolean supportsErrorHandling() {
     return true;
   }
+
+  @Override
+  public void convertLegacyXml(Node transformNode) throws HopException {
+    // Facilitating the Kettle importer. (issue 7003)
+    //
+    Node sequenceNode = XmlHandler.getSubNode(transformNode, "sequence");
+    String sequenceName = XmlHandler.getNodeValue(sequenceNode);
+    if (StringUtils.isNotEmpty(sequenceName)) {
+      this.fields.setSequenceFrom(sequenceName);
+    }
+  }
 }