This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new b636f658ff remove the committed jar and trigger les builds, fixes
#8412 (#8413)
b636f658ff is described below
commit b636f658ff9f442459e56b269a5ca6144a35cea2
Author: Hans Van Akelyen <[email protected]>
AuthorDate: Wed Sep 16 12:06:18 2026 +0200
remove the committed jar and trigger les builds, fixes #8412 (#8413)
---
.github/workflows/pr_build_code.yml | 28 ++++++++++++++++++++++++----
.gitignore | 2 --
.mvn/plexus-eclipse-hint.jar | Bin 1408 -> 0 bytes
pom.xml | 24 +++++++++++++++++++++---
4 files changed, 45 insertions(+), 9 deletions(-)
diff --git a/.github/workflows/pr_build_code.yml
b/.github/workflows/pr_build_code.yml
index 208ce67ecc..87364992be 100644
--- a/.github/workflows/pr_build_code.yml
+++ b/.github/workflows/pr_build_code.yml
@@ -19,14 +19,34 @@
name: Hop PR Build (Code)
+# Path filters mirror gib.excludePathsMatching in the root pom: a change
confined to
+# these paths cannot affect the Maven build, so the workflow does not run at
all.
+# Keep both lists in sync when adding an exclusion. (Negation needs `paths`,
not
+# `paths-ignore`; later patterns win.)
on:
push:
- paths-ignore:
- - 'docs/**'
+ paths:
+ - '**'
+ - '!docs/**'
+ - '!docker/**'
+ - '!helm/**'
+ - '!dist/**'
+ - '!integration-tests/**'
+ - '!*.md'
+ - '!Jenkinsfile*'
+ - '!.asf.yaml'
pull_request:
branches: [ 'main' ]
- paths-ignore:
- - 'docs/**'
+ paths:
+ - '**'
+ - '!docs/**'
+ - '!docker/**'
+ - '!helm/**'
+ - '!dist/**'
+ - '!integration-tests/**'
+ - '!*.md'
+ - '!Jenkinsfile*'
+ - '!.asf.yaml'
# Supersede an in-flight PR build when the branch is pushed again; never
cancel a
# push build, so every merge to main keeps its own result.
diff --git a/.gitignore b/.gitignore
index 704edd57e1..752dd3ff69 100644
--- a/.gitignore
+++ b/.gitignore
@@ -13,8 +13,6 @@ pom.xml.releaseBackup
bin
*.class
*.jar
-# Tiny Plexus descriptor so Debian/Ubuntu Maven can find compilerId=eclipse.
-!.mvn/plexus-eclipse-hint.jar
*.war
*.ear
.DS_Store
diff --git a/.mvn/plexus-eclipse-hint.jar b/.mvn/plexus-eclipse-hint.jar
deleted file mode 100644
index bf0e4f1979..0000000000
Binary files a/.mvn/plexus-eclipse-hint.jar and /dev/null differ
diff --git a/pom.xml b/pom.xml
index 054fc6116c..44f956a4e0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -108,6 +108,14 @@
<cyclonedx-maven-plugin.version>2.9.3</cyclonedx-maven-plugin.version>
<gib.buildUpstream>always</gib.buildUpstream>
<gib.disable>true</gib.disable>
+ <!-- Paths that never affect the Maven build result. GIB maps a
changed file to the
+ nearest enclosing module; files outside every module land on the
ROOT module,
+ and every module is downstream of its parent, so a docs- or
integration-test
+ change alone used to turn the PR build into a full rebuild (#8408
built 313/313
+ modules for one new transform). The plugins/<kind>/pom.xml
aggregators are
+ pure <module> lists (adding a plugin edits them); keep them that
way, since
+ anything else put there is not seen by the incremental PR build.
-->
+
<gib.excludePathsMatching>(docs|docker|helm|dist|integration-tests)/.*|plugins/(actions|engines|misc|tech|transforms|valuetypes)/pom\.xml|[^/]+\.md|Jenkinsfile.*|\.asf\.yaml</gib.excludePathsMatching>
<gib.fetchReferenceBranch>true</gib.fetchReferenceBranch>
<!-- lib-p2 wrappers are never published (maven.deploy.skip, and they
are
excluded from the snapshot wagon deploy). Incremental PR builds
must
@@ -423,7 +431,14 @@
</goals>
<phase>validate</phase>
<configuration>
-
<skipScriptExecution>${lombok.ecj.agent.skip}</skipScriptExecution>
+ <!-- The Plexus descriptor jar below is always
(re)built; only the
+ agent attach honours lombok.ecj.agent.skip.
-->
+ <properties>
+ <property>
+ <name>lombokEcjAgentSkip</name>
+ <value>${lombok.ecj.agent.skip}</value>
+ </property>
+ </properties>
<scripts>
<script><![CDATA[
import com.sun.tools.attach.VirtualMachine
@@ -447,7 +462,7 @@ synchronized (System.getProperties()) {
log.info('Wrote Eclipse compiler Plexus descriptor jar: ' + hintJar)
}
- if (System.getProperty('lombok.ecj.agent.skip') != 'true'
+ if (String.valueOf(lombokEcjAgentSkip) != 'true'
&& System.getProperty('lombok.ecj.agent.attached') == null) {
def lombokJar = null
try {
@@ -510,7 +525,10 @@ synchronized (System.getProperties()) {
</dependency>
<!-- Plexus XML registration of compilerId=eclipse.
Required for
Debian/Ubuntu Maven, whose Sisu 0.3.x cannot
ASM-index the
- Java 17 EclipseJavaCompiler class. See
.mvn/plexus-eclipse-hint/. -->
+ Java 17 EclipseJavaCompiler class. The jar is NOT
tracked in git
+ (binaries stay out of the repository): the gmavenplus
execution
+ above writes it from .mvn/plexus-eclipse-hint/ during
validate,
+ which runs before this plugin is resolved in every
module. -->
<dependency>
<groupId>org.apache.hop</groupId>
<artifactId>plexus-eclipse-hint</artifactId>