(hop) branch main updated: Fix ZIP entry size variable metadata (#8796)

[bartmaer]

This is an automated email from the ASF dual-hosted git repository.

bamaer pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new 227ed1fe47 Fix ZIP entry size variable metadata (#8796)
227ed1fe47 is described below

commit 227ed1fe47c0dd20cbeca1d295c95738cd5d742f
Author: Gabriel Dutra <gvdu...@apache.org>
AuthorDate: Thu Oct 8 11:42:05 2026 -0700

    Fix ZIP entry size variable metadata (#8796)
---
 core/src/main/java/org/apache/hop/core/Const.java    |  5 +++--
 .../hop/core/variables/VariableRegistryTest.java     | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/apache/hop/core/Const.java 
b/core/src/main/java/org/apache/hop/core/Const.java
index 04382353ae..19b9eb19ea 100644
--- a/core/src/main/java/org/apache/hop/core/Const.java
+++ b/core/src/main/java/org/apache/hop/core/Const.java
@@ -1001,7 +1001,9 @@ public class Const {
    * @see #HOP_ZIP_MAX_ENTRY_SIZE_DEFAULT
    * @see #HOP_ZIP_MAX_ENTRY_SIZE_DEFAULT_STRING
    */
-  @Variable(description = "A variable to configure the maximum file size of a 
single zip entry")
+  @Variable(
+      value = "4294967295",
+      description = "A variable to configure the maximum file size of a single 
zip entry")
   public static final String HOP_ZIP_MAX_ENTRY_SIZE = "HOP_ZIP_MAX_ENTRY_SIZE";
 
   /**
@@ -1018,7 +1020,6 @@ public class Const {
    * @see #HOP_ZIP_MAX_ENTRY_SIZE
    * @see #HOP_ZIP_MAX_ENTRY_SIZE_DEFAULT
    */
-  @Variable(description = "")
   public static final String HOP_ZIP_MAX_ENTRY_SIZE_DEFAULT_STRING =
       String.valueOf(HOP_ZIP_MAX_ENTRY_SIZE_DEFAULT);
 
diff --git 
a/core/src/test/java/org/apache/hop/core/variables/VariableRegistryTest.java 
b/core/src/test/java/org/apache/hop/core/variables/VariableRegistryTest.java
index 0d16ae3104..2dc0c86d94 100644
--- a/core/src/test/java/org/apache/hop/core/variables/VariableRegistryTest.java
+++ b/core/src/test/java/org/apache/hop/core/variables/VariableRegistryTest.java
@@ -17,9 +17,11 @@
 
 package org.apache.hop.core.variables;
 
+import static org.junit.jupiter.api.Assertions.assertAll;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
 
 import org.apache.hop.core.Const;
 import org.apache.hop.core.HopClientEnvironment;
@@ -50,4 +52,22 @@ class VariableRegistryTest {
         "Specifies the password encoder plugin to use by ID (Hop is the 
default).",
         describedVariable.getDescription());
   }
+
+  @Test
+  void testZipMaxEntrySizeMetadata() throws Exception {
+    HopClientEnvironment.init();
+    TestUtil.registerTestPluginTypes();
+
+    VariableRegistry.init();
+    VariableRegistry registry = VariableRegistry.getInstance();
+    DescribedVariable describedVariable =
+        registry.findDescribedVariable(Const.HOP_ZIP_MAX_ENTRY_SIZE);
+
+    assertNotNull(describedVariable);
+    assertAll(
+        () ->
+            assertEquals(Const.HOP_ZIP_MAX_ENTRY_SIZE_DEFAULT_STRING, 
describedVariable.getValue()),
+        () -> assertFalse(describedVariable.getDescription().isBlank()),
+        () -> 
assertNull(registry.findDescribedVariable("HOP_ZIP_MAX_ENTRY_SIZE_DEFAULT_STRING")));
+  }
 }