This is an automated email from the ASF dual-hosted git repository.
mattcasters pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git
The following commit(s) were added to refs/heads/main by this push:
new 950d0264f6 Issue #8755 : Allow FalkorDB vector scores within 1e-3 of
the exact similarity (#8837)
950d0264f6 is described below
commit 950d0264f6a543688458dedd52c86f7b45344b22
Author: Matt Casters <[email protected]>
AuthorDate: Sat Oct 10 11:06:19 2026 +0200
Issue #8755 : Allow FalkorDB vector scores within 1e-3 of the exact
similarity (#8837)
Nightly integration build 2336 fails FalkorDbIT on the cosine score of the
second hit: 0.780990362167358 against an exact 0.7808688094430303, past the
1e-4 tolerance. The same image returns the exact cosine here, so the index
distance depends on the host. 1e-3 covers that result and stays more than
0.01 away from the euclidean score for these vectors.
fixes #8755
---
.../src/test/java/org/apache/hop/falkordb/FalkorDbIT.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/plugins/tech/falkordb/src/test/java/org/apache/hop/falkordb/FalkorDbIT.java
b/plugins/tech/falkordb/src/test/java/org/apache/hop/falkordb/FalkorDbIT.java
index 18dd97b3df..79f94b7137 100644
---
a/plugins/tech/falkordb/src/test/java/org/apache/hop/falkordb/FalkorDbIT.java
+++
b/plugins/tech/falkordb/src/test/java/org/apache/hop/falkordb/FalkorDbIT.java
@@ -397,8 +397,12 @@ class FalkorDbIT {
}
}
- /** The vectors are stored as 32 bit floats. */
- private static final double SCORE_TOLERANCE = 1e-4;
+ /**
+ * FalkorDB stores the vectors as 32-bit floats. Its vector index has
returned the cosine
+ * similarity 1.2e-4 away from the exact value, which nightly integration
build 2336 rejected at
+ * 1e-4. 1e-3 still leaves the cosine and euclidean scores for these vectors
more than 0.01 apart.
+ */
+ private static final double SCORE_TOLERANCE = 1e-3;
/**
* The score for the query vector [0.9, 0.1, 0] and the stored vectors [1,
0, 0] and [0.7, 0.7,