Adalennis opened a new pull request, #305:
URL: https://github.com/apache/hop-website/pull/305

   Fixes apache/hop#9381
   
   The Antora-only rebuild (#280) dropped the `.image-doc-icon img` rule added 
in #159, so the icon in a page title is shown at the size its SVG declares. 
Most icons declare 42px, but some are much larger or have no size, for example 
Pipeline executor (512px) or Azure Event Hubs (2500px), and fill the page next 
to the title.
   
   This adds the rule back to `ui/css/site.css` with a fixed width of 42px:
   
   - Icons that declare 42px don't change.
   - The 21 large ones shrink to 42px.
   - The 24px and 32px ones (Beam, Spark, Embed text and others) grow to 42px, 
so every title icon has the same size, as on the old site.
   - Three pages set their own width in the title (Execution information 20%, 
MS SQL Server and Vertica bulk loaders 60px). They get 42px too.
   
   The selector only matches the icon in the `<h1>` of a manual page: 
`role="image-doc-icon"` is only used in page titles, and `site.css` is only 
loaded by the manual and the 404 page, not by the Astro pages.
   
   Checked with `npm run build:local` on Pipeline executor, Azure Event Hubs 
listener, CSV input, Embed text, Execution information (dark mode) and MS SQL 
Server Bulk Loader (390px wide).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to