This is an automated email from the ASF dual-hosted git repository.

hansva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/hop.git


The following commit(s) were added to refs/heads/main by this push:
     new 212dc44d54 Add dedicated icons for Google Storage and regional 
settings, fixes #9536 (#9535)
212dc44d54 is described below

commit 212dc44d54f9dbd275692081c8679e9ef40c8a1d
Author: Nicolas Adment <[email protected]>
AuthorDate: Wed Nov 18 09:40:08 2026 +0100

    Add dedicated icons for Google Storage and regional settings, fixes #9536 
(#9535)
    
    - Google Storage metadata type: google-storage.svg instead of the generic 
authentication icon
    - Regional settings configuration tab: new globe.svg instead of the options 
icon
    
    Co-authored-by: Claude Fable 5.2 <[email protected]>
---
 .../org/apache/hop/vfs/gs/metadatatype/GoogleStorageMetadataType.java  | 2 +-
 plugins/tech/google/src/main/resources/google-storage.svg              | 1 +
 ui/src/main/java/org/apache/hop/ui/core/gui/GuiResource.java           | 3 +++
 .../perspective/configuration/tabs/ConfigRegionalSettingsTab.java      | 2 +-
 ui/src/main/resources/ui/images/globe.svg                              | 3 +++
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git 
a/plugins/tech/google/src/main/java/org/apache/hop/vfs/gs/metadatatype/GoogleStorageMetadataType.java
 
b/plugins/tech/google/src/main/java/org/apache/hop/vfs/gs/metadatatype/GoogleStorageMetadataType.java
index 00fa23c5e9..1c683ea89b 100644
--- 
a/plugins/tech/google/src/main/java/org/apache/hop/vfs/gs/metadatatype/GoogleStorageMetadataType.java
+++ 
b/plugins/tech/google/src/main/java/org/apache/hop/vfs/gs/metadatatype/GoogleStorageMetadataType.java
@@ -32,7 +32,7 @@ import org.apache.hop.metadata.api.IHopMetadata;
     legacyKeys = {"GoogleStorageConnectionDefinition"},
     name = "i18n::GoogleStorageMetadataType.Name",
     description = "i18n::GoogleStorageMetadataType.Description",
-    image = "ui/images/authentication.svg",
+    image = "google-storage.svg",
     category = HopMetadataCategory.FILE_STORAGE,
     documentationUrl = "/metadata-types/google-storage-authentication.html",
     hopMetadataPropertyType = HopMetadataPropertyType.VFS_GCP_CONNECTION,
diff --git a/plugins/tech/google/src/main/resources/google-storage.svg 
b/plugins/tech/google/src/main/resources/google-storage.svg
new file mode 100644
index 0000000000..cb31bf5c44
--- /dev/null
+++ b/plugins/tech/google/src/main/resources/google-storage.svg
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 24 24"><defs><clipPath 
id="b"><path 
d="M20,11H4c-.55,0-1-.45-1-1v-6c0-.55.45-1,1-1h16c.55,0,1,.45,1,1v6c0,.55-.45,1-1,1ZM5,9h14v-4H5v4Z"
 fill="none" stroke-width="0"/></clipPath><clipPath id="c"><path 
d="M20,20.97H4c-.55,0-1-.45-1-1v-5.97c0-.55.45-1,1-1h16c.55,0,1,.45,1,1v5.97c0,.55-.45,1-1,1ZM5,18.97h14v-3.97H5v3.97Z"
 fill="none" stroke-width="0"/></clipPath></defs><path 
d="M20,11H4c-.55,0-1-.45-1-1v-6c0-.55.45-1,1-1h16c.55,0,1,.45,1, [...]
\ No newline at end of file
diff --git a/ui/src/main/java/org/apache/hop/ui/core/gui/GuiResource.java 
b/ui/src/main/java/org/apache/hop/ui/core/gui/GuiResource.java
index ac104fcb8d..9ba142cba8 100644
--- a/ui/src/main/java/org/apache/hop/ui/core/gui/GuiResource.java
+++ b/ui/src/main/java/org/apache/hop/ui/core/gui/GuiResource.java
@@ -238,6 +238,7 @@ public class GuiResource {
   @Getter private Image imageExpandAll;
   @Getter private Image imageFindReplace;
   @Getter private Image imageFunction;
+  @Getter private Image imageGlobe;
   @Getter private Image imageKeyboard;
   @Getter private Image imageHelp;
   @Getter private Image imageHide;
@@ -562,6 +563,7 @@ public class GuiResource {
     disposeImage(imageDown);
     disposeImage(imageDuplicate);
     disposeImage(imageFunction);
+    disposeImage(imageGlobe);
     disposeImage(imageKeyboard);
     disposeImage(imageHelp);
     disposeImage(imageHide);
@@ -834,6 +836,7 @@ public class GuiResource {
     imageFindReplace =
         loadAsResource(display, "ui/images/find-replace.svg", 
ConstUi.SMALL_ICON_SIZE);
     imageFunction = loadAsResource(display, "ui/images/function.svg", 
ConstUi.SMALL_ICON_SIZE);
+    imageGlobe = loadAsResource(display, "ui/images/globe.svg", 
ConstUi.SMALL_ICON_SIZE);
     imageKeyboard = loadAsResource(display, "ui/images/keyboard.svg", 
ConstUi.SMALL_ICON_SIZE);
     imageMarketplace =
         loadAsResource(display, "ui/images/marketplace.svg", 
ConstUi.SMALL_ICON_SIZE);
diff --git 
a/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/configuration/tabs/ConfigRegionalSettingsTab.java
 
b/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/configuration/tabs/ConfigRegionalSettingsTab.java
index 5eb575568b..2d4301a1c8 100644
--- 
a/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/configuration/tabs/ConfigRegionalSettingsTab.java
+++ 
b/ui/src/main/java/org/apache/hop/ui/hopgui/perspective/configuration/tabs/ConfigRegionalSettingsTab.java
@@ -98,7 +98,7 @@ public class ConfigRegionalSettingsTab {
     CTabItem wRegionalTab = new CTabItem(wTabFolder, SWT.NONE);
     wRegionalTab.setFont(GuiResource.getInstance().getFontDefault());
     wRegionalTab.setText(BaseMessages.getString(PKG, 
"ConfigRegionalSettingsTab.Title"));
-    wRegionalTab.setImage(GuiResource.getInstance().getImageOptions());
+    wRegionalTab.setImage(GuiResource.getInstance().getImageGlobe());
 
     ScrolledComposite sRegionalComp =
         new ScrolledComposite(wTabFolder, SWT.V_SCROLL | SWT.H_SCROLL);
diff --git a/ui/src/main/resources/ui/images/globe.svg 
b/ui/src/main/resources/ui/images/globe.svg
new file mode 100644
index 0000000000..0adbebdb8c
--- /dev/null
+++ b/ui/src/main/resources/ui/images/globe.svg
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg"; viewBox="0 0 24 24">
+<path fill="#0F3B5A" clip-rule="evenodd" d="M10.059 2.188a10.016 10.016 0 0 
0-7.242 5.847h4.616a16.98 16.98 0 0 1 2.19-5.162l.436-.685zM2.202 9.99a10.04 
10.04 0 0 0 0 4.021c.094-.029.194-.044.298-.044h4.579a17.026 17.026 0 0 1 
0-3.931H2.5a.978.978 0 0 1-.298-.046zm.615 5.976a10.017 10.017 0 0 0 7.242 
5.847l-.436-.685a16.98 16.98 0 0 1-2.19-5.161H2.817zm11.124 5.847a10.017 10.017 
0 0 0 7.242-5.847h-4.616a16.98 16.98 0 0 1-2.19 
5.162l-.436.685zm7.857-7.802a10.037 10.037 0 0 0 0-4.02a1.009  [...]
+</svg>
\ No newline at end of file

Reply via email to