ShiKaiWi commented on PR #1423: URL: https://github.com/apache/incubator-horaedb/pull/1423#issuecomment-1883002186
@jiacai2050 During the merge, a field called `request_id_str` seems not a good name: https://github.com/apache/incubator-horaedb-proto/blob/4a6f323b892c5944acdcf5447a3cc1e0c18f6e16/protos/engine/remote_engine.proto#L178C3-L178C29. I guess a better name is necessary before this pr is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
