ShiKaiWi commented on code in PR #1440:
URL:
https://github.com/apache/incubator-horaedb/pull/1440#discussion_r1461466496
##########
analytic_engine/src/sst/meta_data/cache.rs:
##########
@@ -74,6 +75,11 @@ impl MetaData {
meta_path = kv_meta.value.as_ref().map(|path|
Path::from(path.as_str()))
} else if kv_meta.key == encoding::META_VERSION_KEY {
meta_version =
kv_meta.value.as_ref().context(KvMetaVersionEmpty)?;
+ } else if kv_meta.key == encoding::META_SIZE_KEY {
+ let size = kv_meta.value.as_ref().context(KvMetaVersionEmpty)?;
+ meta_size = Some(size.parse::<usize>().with_context(||
InvalidSize {
+ size: size.to_string(),
+ })?);
Review Comment:
I guess snafu will auto clone for the string reference:
```suggestion
meta_size = Some(size.parse::<usize>().context(InvalidSize {
size,
}?);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
