Lethannn commented on code in PR #1492:
URL:
https://github.com/apache/incubator-horaedb/pull/1492#discussion_r1517247480
##########
Cargo.toml:
##########
@@ -107,6 +107,7 @@ cluster = { path = "src/cluster" }
criterion = "0.5"
horaedb-client = "1.0.2"
common_types = { path = "src/common_types" }
+dashmap = "5.5.3"
Review Comment:
> > then every time I grap a mutable reference to a value from the map, it
locks the entire map.
>
> I think it's find to use plain Mutex here, since they are not the bottle
neck, `replay_table_log_entries` is the most heavy task in this place.
>
> Also, there is a partitioned lock in our codebase, you can use if you want
to optimize here:
>
>
https://github.com/apache/incubator-horaedb/blob/9f166f3daa9a02ef8af1e733c22f956ab97e7aaf/src/components/partitioned_lock/src/lib.rs#L130
Awesome! I'm gonna check it out. Thx for the heads up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
