ShiKaiWi commented on code in PR #1533:
URL:
https://github.com/apache/incubator-horaedb/pull/1533#discussion_r1613103574
##########
src/analytic_engine/src/table_options.rs:
##########
@@ -476,6 +484,22 @@ impl TableOptions {
m
}
+ /// Check if the options are valid.
+ pub fn is_valid(&self) -> bool {
Review Comment:
Shall we throw the error message to let the caller/user know where the
option is wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
