jiacai2050 commented on code in PR #1588:
URL: https://github.com/apache/horaedb/pull/1588#discussion_r1830626919
##########
horaedb/metric_engine/src/storage.rs:
##########
@@ -184,6 +190,34 @@ impl CloudObjectStorage {
execute_stream(physical_plan, ctx.task_ctx()).context("execute
sort physical plan")?;
Ok(res)
}
+
+ fn build_write_props(write_options: WriteOptions, num_primary_key: usize)
-> WriterProperties {
+ let sorting_columns = write_options.enable_sorting_columns.then(|| {
+ (0..num_primary_key)
+ .map(|i| SortingColumn::new(i as i32, false, false))
Review Comment:
Add comments like this to explain what the param means.
`false /* desc */`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
