zealchen commented on code in PR #1594:
URL: https://github.com/apache/horaedb/pull/1594#discussion_r1855079974
##########
src/table_engine/src/partition/rule/key.rs:
##########
@@ -139,15 +141,33 @@ impl KeyRule {
&self,
group: &[usize],
filters: &[PartitionFilter],
- ) -> Result<BTreeSet<usize>> {
+ ) -> Result<PartitionedFilterKeyIndex> {
let mut partitions = BTreeSet::new();
+ // Retrieve all the key DatumView instances along with their
corresponding
+ // indices related to their positions in the predicate inlist. Since
DatumView
Review Comment:
Only the Hash trait is not adequate, since a HashSet requires that the
elements implement the [Eq](https://doc.rust-lang.org/std/cmp/trait.Eq.html)
and [Hash](https://doc.rust-lang.org/std/hash/trait.Hash.html) traits. Why
don't you implement Eq, btw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
